Re: [PATCH] staging: gasket: apex: Modify return type suggested by Coccinelle.

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Apr 01, 2019 at 06:59:06PM +0530, Sanjana Sanikommu wrote:
> The last two lines in the function could
> be compressed into one. Avoid usage of local variable.
> Issue found by Coccinelle using ret.cocci.
> 
> Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
> ---
>  drivers/staging/gasket/apex_driver.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/gasket/apex_driver.c b/drivers/staging/gasket/apex_driver.c
> index a79613db71ef..2be45ee9d061 100644
> --- a/drivers/staging/gasket/apex_driver.c
> +++ b/drivers/staging/gasket/apex_driver.c
> @@ -439,9 +439,7 @@ static int apex_reset(struct gasket_dev *gasket_dev)
>  		if (ret)
>  			return ret;
>  	}
> -	ret = apex_quit_reset(gasket_dev);
> -
> -	return ret;
> +	return apex_quit_reset(gasket_dev);
>  }
>  
>  /*

This patch does not apply to my tree at all, I think someone else
already did this before you did.  Please update your local tree and
verify this.

thanks,

greg k-h