[PATCH] staging: gasket: apex: Modify return type suggested by Coccinelle.

[PATCH] staging: gasket: apex: Modify return type suggested by Coccinelle.

[Sanjana Sanikommu]

The last two lines in the function could
be compressed into one. Avoid usage of local variable.
Issue found by Coccinelle using ret.cocci.

Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
---
 drivers/staging/gasket/apex_driver.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/gasket/apex_driver.c b/drivers/staging/gasket/apex_driver.c
index a79613db71ef..2be45ee9d061 100644
--- a/drivers/staging/gasket/apex_driver.c
+++ b/drivers/staging/gasket/apex_driver.c
@@ -439,9 +439,7 @@ static int apex_reset(struct gasket_dev *gasket_dev)
 		if (ret)
 			return ret;
 	}
-	ret = apex_quit_reset(gasket_dev);
-
-	return ret;
+	return apex_quit_reset(gasket_dev);
 }
 
 /*
-- 
2.17.1

Re: [PATCH] staging: gasket: apex: Modify return type suggested by Coccinelle.

[Greg KH]

On Mon, Apr 01, 2019 at 06:59:06PM +0530, Sanjana Sanikommu wrote:
> The last two lines in the function could
> be compressed into one. Avoid usage of local variable.
> Issue found by Coccinelle using ret.cocci.
> 
> Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
> ---
>  drivers/staging/gasket/apex_driver.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/gasket/apex_driver.c b/drivers/staging/gasket/apex_driver.c
> index a79613db71ef..2be45ee9d061 100644
> --- a/drivers/staging/gasket/apex_driver.c
> +++ b/drivers/staging/gasket/apex_driver.c
> @@ -439,9 +439,7 @@ static int apex_reset(struct gasket_dev *gasket_dev)
>  		if (ret)
>  			return ret;
>  	}
> -	ret = apex_quit_reset(gasket_dev);
> -
> -	return ret;
> +	return apex_quit_reset(gasket_dev);
>  }
>  
>  /*

This patch does not apply to my tree at all, I think someone else
already did this before you did.  Please update your local tree and
verify this.

thanks,

greg k-h

Re: [PATCH] staging: gasket: apex: Modify return type suggested by Coccinelle.

[sanjana99reddy99]

[-- Attachment #1.1: Type: text/plain, Size: 1295 bytes --]



On Monday, April 1, 2019 at 11:11:07 PM UTC+5:30, gregkh wrote:
>
> On Mon, Apr 01, 2019 at 06:59:06PM +0530, Sanjana Sanikommu wrote: 
> > The last two lines in the function could 
> > be compressed into one. Avoid usage of local variable. 
> > Issue found by Coccinelle using ret.cocci. 
> > 
> > Signed-off-by: Sanjana Sanikommu <sanjana9...@gmail.com <javascript:>> 
> > --- 
> >  drivers/staging/gasket/apex_driver.c | 4 +--- 
> >  1 file changed, 1 insertion(+), 3 deletions(-) 
> > 
> > diff --git a/drivers/staging/gasket/apex_driver.c 
> b/drivers/staging/gasket/apex_driver.c 
> > index a79613db71ef..2be45ee9d061 100644 
> > --- a/drivers/staging/gasket/apex_driver.c 
> > +++ b/drivers/staging/gasket/apex_driver.c 
> > @@ -439,9 +439,7 @@ static int apex_reset(struct gasket_dev *gasket_dev) 
> >                  if (ret) 
> >                          return ret; 
> >          } 
> > -        ret = apex_quit_reset(gasket_dev); 
> > - 
> > -        return ret; 
> > +        return apex_quit_reset(gasket_dev); 
> >  } 
> >   
> >  /* 
>
> This patch does not apply to my tree at all, I think someone else 
> already did this before you did.  Please update your local tree and 
> verify this. 
>

   Sure, I would drop this.
   Thanks
    Sanjana 

>
> thanks, 
>
> greg k-h 
>

[-- Attachment #1.2: Type: text/html, Size: 2077 bytes --]