Re: [v2 3/7] drm: Add gamma mode property

From: Sam Ravnborg <sam@ravnborg.org>
To: Uma Shankar <uma.shankar@intel.com>
Cc: dcastagna@chromium.org, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, seanpaul@chromium.org,
	ville.syrjala@intel.com, maarten.lankhorst@intel.com
Subject: Re: [v2 3/7] drm: Add gamma mode property
Date: Mon, 1 Apr 2019 20:37:26 +0200	[thread overview]
Message-ID: <20190401183726.GC886@ravnborg.org> (raw)
In-Reply-To: <1554139811-13280-4-git-send-email-uma.shankar@intel.com>

Hi Uma.

> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -256,6 +256,13 @@ struct drm_crtc_state {
>  	struct drm_property_blob *gamma_mode_caps;
>  
>  	/**
> +	 * @gamma_mode:
> +	 *
> +	 * FIXME
> +	 */
> +	struct drm_property_blob *gamma_mode;

HEre the name matches, but please add documentation too.

>  
> +struct drm_color_mode_lut {
> +	/* DRM_MODE_LUT_* */
> +	__u32 flags;
> +	/* number of points on the curve */
> +	__u32 count;
> +	/* Name of Gamma Mode */
> +	char name[DRM_PROP_NAME_LEN];
> +	/* Pointer to Lut elements */
> +	__u64 lut;
> +};
From an alignment point of view the __u64 should come before the char name[].
But the above may be fine depending on DRM_PROP_NAME_LEN

	Sam
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx