From: Brian Masney <masneyb@onstation.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: lee.jones@linaro.org, daniel.thompson@linaro.org,
jingoohan1@gmail.com, robh+dt@kernel.org,
jacek.anaszewski@gmail.com, mark.rutland@arm.com,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
dmurphy@ti.com, jonathan@marek.ca
Subject: Re: [PATCH v2 3/3] backlight: lm3630a: add device tree supprt
Date: Tue, 02 Apr 2019 00:02:17 +0000 [thread overview]
Message-ID: <20190402000217.GA8315@basecamp> (raw)
In-Reply-To: <20190401214847.GE14681@amd>
On Mon, Apr 01, 2019 at 11:48:47PM +0200, Pavel Machek wrote:
> So ... we can have multiple LEDs, each can have up to two
> sources.. and the settings are really per source, not per LED.
>
> But you do not test for overlaps. What prevents me from having
>
> foo {
> led_sources = <0>;
> ti,linear-mapping-mode;
> }
> bar {
> led_sources = <0>;
> }
>
> (I.e. conflicting settings for a source?)
In this case, it will go with the settings for 'bar'. I didn't check for
the conflicting settings since I was going for consistency with the
other two backlight drivers that already have the led-sources property:
arcxcnn_bl.c and sky81452-backlight.c. I can add the additional check
to fail if a source has already been encountered.
> Plus I do not see parsing of led labels etc...
OK... I can fix that up plus your other two comments.
Thanks,
Brian
WARNING: multiple messages have this Message-ID (diff)
From: Brian Masney <masneyb@onstation.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: lee.jones@linaro.org, daniel.thompson@linaro.org,
jingoohan1@gmail.com, robh+dt@kernel.org,
jacek.anaszewski@gmail.com, mark.rutland@arm.com,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
dmurphy@ti.com, jonathan@marek.ca
Subject: Re: [PATCH v2 3/3] backlight: lm3630a: add device tree supprt
Date: Mon, 1 Apr 2019 20:02:17 -0400 [thread overview]
Message-ID: <20190402000217.GA8315@basecamp> (raw)
In-Reply-To: <20190401214847.GE14681@amd>
On Mon, Apr 01, 2019 at 11:48:47PM +0200, Pavel Machek wrote:
> So ... we can have multiple LEDs, each can have up to two
> sources.. and the settings are really per source, not per LED.
>
> But you do not test for overlaps. What prevents me from having
>
> foo {
> led_sources = <0>;
> ti,linear-mapping-mode;
> }
> bar {
> led_sources = <0>;
> }
>
> (I.e. conflicting settings for a source?)
In this case, it will go with the settings for 'bar'. I didn't check for
the conflicting settings since I was going for consistency with the
other two backlight drivers that already have the led-sources property:
arcxcnn_bl.c and sky81452-backlight.c. I can add the additional check
to fail if a source has already been encountered.
> Plus I do not see parsing of led labels etc...
OK... I can fix that up plus your other two comments.
Thanks,
Brian
next prev parent reply other threads:[~2019-04-02 0:02 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 10:30 [PATCH v2 0/3] backlight: lm3630a: bug fix and device tree support Brian Masney
2019-04-01 10:30 ` Brian Masney
2019-04-01 10:30 ` [PATCH v2 1/3] backlight: lm3630a: return 0 on success in update_status functions Brian Masney
2019-04-01 10:30 ` Brian Masney
2019-04-01 21:34 ` Pavel Machek
2019-04-01 21:34 ` Pavel Machek
2019-04-01 10:30 ` [PATCH v2 2/3] dt-bindings: backlight: add lm3630a bindings Brian Masney
2019-04-01 10:30 ` Brian Masney
2019-04-01 21:39 ` Pavel Machek
2019-04-01 21:39 ` Pavel Machek
2019-04-01 21:39 ` Pavel Machek
2019-04-01 23:04 ` Brian Masney
2019-04-01 23:04 ` Brian Masney
2019-04-02 12:56 ` Dan Murphy
2019-04-02 12:56 ` Dan Murphy
2019-04-02 12:56 ` Dan Murphy
2019-04-02 13:24 ` Brian Masney
2019-04-02 13:24 ` Brian Masney
2019-04-02 13:44 ` Dan Murphy
2019-04-02 13:44 ` Dan Murphy
2019-04-02 13:44 ` Dan Murphy
2019-04-07 11:28 ` Brian Masney
2019-04-07 11:28 ` Brian Masney
2019-04-03 1:50 ` Rob Herring
2019-04-03 1:50 ` Rob Herring
2019-04-03 1:50 ` Rob Herring
2019-04-01 10:30 ` [PATCH v2 3/3] backlight: lm3630a: add device tree supprt Brian Masney
2019-04-01 10:30 ` Brian Masney
2019-04-01 21:48 ` Pavel Machek
2019-04-01 21:48 ` Pavel Machek
2019-04-01 21:48 ` Pavel Machek
2019-04-02 0:02 ` Brian Masney [this message]
2019-04-02 0:02 ` Brian Masney
2019-04-02 13:45 ` Dan Murphy
2019-04-02 13:45 ` Dan Murphy
2019-04-02 13:45 ` Dan Murphy
2019-04-02 16:45 ` Pavel Machek
2019-04-02 16:45 ` Pavel Machek
2019-04-02 17:07 ` Dan Murphy
2019-04-02 17:07 ` Dan Murphy
2019-04-02 17:07 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402000217.GA8315@basecamp \
--to=masneyb@onstation.org \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=jonathan@marek.ca \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.