All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Himadri Pandya <himadri18.07@gmail.com>
Cc: laurent.pinchart@ideasonboard.com, mchehab@kernel.org,
	outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 0/2] staging: media: omap4iss: redefine and use to_iss_buffer
Date: Tue, 2 Apr 2019 07:53:17 +0200	[thread overview]
Message-ID: <20190402055317.GD14075@kroah.com> (raw)
In-Reply-To: <20190401192015.96166-1-himadri18.07@gmail.com>

On Tue, Apr 02, 2019 at 12:50:13AM +0530, Himadri Pandya wrote:
> These patches 
> - redefines an unused macro to_iss_buffer into an inline
> function
> - uses that inline function in suitable functions
> 
> Himadri Pandya (2):
>   staging: media: omap4iss: redefine to_iss_buffer()
>   staging: media: omap4iss: use to_iss_buffer instead of container_of

Can you make this one patch?  It makes things a lot more obvious as to
why you are doing what you did in patch 1, when you see patch 2, so
these should just be together.

thanks,

greg k-h


  parent reply	other threads:[~2019-04-02  5:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 19:20 [PATCH 0/2] staging: media: omap4iss: redefine and use to_iss_buffer Himadri Pandya
2019-04-01 19:20 ` [PATCH 1/2] staging: media: omap4iss: redefine to_iss_buffer() Himadri Pandya
2019-04-02  6:58   ` Laurent Pinchart
2019-04-02  8:49     ` Himadri Pandya
2019-04-01 19:20 ` [PATCH 2/2] staging: media: omap4iss: use to_iss_buffer instead of container_of Himadri Pandya
2019-04-02  5:53 ` Greg KH [this message]
2019-04-02  8:41   ` [PATCH 0/2] staging: media: omap4iss: redefine and use to_iss_buffer Himadri Pandya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190402055317.GD14075@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=himadri18.07@gmail.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=mchehab@kernel.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.