Re: [PATCH 1/2] staging: media: omap4iss: redefine to_iss_buffer()

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Himadri,

Thank you for the patch.

On Tue, Apr 02, 2019 at 12:50:14AM +0530, Himadri Pandya wrote:
> Currently macro to_iss_buffer converts vb2_v4l2_buffer into iss_buffer.
> But the application needs the conversion from vb2_buffer to iss_bufffer.
> So they need to convert vb2_buffer into vb2_v4l2_buffer first and then
> vb2_v4l2_buffer into iss_buffer. Redefining to_iss_buffer to convert
> from vb2_buffer into iss_buffer directly helps the situation.
> 
> Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
> ---
>  drivers/staging/media/omap4iss/iss_video.h | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/omap4iss/iss_video.h b/drivers/staging/media/omap4iss/iss_video.h
> index f22489edb562..3722ac8ba2fa 100644
> --- a/drivers/staging/media/omap4iss/iss_video.h
> +++ b/drivers/staging/media/omap4iss/iss_video.h
> @@ -118,7 +118,12 @@ struct iss_buffer {
>  	dma_addr_t iss_addr;
>  };
>  
> -#define to_iss_buffer(buf)	container_of(buf, struct iss_buffer, vb)
> +static inline struct iss_buffer *to_iss_buffer(struct vb2_buffer *vb)
> +{
> +	struct vb2_v4l2_buffer *vbuf = container_of(vb, struct vb2_v4l2_buffer, vb2_buf);
> +
> +	return container_of(vbuf, struct iss_buffer, vb);

In addition to Greg's comment about merging the two patches in one, you
can also merge the above two lines with

	container_of(vb, iss_buffer, vb.vb2_buf)

> +}
>  
>  enum iss_video_dmaqueue_flags {
>  	/* Set if DMA queue becomes empty when ISS_PIPELINE_STREAM_CONTINUOUS */

-- 
Regards,

Laurent Pinchart