All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] staging: rtl8723bs: include: Remove unnecessary typedef.
@ 2019-04-02  8:43 Sanjana Sanikommu
  2019-04-02  9:02 ` [Outreachy kernel] " Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Sanjana Sanikommu @ 2019-04-02  8:43 UTC (permalink / raw)
  To: gregkh; +Cc: outreachy-kernel

Typedef no longer affect the code.

Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
---
Changes in v2:
Delete unnecessary typedef.
 drivers/staging/rtl8723bs/include/ieee80211.h | 54 -------------------
 1 file changed, 54 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/staging/rtl8723bs/include/ieee80211.h
index 9efb4dcb9d3a..0f085b26c476 100644
--- a/drivers/staging/rtl8723bs/include/ieee80211.h
+++ b/drivers/staging/rtl8723bs/include/ieee80211.h
@@ -201,53 +201,6 @@ enum NETWORK_TYPE
 
 #define IsSupportedVHT(NetType) (((NetType) & (WIRELESS_11AC)) ? true : false)
 
-
-typedef struct ieee_param {
-	u32 cmd;
-	u8 sta_addr[ETH_ALEN];
-	union {
-		struct {
-			u8 name;
-			u32 value;
-		} wpa_param;
-		struct {
-			u32 len;
-			u8 reserved[32];
-			u8 data[0];
-		} wpa_ie;
-	        struct{
-			int command;
-			int reason_code;
-		} mlme;
-		struct {
-			u8 alg[IEEE_CRYPT_ALG_NAME_LEN];
-			u8 set_tx;
-			u32 err;
-			u8 idx;
-			u8 seq[8]; /* sequence counter (set: RX, get: TX) */
-			u16 key_len;
-			u8 key[0];
-		} crypt;
-		struct {
-			u16 aid;
-			u16 capability;
-			int flags;
-			u8 tx_supp_rates[16];
-			struct rtw_ieee80211_ht_cap ht_cap;
-		} add_sta;
-		struct {
-			u8 reserved[2];/* for set max_num_sta */
-			u8 buf[0];
-		} bcn_ie;
-	} u;
-}ieee_param;
-
-typedef struct ieee_param_ex {
-	u32 cmd;
-	u8 sta_addr[ETH_ALEN];
-	u8 data[0];
-}ieee_param_ex;
-
 struct sta_data{
 	u16 aid;
 	u16 capability;
@@ -870,13 +823,6 @@ static inline int is_zero_mac_addr(const u8 *addr)
 #define CFG_IEEE80211_RESERVE_FCS (1<<0)
 #define CFG_IEEE80211_COMPUTE_FCS (1<<1)
 
-typedef struct tx_pending_t{
-	int frag;
-	struct ieee80211_txb *txb;
-}tx_pending_t;
-
-
-
 #define MAXTID	16
 
 #define IEEE_A            (1<<0)
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: include: Remove unnecessary typedef.
  2019-04-02  8:43 [PATCH v2] staging: rtl8723bs: include: Remove unnecessary typedef Sanjana Sanikommu
@ 2019-04-02  9:02 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-04-02  9:02 UTC (permalink / raw)
  To: Sanjana Sanikommu; +Cc: outreachy-kernel

On Tue, Apr 02, 2019 at 02:13:38PM +0530, Sanjana Sanikommu wrote:
> Typedef no longer affect the code.

I'm sorry, but I do not understand this sentence :(

Can you try to explain why you are doing what you are doing a bit better
when you resend this?

thanks,

greg k-h


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-04-02  9:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-02  8:43 [PATCH v2] staging: rtl8723bs: include: Remove unnecessary typedef Sanjana Sanikommu
2019-04-02  9:02 ` [Outreachy kernel] " Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.