All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Copeland <me@bobcopeland.com>
To: Balaji Pothunoori <bpothuno@codeaurora.org>
Cc: johannes@sipsolutions.net,
	Ashok Raj Nagarajan <arnagara@codeaurora.org>,
	linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v4 3/3] ath10k: add support for controlling tx power to a station
Date: Tue, 2 Apr 2019 18:37:09 -0400	[thread overview]
Message-ID: <20190402223709.GB8910@localhost> (raw)
In-Reply-To: <1553856587-21611-1-git-send-email-bpothuno@codeaurora.org>

On Fri, Mar 29, 2019 at 04:19:47PM +0530, Balaji Pothunoori wrote:
> From: Ashok Raj Nagarajan <arnagara@codeaurora.org>
> 
> This patch will add the support to control the transmit power for traffic
> to a station associated with the AP.
> 
> Underlying firmware will enforce that the maximum tx power will be based
> on the regulatory requirements. If the user given transmit power is greater
> than the allowed tx power in the given channel, then the firmware will use
> the maximum tx power in the same channel.
> 
> When 0 is sent to the firmware as tx power, it will revert to the default
> tx power for the station.
> 
> Tested Hardware : QCA9984
> Tested Firmware : 10.4-3.9.0.1-00013

I tried this on qca9984 with 10.4-3.9.0.2-00040, which claims to support
this feature, and it didn't seem to work:

- with global tx power limit set to 30 dBm, I started an iperf from station
  A -> B

- while iperf underway, I did tcpdump on a monitor on B and looked at signal
  level in radiotap, in this case around -75 dBm

- on A, changed the per-sta txpwr limit for B to something (tried as low as
  1 dBm).  verified via printk that it went through to the driver / firmware
  command and reported no error
  -> result: signal level unchanged

- on A, changed the global tx power limit to 1 dBm
  -> result: signal level dropped to ~ -95 dBm

Reading the description above, now I'm wondering if the txpower is
max(sta-power,global-power)?  If so, that seems a bit unintuitive to me,
or at least isn't what I hoped for.  I'd prefer to have per-sta power
setting override the global power.

-- 
Bob Copeland %% https://bobcopeland.com/

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Bob Copeland <me@bobcopeland.com>
To: Balaji Pothunoori <bpothuno@codeaurora.org>
Cc: johannes@sipsolutions.net, ath10k@lists.infradead.org,
	linux-wireless@vger.kernel.org,
	Ashok Raj Nagarajan <arnagara@codeaurora.org>
Subject: Re: [PATCH v4 3/3] ath10k: add support for controlling tx power to a station
Date: Tue, 2 Apr 2019 18:37:09 -0400	[thread overview]
Message-ID: <20190402223709.GB8910@localhost> (raw)
In-Reply-To: <1553856587-21611-1-git-send-email-bpothuno@codeaurora.org>

On Fri, Mar 29, 2019 at 04:19:47PM +0530, Balaji Pothunoori wrote:
> From: Ashok Raj Nagarajan <arnagara@codeaurora.org>
> 
> This patch will add the support to control the transmit power for traffic
> to a station associated with the AP.
> 
> Underlying firmware will enforce that the maximum tx power will be based
> on the regulatory requirements. If the user given transmit power is greater
> than the allowed tx power in the given channel, then the firmware will use
> the maximum tx power in the same channel.
> 
> When 0 is sent to the firmware as tx power, it will revert to the default
> tx power for the station.
> 
> Tested Hardware : QCA9984
> Tested Firmware : 10.4-3.9.0.1-00013

I tried this on qca9984 with 10.4-3.9.0.2-00040, which claims to support
this feature, and it didn't seem to work:

- with global tx power limit set to 30 dBm, I started an iperf from station
  A -> B

- while iperf underway, I did tcpdump on a monitor on B and looked at signal
  level in radiotap, in this case around -75 dBm

- on A, changed the per-sta txpwr limit for B to something (tried as low as
  1 dBm).  verified via printk that it went through to the driver / firmware
  command and reported no error
  -> result: signal level unchanged

- on A, changed the global tx power limit to 1 dBm
  -> result: signal level dropped to ~ -95 dBm

Reading the description above, now I'm wondering if the txpower is
max(sta-power,global-power)?  If so, that seems a bit unintuitive to me,
or at least isn't what I hoped for.  I'd prefer to have per-sta power
setting override the global power.

-- 
Bob Copeland %% https://bobcopeland.com/

  reply	other threads:[~2019-04-02 22:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-29 10:49 [PATCH v4 3/3] ath10k: add support for controlling tx power to a station Balaji Pothunoori
2019-03-29 10:49 ` Balaji Pothunoori
2019-04-02 22:37 ` Bob Copeland [this message]
2019-04-02 22:37   ` Bob Copeland
2019-09-18 13:41   ` Kalle Valo
2019-09-18 13:41     ` Kalle Valo
2019-09-19  0:21     ` Bob Copeland
2019-09-19  0:21       ` Bob Copeland
2019-09-19  8:04       ` Balaji Pothunoori
2019-09-19  8:04         ` Balaji Pothunoori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190402223709.GB8910@localhost \
    --to=me@bobcopeland.com \
    --cc=arnagara@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=bpothuno@codeaurora.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.