* [Buildroot] [PATCH] package/luajit: bump to version 2.1.x developpment version
@ 2019-04-02 14:49 Jugurtha BELKALEM
2019-04-03 6:23 ` François Perrad
2019-04-03 7:18 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Jugurtha BELKALEM @ 2019-04-02 14:49 UTC (permalink / raw)
To: buildroot
In order to integrate bcc (front end tool for eBPF) into buildroot
and testing it on a Raspberry PI 3; We need to upgrade the version
of luajit to 2.1.0 to support aarch64.
Currently, luajit aarch64_be support has not been tested.
Signed-off-by: Jugurtha BELKALEM <jugurtha.belkalem@smile.fr>
Cc: Francois Perrad <francois.perrad@gadz.org>
---
package/luajit/Config.in | 2 +-
package/luajit/luajit.hash | 4 ++--
package/luajit/luajit.mk | 5 ++---
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/package/luajit/Config.in b/package/luajit/Config.in
index 88c5bcb..9ecf6b4 100644
--- a/package/luajit/Config.in
+++ b/package/luajit/Config.in
@@ -1,6 +1,6 @@
config BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
bool
- default y if BR2_i386 || \
+ default y if BR2_i386 || BR2_aarch64 || \
(BR2_x86_64 && BR2_HOSTARCH='x86_64') || \
BR2_powerpc || BR2_arm || BR2_armeb || \
((BR2_mips || BR2_mipsel) && !BR2_MIPS_SOFT_FLOAT && \
diff --git a/package/luajit/luajit.hash b/package/luajit/luajit.hash
index 2081d12..b422bc9 100644
--- a/package/luajit/luajit.hash
+++ b/package/luajit/luajit.hash
@@ -1,2 +1,2 @@
-# Hashes from: http://luajit.org/download.html
-md5 48353202cbcacab84ee41a5a70ea0a2c LuaJIT-2.0.5.tar.gz
+# Localy generated
+sha256 ad5077bd861241bf5e50ae4bf543d291c5fcffab95ccc3218401131f503e45bd luajit-f0e865dd4861520258299d0f2a56491bd9d602e1.tar.gz
diff --git a/package/luajit/luajit.mk b/package/luajit/luajit.mk
index 5b08a42..9a06691 100644
--- a/package/luajit/luajit.mk
+++ b/package/luajit/luajit.mk
@@ -4,9 +4,8 @@
#
################################################################################
-LUAJIT_VERSION = 2.0.5
-LUAJIT_SOURCE = LuaJIT-$(LUAJIT_VERSION).tar.gz
-LUAJIT_SITE = http://luajit.org/download
+LUAJIT_VERSION = f0e865dd4861520258299d0f2a56491bd9d602e1
+LUAJIT_SITE = $(call github,luajit,luajit,$(LUAJIT_VERSION))
LUAJIT_LICENSE = MIT
LUAJIT_LICENSE_FILES = COPYRIGHT
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/luajit: bump to version 2.1.x developpment version
2019-04-02 14:49 [Buildroot] [PATCH] package/luajit: bump to version 2.1.x developpment version Jugurtha BELKALEM
@ 2019-04-03 6:23 ` François Perrad
2019-04-03 7:18 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: François Perrad @ 2019-04-03 6:23 UTC (permalink / raw)
To: buildroot
Le mar. 2 avr. 2019 ? 16:49, Jugurtha BELKALEM <jugurtha.belkalem@smile.fr>
a ?crit :
> In order to integrate bcc (front end tool for eBPF) into buildroot
> and testing it on a Raspberry PI 3; We need to upgrade the version
> of luajit to 2.1.0 to support aarch64.
>
> Currently, luajit aarch64_be support has not been tested.
>
> Signed-off-by: Jugurtha BELKALEM <jugurtha.belkalem@smile.fr>
> Cc: Francois Perrad <francois.perrad@gadz.org>
> ---
> package/luajit/Config.in | 2 +-
> package/luajit/luajit.hash | 4 ++--
> package/luajit/luajit.mk | 5 ++---
> 3 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/package/luajit/Config.in b/package/luajit/Config.in
> index 88c5bcb..9ecf6b4 100644
> --- a/package/luajit/Config.in
> +++ b/package/luajit/Config.in
> @@ -1,6 +1,6 @@
> config BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
> bool
> - default y if BR2_i386 || \
> + default y if BR2_i386 || BR2_aarch64 || \
> (BR2_x86_64 && BR2_HOSTARCH='x86_64') || \
> BR2_powerpc || BR2_arm || BR2_armeb || \
> ((BR2_mips || BR2_mipsel) && !BR2_MIPS_SOFT_FLOAT && \
> diff --git a/package/luajit/luajit.hash b/package/luajit/luajit.hash
> index 2081d12..b422bc9 100644
> --- a/package/luajit/luajit.hash
> +++ b/package/luajit/luajit.hash
> @@ -1,2 +1,2 @@
> -# Hashes from: http://luajit.org/download.html
> -md5 48353202cbcacab84ee41a5a70ea0a2c LuaJIT-2.0.5.tar.gz
> +# Localy generated
> +sha256 ad5077bd861241bf5e50ae4bf543d291c5fcffab95ccc3218401131f503e45bd
> luajit-f0e865dd4861520258299d0f2a56491bd9d602e1.tar.gz
> diff --git a/package/luajit/luajit.mk b/package/luajit/luajit.mk
> index 5b08a42..9a06691 100644
> --- a/package/luajit/luajit.mk
> +++ b/package/luajit/luajit.mk
> @@ -4,9 +4,8 @@
> #
>
> ################################################################################
>
> -LUAJIT_VERSION = 2.0.5
> -LUAJIT_SOURCE = LuaJIT-$(LUAJIT_VERSION).tar.gz
> -LUAJIT_SITE = http://luajit.org/download
> +LUAJIT_VERSION = f0e865dd4861520258299d0f2a56491bd9d602e1
>
Could you use the version 2.1.0-beta3 which is available (with its hash) on
http://luajit.org/download.html ?
Fran?ois
+LUAJIT_SITE = $(call github,luajit,luajit,$(LUAJIT_VERSION))
> LUAJIT_LICENSE = MIT
> LUAJIT_LICENSE_FILES = COPYRIGHT
>
> --
> 2.7.4
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190403/0a6cef5e/attachment-0001.html>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/luajit: bump to version 2.1.x developpment version
2019-04-02 14:49 [Buildroot] [PATCH] package/luajit: bump to version 2.1.x developpment version Jugurtha BELKALEM
2019-04-03 6:23 ` François Perrad
@ 2019-04-03 7:18 ` Thomas Petazzoni
2019-04-03 9:15 ` Jugurtha BELKALEM
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2019-04-03 7:18 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 2 Apr 2019 16:49:35 +0200
Jugurtha BELKALEM <jugurtha.belkalem@smile.fr> wrote:
> In order to integrate bcc (front end tool for eBPF) into buildroot
> and testing it on a Raspberry PI 3; We need to upgrade the version
> of luajit to 2.1.0 to support aarch64.
>
> Currently, luajit aarch64_be support has not been tested.
>
> Signed-off-by: Jugurtha BELKALEM <jugurtha.belkalem@smile.fr>
> Cc: Francois Perrad <francois.perrad@gadz.org>
Perhaps this can be done as part of a larger patch series that
introduces 'bcc' as well ? By that time, hopefully LuaJIT 2.1.0 will
have been released, and we'll be good ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/luajit: bump to version 2.1.x developpment version
2019-04-03 7:18 ` Thomas Petazzoni
@ 2019-04-03 9:15 ` Jugurtha BELKALEM
2019-04-14 20:06 ` Arnout Vandecappelle
0 siblings, 1 reply; 6+ messages in thread
From: Jugurtha BELKALEM @ 2019-04-03 9:15 UTC (permalink / raw)
To: buildroot
Hi,
To answer the question of Fran?ois : The luajit2.1.0-beta3 version in
http://luajit.org/download.html has not been changed since 2 years (last
change in May 2017), so I guess it is better to take a version which is up
to date.
To answer the question of Thamas : We have successfully tested bcc on a
raspberry PI 3, however; the purpose of this patch is to check that it does
not break the build process in buildroot (for example luajit2.1.0 is adding
support for aarch64; we need to ensure that it is safe).
Regards.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190403/8b06e2ea/attachment.html>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/luajit: bump to version 2.1.x developpment version
2019-04-03 9:15 ` Jugurtha BELKALEM
@ 2019-04-14 20:06 ` Arnout Vandecappelle
2019-04-19 7:55 ` Romain Naour
0 siblings, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2019-04-14 20:06 UTC (permalink / raw)
To: buildroot
[Please don't remove the quoted text entirely, but quote inline like below.]
On 03/04/2019 11:15, Jugurtha BELKALEM wrote:
> Hi,
>
> To answer the question of Fran?ois : The luajit2.1.0-beta3 version in
> http://luajit.org/download.html has not been changed since 2 years (last
> change in May 2017), so I guess it is better to take a version which is up
> to date.
I feel a bit uncomfortable to bump a package to an unreleased version of a
project that is apparently not going anywhere (only a handful of commits in the
last year).
Note that any issues are likely to be runtime issues. So it really depends on
the users of luajit (if such users even exist...) to decide if they're willing
to take that risk.
> To answer the question of Thamas : We have successfully tested bcc on a
> raspberry PI 3, however; the purpose of this patch is to check that it does
> not break the build process in buildroot (for example luajit2.1.0 is adding
> support for aarch64; we need to ensure that it is safe).
So, IIUC, bcc depends on luajit (not plain Lua)? But it is fine with the
existing luajit version, only then you don't have aarch64 support?
In that case, maybe it's better to make the version dependent on the
architecture, like we sometimes do for other packages. See for instance the arc
versions of binutils, gcc, gdb, glibc.
Regards,
Arnout
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/luajit: bump to version 2.1.x developpment version
2019-04-14 20:06 ` Arnout Vandecappelle
@ 2019-04-19 7:55 ` Romain Naour
0 siblings, 0 replies; 6+ messages in thread
From: Romain Naour @ 2019-04-19 7:55 UTC (permalink / raw)
To: buildroot
Hi Arnout,
Le 14/04/2019 ? 22:06, Arnout Vandecappelle a ?crit?:
> [Please don't remove the quoted text entirely, but quote inline like below.]
>
> On 03/04/2019 11:15, Jugurtha BELKALEM wrote:
>> Hi,
>>
>> To answer the question of Fran?ois : The luajit2.1.0-beta3 version in
>> http://luajit.org/download.html has not been changed since 2 years (last
>> change in May 2017), so I guess it is better to take a version which is up
>> to date.
>
> I feel a bit uncomfortable to bump a package to an unreleased version of a
> project that is apparently not going anywhere (only a handful of commits in the
> last year).
luajit2.1.0-beta3 doesn't seems a release version but it's packaged by Debian
testing, Fedora 26+, Ubuntu 18.04.
https://repology.org/project/luajit/versions
>
> Note that any issues are likely to be runtime issues. So it really depends on
> the users of luajit (if such users even exist...) to decide if they're willing
> to take that risk.
ok
>
>> To answer the question of Thamas : We have successfully tested bcc on a
>> raspberry PI 3, however; the purpose of this patch is to check that it does
>> not break the build process in buildroot (for example luajit2.1.0 is adding
>> support for aarch64; we need to ensure that it is safe).
>
> So, IIUC, bcc depends on luajit (not plain Lua)? But it is fine with the
> existing luajit version, only then you don't have aarch64 support?
exact.
>
> In that case, maybe it's better to make the version dependent on the
> architecture, like we sometimes do for other packages. See for instance the arc
> versions of binutils, gcc, gdb, glibc.
Ok, maybe we should be careful with API break between 2.0.x and 2.1.x...
Best regards,
Romain
>
> Regards,
> Arnout
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-19 7:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-02 14:49 [Buildroot] [PATCH] package/luajit: bump to version 2.1.x developpment version Jugurtha BELKALEM
2019-04-03 6:23 ` François Perrad
2019-04-03 7:18 ` Thomas Petazzoni
2019-04-03 9:15 ` Jugurtha BELKALEM
2019-04-14 20:06 ` Arnout Vandecappelle
2019-04-19 7:55 ` Romain Naour
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.