All of lore.kernel.org
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
Subject: [RESEND PATCH stable only] nvmet: set loop queue's segment boundary mask as PAGE_SIZE - 1
Date: Wed, 3 Apr 2019 16:04:27 +0200	[thread overview]
Message-ID: <20190403140427.GD8633@kroah.com> (raw)
In-Reply-To: <20190402015610.26320-1-ming.lei@redhat.com>

On Tue, Apr 02, 2019@09:56:10AM +0800, Ming Lei wrote:
> NVMe target only accepts single-page sg list, either file or block
> device backed target code follows this assumption.
> 
> However, loop target is one exception, given the sg list is from
> the host queue directly.
> 
> This patch sets loop queue's segment boundary mask as PAGE_SIZE - 1
> for following NVMe target assumption.
> 
> Multi-page bvec has been merged to v5.1-rc1, so commit 02db99548d36
> ("nvmet: fix building bvec from sg list") can fix the current issue
> simply without needing to limit the segment size for nvme-loop.

I don't understand, 02db99548d36 does not work for older kernels, so
because of that, you need/want this patch to be applied?  If so, what
specific kernel versions do you want this to go to?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
	Yi Zhang <yi.zhang@redhat.com>, Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
	stable@vger.kernel.org
Subject: Re: [RESEND PATCH stable only] nvmet: set loop queue's segment boundary mask as PAGE_SIZE - 1
Date: Wed, 3 Apr 2019 16:04:27 +0200	[thread overview]
Message-ID: <20190403140427.GD8633@kroah.com> (raw)
In-Reply-To: <20190402015610.26320-1-ming.lei@redhat.com>

On Tue, Apr 02, 2019 at 09:56:10AM +0800, Ming Lei wrote:
> NVMe target only accepts single-page sg list, either file or block
> device backed target code follows this assumption.
> 
> However, loop target is one exception, given the sg list is from
> the host queue directly.
> 
> This patch sets loop queue's segment boundary mask as PAGE_SIZE - 1
> for following NVMe target assumption.
> 
> Multi-page bvec has been merged to v5.1-rc1, so commit 02db99548d36
> ("nvmet: fix building bvec from sg list") can fix the current issue
> simply without needing to limit the segment size for nvme-loop.

I don't understand, 02db99548d36 does not work for older kernels, so
because of that, you need/want this patch to be applied?  If so, what
specific kernel versions do you want this to go to?

thanks,

greg k-h

  reply	other threads:[~2019-04-03 14:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-02  1:56 [RESEND PATCH stable only] nvmet: set loop queue's segment boundary mask as PAGE_SIZE - 1 Ming Lei
2019-04-02  1:56 ` Ming Lei
2019-04-03 14:04 ` Greg KH [this message]
2019-04-03 14:04   ` Greg KH
2019-04-03 16:22   ` Ming Lei
2019-04-03 16:22     ` Ming Lei
2019-04-24 16:48     ` Greg KH
2019-04-24 16:48       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190403140427.GD8633@kroah.com \
    --to=greg@kroah.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.