From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/2] nvmet: make MDTS value configurable
Date: Wed, 3 Apr 2019 16:53:16 +0200 [thread overview]
Message-ID: <20190403145316.GA25258@lst.de> (raw)
In-Reply-To: <20190401031036.GB11565@localhost.localdomain>
On Sun, Mar 31, 2019@09:10:37PM -0600, Keith Busch wrote:
> Wouldn't this indicate MDTS should be driven from hardware constraints
> rather than user tunable knobs? I don't think we should have user
> parameters if their only purpose is to test how host drivers react
> to them. It's okay if they've a functional purpose, but there are so
> many adjustable nvme parameters, this is a bit of a slippery slope if we
> want to turn the nvme target driver into a host driver test vehicle.
Agreed. In that past we've not merged patches that just include
tunables for testing purposes, and I'm inclined to keep that stance.
next prev parent reply other threads:[~2019-04-03 14:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 12:04 [PATCH 0/2] nvmet: add some more configfs attributes Hannes Reinecke
2019-03-29 12:04 ` [PATCH 1/2] nvmet: make MDTS value configurable Hannes Reinecke
2019-03-29 17:27 ` Heitke, Kenneth
2019-03-31 15:04 ` Max Gurtovoy
2019-04-01 2:02 ` Hannes Reinecke
2019-04-01 3:10 ` Keith Busch
2019-04-01 11:48 ` Hannes Reinecke
2019-04-02 12:06 ` Max Gurtovoy
2019-04-02 23:31 ` Keith Busch
2019-04-03 14:53 ` Christoph Hellwig [this message]
2019-03-29 12:04 ` [PATCH 2/2] nvmet: make CNTLID range configurable Hannes Reinecke
2019-04-03 18:11 ` Christoph Hellwig
2019-04-03 22:13 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403145316.GA25258@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.