* [Qemu-devel] [PATCH] configure: fix pam test warning
@ 2019-04-04 9:17 Dr. David Alan Gilbert (git)
2019-04-04 9:19 ` [Qemu-devel] " Daniel P. Berrangé
2019-04-04 13:55 ` [Qemu-devel] " Philippe Mathieu-Daudé
0 siblings, 2 replies; 6+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2019-04-04 9:17 UTC (permalink / raw)
To: qemu-devel, berrange
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
The pam test generates a warning on Fedora 29 with -O3 compilation
because the headers declare that the pam_conversation pointer to
pam_start must be non-NULL. Change it to use the same 0 initialised
structure as we actually use in qauthz.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
configure | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 1c563a7027..73f7ad2be0 100755
--- a/configure
+++ b/configure
@@ -2946,9 +2946,9 @@ if test "$auth_pam" != "no"; then
int main(void) {
const char *service_name = "qemu";
const char *user = "frank";
- const struct pam_conv *pam_conv = NULL;
+ const struct pam_conv pam_conv = { 0 };
pam_handle_t *pamh = NULL;
- pam_start(service_name, user, pam_conv, &pamh);
+ pam_start(service_name, user, &pam_conv, &pamh);
return 0;
}
EOF
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [PATCH] configure: fix pam test warning
2019-04-04 9:17 [Qemu-devel] [PATCH] configure: fix pam test warning Dr. David Alan Gilbert (git)
@ 2019-04-04 9:19 ` Daniel P. Berrangé
2019-04-04 13:55 ` [Qemu-devel] " Philippe Mathieu-Daudé
1 sibling, 0 replies; 6+ messages in thread
From: Daniel P. Berrangé @ 2019-04-04 9:19 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git); +Cc: qemu-devel, qemu-trivial
CC trivial
On Thu, Apr 04, 2019 at 10:17:25AM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> The pam test generates a warning on Fedora 29 with -O3 compilation
> because the headers declare that the pam_conversation pointer to
> pam_start must be non-NULL. Change it to use the same 0 initialised
> structure as we actually use in qauthz.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> configure | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Daniel P. Berrangé <berrange@redhat.com>
>
> diff --git a/configure b/configure
> index 1c563a7027..73f7ad2be0 100755
> --- a/configure
> +++ b/configure
> @@ -2946,9 +2946,9 @@ if test "$auth_pam" != "no"; then
> int main(void) {
> const char *service_name = "qemu";
> const char *user = "frank";
> - const struct pam_conv *pam_conv = NULL;
> + const struct pam_conv pam_conv = { 0 };
> pam_handle_t *pamh = NULL;
> - pam_start(service_name, user, pam_conv, &pamh);
> + pam_start(service_name, user, &pam_conv, &pamh);
> return 0;
> }
> EOF
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] configure: fix pam test warning
@ 2019-04-04 9:19 ` Daniel P. Berrangé
0 siblings, 0 replies; 6+ messages in thread
From: Daniel P. Berrangé @ 2019-04-04 9:19 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git); +Cc: qemu-devel, qemu-trivial
CC trivial
On Thu, Apr 04, 2019 at 10:17:25AM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> The pam test generates a warning on Fedora 29 with -O3 compilation
> because the headers declare that the pam_conversation pointer to
> pam_start must be non-NULL. Change it to use the same 0 initialised
> structure as we actually use in qauthz.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> configure | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Daniel P. Berrangé <berrange@redhat.com>
>
> diff --git a/configure b/configure
> index 1c563a7027..73f7ad2be0 100755
> --- a/configure
> +++ b/configure
> @@ -2946,9 +2946,9 @@ if test "$auth_pam" != "no"; then
> int main(void) {
> const char *service_name = "qemu";
> const char *user = "frank";
> - const struct pam_conv *pam_conv = NULL;
> + const struct pam_conv pam_conv = { 0 };
> pam_handle_t *pamh = NULL;
> - pam_start(service_name, user, pam_conv, &pamh);
> + pam_start(service_name, user, &pam_conv, &pamh);
> return 0;
> }
> EOF
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [PATCH] configure: fix pam test warning
2019-04-04 9:19 ` [Qemu-devel] " Daniel P. Berrangé
@ 2019-04-11 20:03 ` Laurent Vivier
-1 siblings, 0 replies; 6+ messages in thread
From: Laurent Vivier @ 2019-04-11 20:03 UTC (permalink / raw)
To: Daniel P. Berrangé, Dr. David Alan Gilbert (git)
Cc: qemu-trivial, qemu-devel
On 04/04/2019 11:19, Daniel P. Berrangé wrote:
> CC trivial
>
> On Thu, Apr 04, 2019 at 10:17:25AM +0100, Dr. David Alan Gilbert (git) wrote:
>> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>>
>> The pam test generates a warning on Fedora 29 with -O3 compilation
>> because the headers declare that the pam_conversation pointer to
>> pam_start must be non-NULL. Change it to use the same 0 initialised
>> structure as we actually use in qauthz.
>>
>> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>> ---
>> configure | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Acked-by: Daniel P. Berrangé <berrange@redhat.com>
>
>>
>> diff --git a/configure b/configure
>> index 1c563a7027..73f7ad2be0 100755
>> --- a/configure
>> +++ b/configure
>> @@ -2946,9 +2946,9 @@ if test "$auth_pam" != "no"; then
>> int main(void) {
>> const char *service_name = "qemu";
>> const char *user = "frank";
>> - const struct pam_conv *pam_conv = NULL;
>> + const struct pam_conv pam_conv = { 0 };
>> pam_handle_t *pamh = NULL;
>> - pam_start(service_name, user, pam_conv, &pamh);
>> + pam_start(service_name, user, &pam_conv, &pamh);
>> return 0;
>> }
>> EOF
>
> Regards,
> Daniel
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: fix pam test warning
@ 2019-04-11 20:03 ` Laurent Vivier
0 siblings, 0 replies; 6+ messages in thread
From: Laurent Vivier @ 2019-04-11 20:03 UTC (permalink / raw)
To: Daniel P. Berrangé, Dr. David Alan Gilbert (git)
Cc: qemu-trivial, qemu-devel
On 04/04/2019 11:19, Daniel P. Berrangé wrote:
> CC trivial
>
> On Thu, Apr 04, 2019 at 10:17:25AM +0100, Dr. David Alan Gilbert (git) wrote:
>> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>>
>> The pam test generates a warning on Fedora 29 with -O3 compilation
>> because the headers declare that the pam_conversation pointer to
>> pam_start must be non-NULL. Change it to use the same 0 initialised
>> structure as we actually use in qauthz.
>>
>> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>> ---
>> configure | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Acked-by: Daniel P. Berrangé <berrange@redhat.com>
>
>>
>> diff --git a/configure b/configure
>> index 1c563a7027..73f7ad2be0 100755
>> --- a/configure
>> +++ b/configure
>> @@ -2946,9 +2946,9 @@ if test "$auth_pam" != "no"; then
>> int main(void) {
>> const char *service_name = "qemu";
>> const char *user = "frank";
>> - const struct pam_conv *pam_conv = NULL;
>> + const struct pam_conv pam_conv = { 0 };
>> pam_handle_t *pamh = NULL;
>> - pam_start(service_name, user, pam_conv, &pamh);
>> + pam_start(service_name, user, &pam_conv, &pamh);
>> return 0;
>> }
>> EOF
>
> Regards,
> Daniel
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: fix pam test warning
2019-04-04 9:17 [Qemu-devel] [PATCH] configure: fix pam test warning Dr. David Alan Gilbert (git)
2019-04-04 9:19 ` [Qemu-devel] " Daniel P. Berrangé
@ 2019-04-04 13:55 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-04-04 13:55 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git), qemu-devel, berrange
On 4/4/19 11:17 AM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> The pam test generates a warning on Fedora 29 with -O3 compilation
> because the headers declare that the pam_conversation pointer to
> pam_start must be non-NULL. Change it to use the same 0 initialised
> structure as we actually use in qauthz.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> configure | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 1c563a7027..73f7ad2be0 100755
> --- a/configure
> +++ b/configure
> @@ -2946,9 +2946,9 @@ if test "$auth_pam" != "no"; then
> int main(void) {
> const char *service_name = "qemu";
> const char *user = "frank";
> - const struct pam_conv *pam_conv = NULL;
> + const struct pam_conv pam_conv = { 0 };
> pam_handle_t *pamh = NULL;
> - pam_start(service_name, user, pam_conv, &pamh);
> + pam_start(service_name, user, &pam_conv, &pamh);
> return 0;
> }
> EOF
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-11 20:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-04 9:17 [Qemu-devel] [PATCH] configure: fix pam test warning Dr. David Alan Gilbert (git)
2019-04-04 9:19 ` [Qemu-trivial] " Daniel P. Berrangé
2019-04-04 9:19 ` [Qemu-devel] " Daniel P. Berrangé
2019-04-11 20:03 ` [Qemu-trivial] " Laurent Vivier
2019-04-11 20:03 ` [Qemu-devel] " Laurent Vivier
2019-04-04 13:55 ` [Qemu-devel] " Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.