From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Amitkumar Karwar <amitkarwar@gmail.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Ganapathi Bhat <gbhat@marvell.com>,
Xinming Hu <huxinming820@gmail.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mwifiex: add a bounds check in mwifiex_process_sta_rx_packet()
Date: Thu, 04 Apr 2019 10:21:09 +0000 [thread overview]
Message-ID: <20190404102109.EBBCE61948@smtp.codeaurora.org> (raw)
In-Reply-To: <20190402070338.GB15171@kadam>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Smatch complains that "local_rx_pd->priority" can't be trusted because
> it comes from skb->data and it can go up to 255 instead of being capped
> in the 0-7 range. A few lines earlier, on the other side of the if
> statement, we cap priority so it seems harmless to add a bounds check
> here as well.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
Patch applied to wireless-drivers-next.git, thanks.
2cd2b42439ea mwifiex: add a bounds check in mwifiex_process_sta_rx_packet()
--
https://patchwork.kernel.org/patch/10881135/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Amitkumar Karwar <amitkarwar@gmail.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Ganapathi Bhat <gbhat@marvell.com>,
Xinming Hu <huxinming820@gmail.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mwifiex: add a bounds check in mwifiex_process_sta_rx_packet()
Date: Thu, 4 Apr 2019 10:21:09 +0000 (UTC) [thread overview]
Message-ID: <20190404102109.EBBCE61948@smtp.codeaurora.org> (raw)
In-Reply-To: <20190402070338.GB15171@kadam>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Smatch complains that "local_rx_pd->priority" can't be trusted because
> it comes from skb->data and it can go up to 255 instead of being capped
> in the 0-7 range. A few lines earlier, on the other side of the if
> statement, we cap priority so it seems harmless to add a bounds check
> here as well.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
Patch applied to wireless-drivers-next.git, thanks.
2cd2b42439ea mwifiex: add a bounds check in mwifiex_process_sta_rx_packet()
--
https://patchwork.kernel.org/patch/10881135/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-04-04 10:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 7:03 [PATCH] mwifiex: add a bounds check in mwifiex_process_sta_rx_packet() Dan Carpenter
2019-04-02 7:03 ` Dan Carpenter
2019-04-03 20:05 ` Brian Norris
2019-04-03 20:05 ` Brian Norris
2019-04-04 10:21 ` Kalle Valo [this message]
2019-04-04 10:21 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404102109.EBBCE61948@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gbhat@marvell.com \
--cc=huxinming820@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.