From: Bin Liu <b-liu@ti.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Samuel Holland <samuel@sholland.org>,
Chen-Yu Tsai <wens@csie.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-sunxi@googlegroups.com, stable@vger.kernel.org
Subject: [v2] soc: sunxi: Fix missing dependency on REGMAP_MMIO
Date: Thu, 4 Apr 2019 10:34:59 -0500 [thread overview]
Message-ID: <20190404153459.GT25852@uda0271908> (raw)
On Tue, Apr 02, 2019 at 08:09:01AM +0200, Maxime Ripard wrote:
> On Mon, Apr 01, 2019 at 05:03:31PM -0500, Samuel Holland wrote:
> > When enabling ARCH_SUNXI from allnoconfig, SUNXI_SRAM is enabled, but
> > not REGMAP_MMIO, so the kernel fails to link with an undefined reference
> > to __devm_regmap_init_mmio_clk. Select REGMAP_MMIO, as suggested in
> > drivers/base/regmap/Kconfig.
> >
> > This creates the following dependency loop:
> >
> > drivers/of/Kconfig:68: symbol OF_IRQ depends on IRQ_DOMAIN
> > kernel/irq/Kconfig:63: symbol IRQ_DOMAIN is selected by REGMAP
> > drivers/base/regmap/Kconfig:7: symbol REGMAP default is visible depending on REGMAP_MMIO
> > drivers/base/regmap/Kconfig:39: symbol REGMAP_MMIO is selected by SUNXI_SRAM
> > drivers/soc/sunxi/Kconfig:4: symbol SUNXI_SRAM is selected by USB_MUSB_SUNXI
> > drivers/usb/musb/Kconfig:63: symbol USB_MUSB_SUNXI depends on GENERIC_PHY
> > drivers/phy/Kconfig:7: symbol GENERIC_PHY is selected by PHY_BCM_NS_USB3
> > drivers/phy/broadcom/Kconfig:29: symbol PHY_BCM_NS_USB3 depends on MDIO_BUS
> > drivers/net/phy/Kconfig:12: symbol MDIO_BUS default is visible depending on PHYLIB
> > drivers/net/phy/Kconfig:181: symbol PHYLIB is selected by ARC_EMAC_CORE
> > drivers/net/ethernet/arc/Kconfig:18: symbol ARC_EMAC_CORE is selected by ARC_EMAC
> > drivers/net/ethernet/arc/Kconfig:24: symbol ARC_EMAC depends on OF_IRQ
> >
> > To fix the circular dependency, make USB_MUSB_SUNXI select GENERIC_PHY
> > instead of depending on it. This matches the use of GENERIC_PHY by all
> > but two other drivers.
> >
> > Cc: <stable@vger.kernel.org> # 4.19
> > Fixes: 5828729bebbb ("soc: sunxi: export a regmap for EMAC clock reg on A64")
> > Signed-off-by: Samuel Holland <samuel@sholland.org>
>
> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
The patch is applied.
Thanks,
-Bin.
WARNING: multiple messages have this Message-ID (diff)
From: Bin Liu <b-liu@ti.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Samuel Holland <samuel@sholland.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-sunxi@googlegroups.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Chen-Yu Tsai <wens@csie.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] soc: sunxi: Fix missing dependency on REGMAP_MMIO
Date: Thu, 4 Apr 2019 10:34:59 -0500 [thread overview]
Message-ID: <20190404153459.GT25852@uda0271908> (raw)
In-Reply-To: <20190402060901.rowpoenurzbolyby@flea>
On Tue, Apr 02, 2019 at 08:09:01AM +0200, Maxime Ripard wrote:
> On Mon, Apr 01, 2019 at 05:03:31PM -0500, Samuel Holland wrote:
> > When enabling ARCH_SUNXI from allnoconfig, SUNXI_SRAM is enabled, but
> > not REGMAP_MMIO, so the kernel fails to link with an undefined reference
> > to __devm_regmap_init_mmio_clk. Select REGMAP_MMIO, as suggested in
> > drivers/base/regmap/Kconfig.
> >
> > This creates the following dependency loop:
> >
> > drivers/of/Kconfig:68: symbol OF_IRQ depends on IRQ_DOMAIN
> > kernel/irq/Kconfig:63: symbol IRQ_DOMAIN is selected by REGMAP
> > drivers/base/regmap/Kconfig:7: symbol REGMAP default is visible depending on REGMAP_MMIO
> > drivers/base/regmap/Kconfig:39: symbol REGMAP_MMIO is selected by SUNXI_SRAM
> > drivers/soc/sunxi/Kconfig:4: symbol SUNXI_SRAM is selected by USB_MUSB_SUNXI
> > drivers/usb/musb/Kconfig:63: symbol USB_MUSB_SUNXI depends on GENERIC_PHY
> > drivers/phy/Kconfig:7: symbol GENERIC_PHY is selected by PHY_BCM_NS_USB3
> > drivers/phy/broadcom/Kconfig:29: symbol PHY_BCM_NS_USB3 depends on MDIO_BUS
> > drivers/net/phy/Kconfig:12: symbol MDIO_BUS default is visible depending on PHYLIB
> > drivers/net/phy/Kconfig:181: symbol PHYLIB is selected by ARC_EMAC_CORE
> > drivers/net/ethernet/arc/Kconfig:18: symbol ARC_EMAC_CORE is selected by ARC_EMAC
> > drivers/net/ethernet/arc/Kconfig:24: symbol ARC_EMAC depends on OF_IRQ
> >
> > To fix the circular dependency, make USB_MUSB_SUNXI select GENERIC_PHY
> > instead of depending on it. This matches the use of GENERIC_PHY by all
> > but two other drivers.
> >
> > Cc: <stable@vger.kernel.org> # 4.19
> > Fixes: 5828729bebbb ("soc: sunxi: export a regmap for EMAC clock reg on A64")
> > Signed-off-by: Samuel Holland <samuel@sholland.org>
>
> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
The patch is applied.
Thanks,
-Bin.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Bin Liu <b-liu@ti.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Samuel Holland <samuel@sholland.org>,
Chen-Yu Tsai <wens@csie.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<linux-sunxi@googlegroups.com>, <stable@vger.kernel.org>
Subject: Re: [PATCH v2] soc: sunxi: Fix missing dependency on REGMAP_MMIO
Date: Thu, 4 Apr 2019 10:34:59 -0500 [thread overview]
Message-ID: <20190404153459.GT25852@uda0271908> (raw)
In-Reply-To: <20190402060901.rowpoenurzbolyby@flea>
On Tue, Apr 02, 2019 at 08:09:01AM +0200, Maxime Ripard wrote:
> On Mon, Apr 01, 2019 at 05:03:31PM -0500, Samuel Holland wrote:
> > When enabling ARCH_SUNXI from allnoconfig, SUNXI_SRAM is enabled, but
> > not REGMAP_MMIO, so the kernel fails to link with an undefined reference
> > to __devm_regmap_init_mmio_clk. Select REGMAP_MMIO, as suggested in
> > drivers/base/regmap/Kconfig.
> >
> > This creates the following dependency loop:
> >
> > drivers/of/Kconfig:68: symbol OF_IRQ depends on IRQ_DOMAIN
> > kernel/irq/Kconfig:63: symbol IRQ_DOMAIN is selected by REGMAP
> > drivers/base/regmap/Kconfig:7: symbol REGMAP default is visible depending on REGMAP_MMIO
> > drivers/base/regmap/Kconfig:39: symbol REGMAP_MMIO is selected by SUNXI_SRAM
> > drivers/soc/sunxi/Kconfig:4: symbol SUNXI_SRAM is selected by USB_MUSB_SUNXI
> > drivers/usb/musb/Kconfig:63: symbol USB_MUSB_SUNXI depends on GENERIC_PHY
> > drivers/phy/Kconfig:7: symbol GENERIC_PHY is selected by PHY_BCM_NS_USB3
> > drivers/phy/broadcom/Kconfig:29: symbol PHY_BCM_NS_USB3 depends on MDIO_BUS
> > drivers/net/phy/Kconfig:12: symbol MDIO_BUS default is visible depending on PHYLIB
> > drivers/net/phy/Kconfig:181: symbol PHYLIB is selected by ARC_EMAC_CORE
> > drivers/net/ethernet/arc/Kconfig:18: symbol ARC_EMAC_CORE is selected by ARC_EMAC
> > drivers/net/ethernet/arc/Kconfig:24: symbol ARC_EMAC depends on OF_IRQ
> >
> > To fix the circular dependency, make USB_MUSB_SUNXI select GENERIC_PHY
> > instead of depending on it. This matches the use of GENERIC_PHY by all
> > but two other drivers.
> >
> > Cc: <stable@vger.kernel.org> # 4.19
> > Fixes: 5828729bebbb ("soc: sunxi: export a regmap for EMAC clock reg on A64")
> > Signed-off-by: Samuel Holland <samuel@sholland.org>
>
> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
The patch is applied.
Thanks,
-Bin.
next reply other threads:[~2019-04-04 15:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 15:34 Bin Liu [this message]
2019-04-04 15:34 ` [PATCH v2] soc: sunxi: Fix missing dependency on REGMAP_MMIO Bin Liu
2019-04-04 15:34 ` Bin Liu
-- strict thread matches above, loose matches on Subject: below --
2019-04-02 6:09 [v2] " Maxime Ripard
2019-04-02 6:09 ` [PATCH v2] " Maxime Ripard
2019-04-02 6:09 ` Maxime Ripard
2019-04-01 22:03 [v2] " Samuel Holland
2019-04-01 22:03 ` [PATCH v2] " Samuel Holland
2019-04-01 22:03 ` Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404153459.GT25852@uda0271908 \
--to=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux-usb@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=samuel@sholland.org \
--cc=stable@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.