From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Timur Tabi <timur@freescale.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Mihai Caraman <mihai.caraman@freescale.com>,
Kumar Gala <galak@kernel.crashing.org>
Subject: Re: [PATCH 1/2] fsl_hypervisor: dereferencing error pointers in ioctl
Date: Thu, 04 Apr 2019 19:14:20 +0000 [thread overview]
Message-ID: <20190404191420.GQ32613@kadam> (raw)
In-Reply-To: <20190404121044.a38ba5895a485abcdc57f297@linux-foundation.org>
On Thu, Apr 04, 2019 at 12:10:44PM -0700, Andrew Morton wrote:
> On Tue, 18 Dec 2018 11:20:03 +0300 Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> > The strndup_user() function returns error pointers on error, and then
> > in the error handling we pass the error pointers to kfree(). It will
> > cause an Oops.
> >
>
> Looks good to me.
>
> I guess we should fix this too?
>
I didn't notice that. Thanks!
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Timur Tabi <timur@freescale.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Mihai Caraman <mihai.caraman@freescale.com>,
Kumar Gala <galak@kernel.crashing.org>
Subject: Re: [PATCH 1/2] fsl_hypervisor: dereferencing error pointers in ioctl
Date: Thu, 4 Apr 2019 22:14:20 +0300 [thread overview]
Message-ID: <20190404191420.GQ32613@kadam> (raw)
In-Reply-To: <20190404121044.a38ba5895a485abcdc57f297@linux-foundation.org>
On Thu, Apr 04, 2019 at 12:10:44PM -0700, Andrew Morton wrote:
> On Tue, 18 Dec 2018 11:20:03 +0300 Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> > The strndup_user() function returns error pointers on error, and then
> > in the error handling we pass the error pointers to kfree(). It will
> > cause an Oops.
> >
>
> Looks good to me.
>
> I guess we should fix this too?
>
I didn't notice that. Thanks!
regards,
dan carpenter
next prev parent reply other threads:[~2019-04-04 19:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 8:20 [PATCH 1/2] fsl_hypervisor: dereferencing error pointers in ioctl Dan Carpenter
2018-12-18 8:20 ` Dan Carpenter
2018-12-18 8:21 ` [PATCH 2/2] fsl_hypervisor: prevent integer overflow " Dan Carpenter
2018-12-18 8:21 ` Dan Carpenter
2019-04-04 10:13 ` [PATCH 1/2] fsl_hypervisor: dereferencing error pointers " Dan Carpenter
2019-04-04 10:13 ` Dan Carpenter
2019-04-04 19:10 ` Andrew Morton
2019-04-04 19:10 ` Andrew Morton
2019-04-04 19:14 ` Dan Carpenter [this message]
2019-04-04 19:14 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404191420.GQ32613@kadam \
--to=dan.carpenter@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=galak@kernel.crashing.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.caraman@freescale.com \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.