* [PATCH] ALSA: hda - Add two more machines to the power_save_blacklist
@ 2019-04-08 1:35 Hui Wang
2019-04-08 7:23 ` [alsa-devel] " Jaroslav Kysela
2019-04-08 19:29 ` Sasha Levin
0 siblings, 2 replies; 6+ messages in thread
From: Hui Wang @ 2019-04-08 1:35 UTC (permalink / raw)
To: alsa-devel, tiwai; +Cc: stable
Recently we set CONFIG_SND_HDA_POWER_SAVE_DEFAULT to 1 when
configuring the kernel, then two machines were reported to have noise
after installing the new kernel. Put them in the blacklist, the
noise disappears.
https://bugs.launchpad.net/bugs/1821663
Cc: <stable@vger.kernel.org>
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
sound/pci/hda/hda_intel.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index ece256a3b48f..f62fb8b16c49 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2150,6 +2150,9 @@ static struct snd_pci_quirk power_save_blacklist[] = {
SND_PCI_QUIRK(0x17aa, 0x367b, "Lenovo IdeaCentre B550", 0),
/* https://bugzilla.redhat.com/show_bug.cgi?id=1572975 */
SND_PCI_QUIRK(0x17aa, 0x36a7, "Lenovo C50 All in one", 0),
+ /* https://bugs.launchpad.net/bugs/1821663 */
+ SND_PCI_QUIRK(0x1631, 0xe017, "Packard Bell NEC IMEDIA 5204", 0),
+ SND_PCI_QUIRK(0x8086, 0x2064, "Intel Laptop 8086:2064", 0),
{}
};
#endif /* CONFIG_PM */
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [alsa-devel] [PATCH] ALSA: hda - Add two more machines to the power_save_blacklist
2019-04-08 1:35 [PATCH] ALSA: hda - Add two more machines to the power_save_blacklist Hui Wang
@ 2019-04-08 7:23 ` Jaroslav Kysela
2019-04-08 7:29 ` Hui Wang
2019-04-08 19:29 ` Sasha Levin
1 sibling, 1 reply; 6+ messages in thread
From: Jaroslav Kysela @ 2019-04-08 7:23 UTC (permalink / raw)
To: Hui Wang, alsa-devel, tiwai; +Cc: stable
Dne 08. 04. 19 v 3:35 Hui Wang napsal(a):
> Recently we set CONFIG_SND_HDA_POWER_SAVE_DEFAULT to 1 when
> configuring the kernel, then two machines were reported to have noise
> after installing the new kernel. Put them in the blacklist, the
> noise disappears.
Please, place the new entries sorted using the PCI IDs...
Jaroslav Kysela
>
> https://bugs.launchpad.net/bugs/1821663
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> ---
> sound/pci/hda/hda_intel.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index ece256a3b48f..f62fb8b16c49 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -2150,6 +2150,9 @@ static struct snd_pci_quirk power_save_blacklist[] = {
> SND_PCI_QUIRK(0x17aa, 0x367b, "Lenovo IdeaCentre B550", 0),
> /* https://bugzilla.redhat.com/show_bug.cgi?id=1572975 */
> SND_PCI_QUIRK(0x17aa, 0x36a7, "Lenovo C50 All in one", 0),
> + /* https://bugs.launchpad.net/bugs/1821663 */
> + SND_PCI_QUIRK(0x1631, 0xe017, "Packard Bell NEC IMEDIA 5204", 0),
> + SND_PCI_QUIRK(0x8086, 0x2064, "Intel Laptop 8086:2064", 0),
> {}
> };
> #endif /* CONFIG_PM */
>
--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [alsa-devel] [PATCH] ALSA: hda - Add two more machines to the power_save_blacklist
2019-04-08 7:23 ` [alsa-devel] " Jaroslav Kysela
@ 2019-04-08 7:29 ` Hui Wang
0 siblings, 0 replies; 6+ messages in thread
From: Hui Wang @ 2019-04-08 7:29 UTC (permalink / raw)
To: Jaroslav Kysela, alsa-devel, tiwai; +Cc: stable
On 2019/4/8 下午3:23, Jaroslav Kysela wrote:
> Dne 08. 04. 19 v 3:35 Hui Wang napsal(a):
>> Recently we set CONFIG_SND_HDA_POWER_SAVE_DEFAULT to 1 when
>> configuring the kernel, then two machines were reported to have noise
>> after installing the new kernel. Put them in the blacklist, the
>> noise disappears.
> Please, place the new entries sorted using the PCI IDs...
>
> Jaroslav Kysela
Got it, will fix it in the V2.
Thanks,
Hui.
>> https://bugs.launchpad.net/bugs/1821663
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Hui Wang <hui.wang@canonical.com>
>> ---
>> sound/pci/hda/hda_intel.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
>> index ece256a3b48f..f62fb8b16c49 100644
>> --- a/sound/pci/hda/hda_intel.c
>> +++ b/sound/pci/hda/hda_intel.c
>> @@ -2150,6 +2150,9 @@ static struct snd_pci_quirk power_save_blacklist[] = {
>> SND_PCI_QUIRK(0x17aa, 0x367b, "Lenovo IdeaCentre B550", 0),
>> /* https://bugzilla.redhat.com/show_bug.cgi?id=1572975 */
>> SND_PCI_QUIRK(0x17aa, 0x36a7, "Lenovo C50 All in one", 0),
>> + /* https://bugs.launchpad.net/bugs/1821663 */
>> + SND_PCI_QUIRK(0x1631, 0xe017, "Packard Bell NEC IMEDIA 5204", 0),
>> + SND_PCI_QUIRK(0x8086, 0x2064, "Intel Laptop 8086:2064", 0),
>> {}
>> };
>> #endif /* CONFIG_PM */
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ALSA: hda - Add two more machines to the power_save_blacklist
2019-04-08 1:35 [PATCH] ALSA: hda - Add two more machines to the power_save_blacklist Hui Wang
@ 2019-04-08 19:29 ` Sasha Levin
2019-04-08 19:29 ` Sasha Levin
1 sibling, 0 replies; 6+ messages in thread
From: Sasha Levin @ 2019-04-08 19:29 UTC (permalink / raw)
To: Sasha Levin, Hui Wang, alsa-devel, tiwai; +Cc: stable
Hi,
[This is an automated email]
This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all
The bot has tested the following trees: v5.0.7, v4.19.34, v4.14.111, v4.9.168, v4.4.178, v3.18.138.
v5.0.7: Build OK!
v4.19.34: Build OK!
v4.14.111: Failed to apply! Possible dependencies:
721f1e6c1fd1 ("ALSA: hda - add Lenovo IdeaCentre B550 to the power_save_blacklist")
dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
v4.9.168: Failed to apply! Possible dependencies:
721f1e6c1fd1 ("ALSA: hda - add Lenovo IdeaCentre B550 to the power_save_blacklist")
dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
v4.4.178: Failed to apply! Possible dependencies:
721f1e6c1fd1 ("ALSA: hda - add Lenovo IdeaCentre B550 to the power_save_blacklist")
dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
v3.18.138: Failed to apply! Possible dependencies:
1ba8f9d30817 ("ALSA: hda: Add a power_save blacklist")
59ed1eade1d6 ("ALSA: hda - Move codec suspend/resume to codec driver")
66797f36fd17 ("ALSA: hda - Pass printf argument directly to request_module()")
721f1e6c1fd1 ("ALSA: hda - add Lenovo IdeaCentre B550 to the power_save_blacklist")
95a962c36f6e ("ALSA: hda - More kerneldoc comments")
a41d122449be ("ALSA: hda - Embed bus into controller object")
b2a0bafa7582 ("ALSA: hda - Use shutdown driver ops instead of reboot notifier")
d068ebc25e6e ("ALSA: hda - Move some codes up to hdac_bus struct")
d8a766a16ed9 ("ALSA: hda - Bind codecs via standard bus")
dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
dda42bd0c3a4 ("ALSA: hda - Add kerneldoc comments to hda_generic.c")
e3d280fc6d42 ("ALSA: hda - Make snd_hda_bus_type public")
How should we proceed with this patch?
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ALSA: hda - Add two more machines to the power_save_blacklist
@ 2019-04-08 19:29 ` Sasha Levin
0 siblings, 0 replies; 6+ messages in thread
From: Sasha Levin @ 2019-04-08 19:29 UTC (permalink / raw)
To: Sasha Levin, Hui Wang, alsa-devel, tiwai; +Cc: stable, stable, stable
Hi,
[This is an automated email]
This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all
The bot has tested the following trees: v5.0.7, v4.19.34, v4.14.111, v4.9.168, v4.4.178, v3.18.138.
v5.0.7: Build OK!
v4.19.34: Build OK!
v4.14.111: Failed to apply! Possible dependencies:
721f1e6c1fd1 ("ALSA: hda - add Lenovo IdeaCentre B550 to the power_save_blacklist")
dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
v4.9.168: Failed to apply! Possible dependencies:
721f1e6c1fd1 ("ALSA: hda - add Lenovo IdeaCentre B550 to the power_save_blacklist")
dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
v4.4.178: Failed to apply! Possible dependencies:
721f1e6c1fd1 ("ALSA: hda - add Lenovo IdeaCentre B550 to the power_save_blacklist")
dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
v3.18.138: Failed to apply! Possible dependencies:
1ba8f9d30817 ("ALSA: hda: Add a power_save blacklist")
59ed1eade1d6 ("ALSA: hda - Move codec suspend/resume to codec driver")
66797f36fd17 ("ALSA: hda - Pass printf argument directly to request_module()")
721f1e6c1fd1 ("ALSA: hda - add Lenovo IdeaCentre B550 to the power_save_blacklist")
95a962c36f6e ("ALSA: hda - More kerneldoc comments")
a41d122449be ("ALSA: hda - Embed bus into controller object")
b2a0bafa7582 ("ALSA: hda - Use shutdown driver ops instead of reboot notifier")
d068ebc25e6e ("ALSA: hda - Move some codes up to hdac_bus struct")
d8a766a16ed9 ("ALSA: hda - Bind codecs via standard bus")
dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
dda42bd0c3a4 ("ALSA: hda - Add kerneldoc comments to hda_generic.c")
e3d280fc6d42 ("ALSA: hda - Make snd_hda_bus_type public")
How should we proceed with this patch?
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ALSA: hda - Add two more machines to the power_save_blacklist
2019-04-08 19:29 ` Sasha Levin
(?)
@ 2019-04-09 3:12 ` hwang4
-1 siblings, 0 replies; 6+ messages in thread
From: hwang4 @ 2019-04-09 3:12 UTC (permalink / raw)
To: Sasha Levin, alsa-devel, tiwai; +Cc: stable
In my opinion, let us drop this patch for v3.18.138, and for v4.4, v4.9
and v4.14, let us cherry-pick those two dependencies first, then apply
this patch. If there are two many conflicts, it is fine to drop this
patch since this is not a very critical fix.
Thanks,
Hui.
On 2019/4/9 上午3:29, Sasha Levin wrote:
> Hi,
>
> [This is an automated email]
>
> This commit has been processed because it contains a -stable tag.
> The stable tag indicates that it's relevant for the following trees: all
>
> The bot has tested the following trees: v5.0.7, v4.19.34, v4.14.111, v4.9.168, v4.4.178, v3.18.138.
>
> v5.0.7: Build OK!
> v4.19.34: Build OK!
> v4.14.111: Failed to apply! Possible dependencies:
> 721f1e6c1fd1 ("ALSA: hda - add Lenovo IdeaCentre B550 to the power_save_blacklist")
> dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
>
> v4.9.168: Failed to apply! Possible dependencies:
> 721f1e6c1fd1 ("ALSA: hda - add Lenovo IdeaCentre B550 to the power_save_blacklist")
> dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
>
> v4.4.178: Failed to apply! Possible dependencies:
> 721f1e6c1fd1 ("ALSA: hda - add Lenovo IdeaCentre B550 to the power_save_blacklist")
> dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
>
> v3.18.138: Failed to apply! Possible dependencies:
> 1ba8f9d30817 ("ALSA: hda: Add a power_save blacklist")
> 59ed1eade1d6 ("ALSA: hda - Move codec suspend/resume to codec driver")
> 66797f36fd17 ("ALSA: hda - Pass printf argument directly to request_module()")
> 721f1e6c1fd1 ("ALSA: hda - add Lenovo IdeaCentre B550 to the power_save_blacklist")
> 95a962c36f6e ("ALSA: hda - More kerneldoc comments")
> a41d122449be ("ALSA: hda - Embed bus into controller object")
> b2a0bafa7582 ("ALSA: hda - Use shutdown driver ops instead of reboot notifier")
> d068ebc25e6e ("ALSA: hda - Move some codes up to hdac_bus struct")
> d8a766a16ed9 ("ALSA: hda - Bind codecs via standard bus")
> dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
> dda42bd0c3a4 ("ALSA: hda - Add kerneldoc comments to hda_generic.c")
> e3d280fc6d42 ("ALSA: hda - Make snd_hda_bus_type public")
>
>
> How should we proceed with this patch?
>
> --
> Thanks,
> Sasha
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-09 3:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-08 1:35 [PATCH] ALSA: hda - Add two more machines to the power_save_blacklist Hui Wang
2019-04-08 7:23 ` [alsa-devel] " Jaroslav Kysela
2019-04-08 7:29 ` Hui Wang
2019-04-08 19:29 ` Sasha Levin
2019-04-08 19:29 ` Sasha Levin
2019-04-09 3:12 ` hwang4
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.