From: guro at fb.com (Roman Gushchin)
Subject: [PATCH kselftest-next] selftests: cgroup: fix cleanup path in test_memcg_subtree_control()
Date: Mon, 8 Apr 2019 21:46:33 +0000 [thread overview]
Message-ID: <20190408214628.GA14748@castle> (raw)
In-Reply-To: <32b7ae48-99dd-1261-4086-37d416ffcfd5@kernel.org>
On Mon, Apr 08, 2019 at 12:53:39PM -0600, shuah wrote:
> On 3/27/19 8:56 PM, Roman Gushchin wrote:
> > Dan reported, that cleanup path in test_memcg_subtree_control()
> > triggers a static checker warning:
> > ./tools/testing/selftests/cgroup/test_memcontrol.c:76 \
> > test_memcg_subtree_control()
> > error: uninitialized symbol 'child2'.
> >
> > Fix this by initializing child2 and parent2 variables and
> > split the cleanup path into few stages.
> >
> > Signed-off-by: Roman Gushchin <guro at fb.com>
> > Fixes: 84092dbcf901 ("selftests: cgroup: add memory controller self-tests")
> > Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
> > Cc: Dan Carpenter <dan.carpenter at oracle.com>
> > Cc: Shuah Khan (Samsung OSG) <shuah at kernel.org>
> > Cc: Mike Rapoport <rppt at linux.vnet.ibm.com>
>
>
> From and Signed-off don't match. Please fix it and resend the patch.
Done.
Thank you!
Roman
WARNING: multiple messages have this Message-ID (diff)
From: guro@fb.com (Roman Gushchin)
Subject: [PATCH kselftest-next] selftests: cgroup: fix cleanup path in test_memcg_subtree_control()
Date: Mon, 8 Apr 2019 21:46:33 +0000 [thread overview]
Message-ID: <20190408214628.GA14748@castle> (raw)
Message-ID: <20190408214633.hj_htg_uuJ4UNTTTnsjiDYC6jJEzpoWXk_Q1EkhnVQ0@z> (raw)
In-Reply-To: <32b7ae48-99dd-1261-4086-37d416ffcfd5@kernel.org>
On Mon, Apr 08, 2019@12:53:39PM -0600, shuah wrote:
> On 3/27/19 8:56 PM, Roman Gushchin wrote:
> > Dan reported, that cleanup path in test_memcg_subtree_control()
> > triggers a static checker warning:
> > ./tools/testing/selftests/cgroup/test_memcontrol.c:76 \
> > test_memcg_subtree_control()
> > error: uninitialized symbol 'child2'.
> >
> > Fix this by initializing child2 and parent2 variables and
> > split the cleanup path into few stages.
> >
> > Signed-off-by: Roman Gushchin <guro at fb.com>
> > Fixes: 84092dbcf901 ("selftests: cgroup: add memory controller self-tests")
> > Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
> > Cc: Dan Carpenter <dan.carpenter at oracle.com>
> > Cc: Shuah Khan (Samsung OSG) <shuah at kernel.org>
> > Cc: Mike Rapoport <rppt at linux.vnet.ibm.com>
>
>
> From and Signed-off don't match. Please fix it and resend the patch.
Done.
Thank you!
Roman
WARNING: multiple messages have this Message-ID (diff)
From: Roman Gushchin <guro@fb.com>
To: shuah <shuah@kernel.org>
Cc: Roman Gushchin <guroan@gmail.com>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>
Subject: Re: [PATCH kselftest-next] selftests: cgroup: fix cleanup path in test_memcg_subtree_control()
Date: Mon, 8 Apr 2019 21:46:33 +0000 [thread overview]
Message-ID: <20190408214628.GA14748@castle> (raw)
In-Reply-To: <32b7ae48-99dd-1261-4086-37d416ffcfd5@kernel.org>
On Mon, Apr 08, 2019 at 12:53:39PM -0600, shuah wrote:
> On 3/27/19 8:56 PM, Roman Gushchin wrote:
> > Dan reported, that cleanup path in test_memcg_subtree_control()
> > triggers a static checker warning:
> > ./tools/testing/selftests/cgroup/test_memcontrol.c:76 \
> > test_memcg_subtree_control()
> > error: uninitialized symbol 'child2'.
> >
> > Fix this by initializing child2 and parent2 variables and
> > split the cleanup path into few stages.
> >
> > Signed-off-by: Roman Gushchin <guro@fb.com>
> > Fixes: 84092dbcf901 ("selftests: cgroup: add memory controller self-tests")
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Cc: Dan Carpenter <dan.carpenter@oracle.com>
> > Cc: Shuah Khan (Samsung OSG) <shuah@kernel.org>
> > Cc: Mike Rapoport <rppt@linux.vnet.ibm.com>
>
>
> From and Signed-off don't match. Please fix it and resend the patch.
Done.
Thank you!
Roman
next prev parent reply other threads:[~2019-04-08 21:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 2:56 [PATCH kselftest-next] selftests: cgroup: fix cleanup path in test_memcg_subtree_control() guroan
2019-03-28 2:56 ` Roman Gushchin
2019-03-28 2:56 ` Roman Gushchin
2019-04-08 18:53 ` shuah
2019-04-08 18:53 ` shuah
2019-04-08 18:53 ` shuah
2019-04-08 21:46 ` guro [this message]
2019-04-08 21:46 ` Roman Gushchin
2019-04-08 21:46 ` Roman Gushchin
-- strict thread matches above, loose matches on Subject: below --
2019-04-08 22:12 guro
2019-04-08 22:12 ` Roman Gushchin
2019-04-08 22:12 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408214628.GA14748@castle \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.