All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: lvivier@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
	John Snow <jsnow@redhat.com>,
	qemu-block@nongnu.org, armbru@redhat.com,
	Thomas Huth <thuth@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	eblake@redhat.com, Hannes Reinecke <hare@suse.com>
Subject: [Qemu-devel] [PATCH for-4.1 0/5] First batch of global_qtest-removement patches for QEMU 4.1
Date: Tue,  9 Apr 2019 10:52:40 +0200	[thread overview]
Message-ID: <20190409085245.31548-1-thuth@redhat.com> (raw)

While global_qtest and its wrapper functions work fine for tests that only
run one instance of QEMU, using the global_qtest variable in our qtests is
very problematic for tests that use multiple test states (e.g. migration
tests). Thus tests that still use global_qtest make it hard to share code
(either by copy-n-pasting or by calling common functions) with tests that
try to track multiple test states, so we should try to completely get rid
of the global_qtest variable and its wrapper function in the long run.

Here's another set of patches that cleans up the usage of global_qtest
in a couple of tests.

Thomas Huth (5):
  tests/tco: Make test independent of global_qtest
  tests/megasas: Make test independent of global_qtest
  tests/qmp-cmd-test: Use qtest_init() instead of qtest_start()
  tests/test-hmp: Use qtest_init() instead of qtest_start()
  tests/ide-test: Make test independent of global_qtest

 tests/ide-test.c     | 284 ++++++++++++++++++++++++-------------------
 tests/megasas-test.c |   2 +-
 tests/qmp-cmd-test.c |  15 ++-
 tests/tco-test.c     |  63 +++++-----
 tests/test-hmp.c     |  19 +--
 5 files changed, 211 insertions(+), 172 deletions(-)

-- 
2.21.0

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: lvivier@redhat.com, Thomas Huth <thuth@redhat.com>,
	qemu-block@nongnu.org, armbru@redhat.com,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Hannes Reinecke <hare@suse.com>,
	Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH for-4.1 0/5] First batch of global_qtest-removement patches for QEMU 4.1
Date: Tue,  9 Apr 2019 10:52:40 +0200	[thread overview]
Message-ID: <20190409085245.31548-1-thuth@redhat.com> (raw)
Message-ID: <20190409085240.V_83FlRgLpUO5rtCVy6yUigqVN9t8tYCizkD0UdNKCA@z> (raw)

While global_qtest and its wrapper functions work fine for tests that only
run one instance of QEMU, using the global_qtest variable in our qtests is
very problematic for tests that use multiple test states (e.g. migration
tests). Thus tests that still use global_qtest make it hard to share code
(either by copy-n-pasting or by calling common functions) with tests that
try to track multiple test states, so we should try to completely get rid
of the global_qtest variable and its wrapper function in the long run.

Here's another set of patches that cleans up the usage of global_qtest
in a couple of tests.

Thomas Huth (5):
  tests/tco: Make test independent of global_qtest
  tests/megasas: Make test independent of global_qtest
  tests/qmp-cmd-test: Use qtest_init() instead of qtest_start()
  tests/test-hmp: Use qtest_init() instead of qtest_start()
  tests/ide-test: Make test independent of global_qtest

 tests/ide-test.c     | 284 ++++++++++++++++++++++++-------------------
 tests/megasas-test.c |   2 +-
 tests/qmp-cmd-test.c |  15 ++-
 tests/tco-test.c     |  63 +++++-----
 tests/test-hmp.c     |  19 +--
 5 files changed, 211 insertions(+), 172 deletions(-)

-- 
2.21.0



             reply	other threads:[~2019-04-09  8:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09  8:52 Thomas Huth [this message]
2019-04-09  8:52 ` [Qemu-devel] [PATCH for-4.1 0/5] First batch of global_qtest-removement patches for QEMU 4.1 Thomas Huth
2019-04-09  8:52 ` [Qemu-devel] [PATCH for-4.1 1/5] tests/tco: Make test independent of global_qtest Thomas Huth
2019-04-09  8:52   ` Thomas Huth
2019-04-09  8:52 ` [Qemu-devel] [PATCH for-4.1 2/5] tests/megasas: " Thomas Huth
2019-04-09  8:52   ` Thomas Huth
2019-04-09  8:52 ` [Qemu-devel] [PATCH for-4.1 3/5] tests/qmp-cmd-test: Use qtest_init() instead of qtest_start() Thomas Huth
2019-04-09  8:52   ` Thomas Huth
2019-04-09  8:52 ` [Qemu-devel] [PATCH for-4.1 4/5] tests/test-hmp: " Thomas Huth
2019-04-09  8:52   ` Thomas Huth
2019-04-09  9:09   ` Dr. David Alan Gilbert
2019-04-09  9:09     ` Dr. David Alan Gilbert
2019-04-09  8:52 ` [Qemu-devel] [PATCH for-4.1 5/5] tests/ide-test: Make test independent of global_qtest Thomas Huth
2019-04-09  8:52   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190409085245.31548-1-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=hare@suse.com \
    --cc=jsnow@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.