From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: "RaghuramChary.Jallipalli@microchip.com"
<RaghuramChary.Jallipalli@microchip.com>
Cc: "marc.zyngier@arm.com" <marc.zyngier@arm.com>,
"Woojung.Huh@microchip.com" <Woojung.Huh@microchip.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: net: lan78xx: fix "enabled interrupts" warninig
Date: Tue, 9 Apr 2019 01:36:10 +0000 [thread overview]
Message-ID: <20190409092753.39961390@xhacker.debian> (raw)
On Mon, 8 Apr 2019 10:46:52 +0000 wrote:
>
>
> > > Is this warning specific to any linux version?
> >
> > In theory, no. I only tested 5.0, 4.20, both can reproduce this warning.
> >
> This makes me think that code is fine because it occurs in 4.20 and greater. Or maybe the problem is masked in older. I maybe wrong in assuming that.
Per my understanding, the warning should occur since commit cc89c323a30e
("lan78xx: Use irq_domain for phy interrupt from USB Int. EP")
I just bought a Raspberry Pi 3B+ a few days ago, so I didn't have chance
to check 4.19 and before.
>
> >
> > The warning comes from calling generic_handle_irq() in usb tasklet context.
> > This is not correct.
> >
> > Per my understanding, if there's chained irq, we could introduce extra
> > irqdomain. E.g
> >
> > GIC <--> another irqchip controller <--> HW device
> >
> Correct, IRQ domain is generally used in chained irq controllers.
> Yes, We need to check why irq domain is used in the current driver.
>
It's introduced in the commit cc89c323a30e
Thanks
WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: "RaghuramChary.Jallipalli@microchip.com"
<RaghuramChary.Jallipalli@microchip.com>
Cc: "marc.zyngier@arm.com" <marc.zyngier@arm.com>,
"Woojung.Huh@microchip.com" <Woojung.Huh@microchip.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: lan78xx: fix "enabled interrupts" warninig
Date: Tue, 9 Apr 2019 01:36:10 +0000 [thread overview]
Message-ID: <20190409092753.39961390@xhacker.debian> (raw)
Message-ID: <20190409013610.0BxPX4Mw1v2nCgXHyODuxUKRo3hKxKh4ZkM4yum6wqM@z> (raw)
In-Reply-To: <BL0PR11MB3329824981AAA87127C157C69F2C0@BL0PR11MB3329.namprd11.prod.outlook.com>
On Mon, 8 Apr 2019 10:46:52 +0000 wrote:
>
>
> > > Is this warning specific to any linux version?
> >
> > In theory, no. I only tested 5.0, 4.20, both can reproduce this warning.
> >
> This makes me think that code is fine because it occurs in 4.20 and greater. Or maybe the problem is masked in older. I maybe wrong in assuming that.
Per my understanding, the warning should occur since commit cc89c323a30e
("lan78xx: Use irq_domain for phy interrupt from USB Int. EP")
I just bought a Raspberry Pi 3B+ a few days ago, so I didn't have chance
to check 4.19 and before.
>
> >
> > The warning comes from calling generic_handle_irq() in usb tasklet context.
> > This is not correct.
> >
> > Per my understanding, if there's chained irq, we could introduce extra
> > irqdomain. E.g
> >
> > GIC <--> another irqchip controller <--> HW device
> >
> Correct, IRQ domain is generally used in chained irq controllers.
> Yes, We need to check why irq domain is used in the current driver.
>
It's introduced in the commit cc89c323a30e
Thanks
next reply other threads:[~2019-04-09 1:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 1:36 Jisheng Zhang [this message]
2019-04-09 1:36 ` [PATCH] net: lan78xx: fix "enabled interrupts" warninig Jisheng Zhang
-- strict thread matches above, loose matches on Subject: below --
2019-04-22 5:32 Raghuram Chary J
2019-04-22 5:32 ` [PATCH] " RaghuramChary.Jallipalli
2019-04-17 8:22 Jisheng Zhang
2019-04-17 8:22 ` [PATCH] " Jisheng Zhang
2019-04-17 3:49 Raghuram Chary J
2019-04-17 3:49 ` [PATCH] " RaghuramChary.Jallipalli
2019-04-10 10:27 Marc Zyngier
2019-04-10 10:27 ` [PATCH] " Marc Zyngier
2019-04-10 9:53 Jisheng Zhang
2019-04-10 9:53 ` [PATCH] " Jisheng Zhang
2019-04-10 9:20 Raghuram Chary J
2019-04-10 9:20 ` [PATCH] " RaghuramChary.Jallipalli
2019-04-09 5:26 Raghuram Chary J
2019-04-09 5:26 ` [PATCH] " RaghuramChary.Jallipalli
2019-04-08 10:46 Raghuram Chary J
2019-04-08 10:46 ` [PATCH] " RaghuramChary.Jallipalli
2019-04-08 8:07 Jisheng Zhang
2019-04-08 8:07 ` [PATCH] " Jisheng Zhang
2019-04-08 7:46 Raghuram Chary J
2019-04-08 7:46 ` [PATCH] " RaghuramChary.Jallipalli
2019-04-08 6:10 Jisheng Zhang
2019-04-08 6:10 ` [PATCH] " Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409092753.39961390@xhacker.debian \
--to=jisheng.zhang@synaptics.com \
--cc=RaghuramChary.Jallipalli@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.