[PATCH] perf stat: Disable DIR_FORMAT feature for record

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH] perf stat: Disable DIR_FORMAT feature for record
@ 2019-04-09 10:01 Jiri Olsa
  2019-04-09 15:01 ` Arnaldo Carvalho de Melo
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Jiri Olsa @ 2019-04-09 10:01 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo
  Cc: lkml, Ingo Molnar, Namhyung Kim, Alexander Shishkin,
	Peter Zijlstra

Arnaldo reported assertion in perf stat record:

  assertion failed at util/header.c:875

There's no support for this in perf state record
command, disabling the feature.

Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Link: http://lkml.kernel.org/n/tip-2uhyh815jfwikg5uhve8log6@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/perf/builtin-stat.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 7f9c4b7f5d69..a3c060878faa 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -1322,6 +1322,7 @@ static void init_features(struct perf_session *session)
 	for (feat = HEADER_FIRST_FEATURE; feat < HEADER_LAST_FEATURE; feat++)
 		perf_header__set_feat(&session->header, feat);
 
+	perf_header__clear_feat(&session->header, HEADER_DIR_FORMAT);
 	perf_header__clear_feat(&session->header, HEADER_BUILD_ID);
 	perf_header__clear_feat(&session->header, HEADER_TRACING_DATA);
 	perf_header__clear_feat(&session->header, HEADER_BRANCH_STACK);
-- 
2.17.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] perf stat: Disable DIR_FORMAT feature for record
  2019-04-09 10:01 [PATCH] perf stat: Disable DIR_FORMAT feature for record Jiri Olsa
@ 2019-04-09 15:01 ` Arnaldo Carvalho de Melo
  2019-04-12 16:38 ` [tip:perf/urgent] perf stat: Disable DIR_FORMAT feature for 'perf stat record' tip-bot for Jiri Olsa
  2019-04-16 15:29 ` tip-bot for Jiri Olsa
  2 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2019-04-09 15:01 UTC (permalink / raw)
  To: Jiri Olsa
  Cc: lkml, Ingo Molnar, Namhyung Kim, Alexander Shishkin,
	Peter Zijlstra

Em Tue, Apr 09, 2019 at 12:01:56PM +0200, Jiri Olsa escreveu:
> Arnaldo reported assertion in perf stat record:
> 
>   assertion failed at util/header.c:875

Thanks, applied and added:

    Fixes: 258031c017c3 ("perf header: Add DIR_FORMAT feature to describe directory data")

- Arnaldo
> 
> There's no support for this in perf state record
> command, disabling the feature.
> 
> Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> Link: http://lkml.kernel.org/n/tip-2uhyh815jfwikg5uhve8log6@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
>  tools/perf/builtin-stat.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index 7f9c4b7f5d69..a3c060878faa 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -1322,6 +1322,7 @@ static void init_features(struct perf_session *session)
>  	for (feat = HEADER_FIRST_FEATURE; feat < HEADER_LAST_FEATURE; feat++)
>  		perf_header__set_feat(&session->header, feat);
>  
> +	perf_header__clear_feat(&session->header, HEADER_DIR_FORMAT);
>  	perf_header__clear_feat(&session->header, HEADER_BUILD_ID);
>  	perf_header__clear_feat(&session->header, HEADER_TRACING_DATA);
>  	perf_header__clear_feat(&session->header, HEADER_BRANCH_STACK);
> -- 
> 2.17.2

-- 

- Arnaldo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [tip:perf/urgent] perf stat: Disable DIR_FORMAT feature for 'perf stat record'
  2019-04-09 10:01 [PATCH] perf stat: Disable DIR_FORMAT feature for record Jiri Olsa
  2019-04-09 15:01 ` Arnaldo Carvalho de Melo
@ 2019-04-12 16:38 ` tip-bot for Jiri Olsa
  2019-04-16 15:29 ` tip-bot for Jiri Olsa
  2 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Jiri Olsa @ 2019-04-12 16:38 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: hpa, linux-kernel, peterz, namhyung, tglx, alexander.shishkin,
	jolsa, acme, mingo

Commit-ID:  d2d0aef9277a7e9e110545552b48b8f523ac62a4
Gitweb:     https://git.kernel.org/tip/d2d0aef9277a7e9e110545552b48b8f523ac62a4
Author:     Jiri Olsa <jolsa@kernel.org>
AuthorDate: Tue, 9 Apr 2019 12:01:56 +0200
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 9 Apr 2019 10:17:34 -0300

perf stat: Disable DIR_FORMAT feature for 'perf stat record'

Arnaldo reported assertion in perf stat record:

  assertion failed at util/header.c:875

There's no support for this in the 'perf state record' command, disable
the feature for that case.

Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Fixes: 258031c017c3 ("perf header: Add DIR_FORMAT feature to describe directory data")
Link: http://lkml.kernel.org/r/20190409100156.20303-1-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-stat.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 49ee3c2033ec..c3625ec374e0 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -1308,6 +1308,7 @@ static void init_features(struct perf_session *session)
 	for (feat = HEADER_FIRST_FEATURE; feat < HEADER_LAST_FEATURE; feat++)
 		perf_header__set_feat(&session->header, feat);
 
+	perf_header__clear_feat(&session->header, HEADER_DIR_FORMAT);
 	perf_header__clear_feat(&session->header, HEADER_BUILD_ID);
 	perf_header__clear_feat(&session->header, HEADER_TRACING_DATA);
 	perf_header__clear_feat(&session->header, HEADER_BRANCH_STACK);

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [tip:perf/urgent] perf stat: Disable DIR_FORMAT feature for 'perf stat record'
  2019-04-09 10:01 [PATCH] perf stat: Disable DIR_FORMAT feature for record Jiri Olsa
  2019-04-09 15:01 ` Arnaldo Carvalho de Melo
  2019-04-12 16:38 ` [tip:perf/urgent] perf stat: Disable DIR_FORMAT feature for 'perf stat record' tip-bot for Jiri Olsa
@ 2019-04-16 15:29 ` tip-bot for Jiri Olsa
  2 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Jiri Olsa @ 2019-04-16 15:29 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: hpa, peterz, acme, namhyung, linux-kernel, tglx, mingo,
	alexander.shishkin, jolsa

Commit-ID:  8002a63f9ace7e9c958408f77f0a4dd4a8414511
Gitweb:     https://git.kernel.org/tip/8002a63f9ace7e9c958408f77f0a4dd4a8414511
Author:     Jiri Olsa <jolsa@kernel.org>
AuthorDate: Tue, 9 Apr 2019 12:01:56 +0200
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 16 Apr 2019 11:27:18 -0300

perf stat: Disable DIR_FORMAT feature for 'perf stat record'

Arnaldo reported assertion in perf stat record:

  assertion failed at util/header.c:875

There's no support for this in the 'perf state record' command, disable
the feature for that case.

Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Fixes: 258031c017c3 ("perf header: Add DIR_FORMAT feature to describe directory data")
Link: http://lkml.kernel.org/r/20190409100156.20303-1-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-stat.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 49ee3c2033ec..c3625ec374e0 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -1308,6 +1308,7 @@ static void init_features(struct perf_session *session)
 	for (feat = HEADER_FIRST_FEATURE; feat < HEADER_LAST_FEATURE; feat++)
 		perf_header__set_feat(&session->header, feat);
 
+	perf_header__clear_feat(&session->header, HEADER_DIR_FORMAT);
 	perf_header__clear_feat(&session->header, HEADER_BUILD_ID);
 	perf_header__clear_feat(&session->header, HEADER_TRACING_DATA);
 	perf_header__clear_feat(&session->header, HEADER_BRANCH_STACK);

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-04-16 15:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-09 10:01 [PATCH] perf stat: Disable DIR_FORMAT feature for record Jiri Olsa
2019-04-09 15:01 ` Arnaldo Carvalho de Melo
2019-04-12 16:38 ` [tip:perf/urgent] perf stat: Disable DIR_FORMAT feature for 'perf stat record' tip-bot for Jiri Olsa
2019-04-16 15:29 ` tip-bot for Jiri Olsa

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.