From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: Viorel Suman <viorel.suman@nxp.com>,
Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Timur Tabi <timur@kernel.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Viorel Suman <viorel.suman@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Mark Brown <broonie@kernel.org>, dl-linux-imx <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>"linux-kernel@vger.kernel.org"
<linu>
Subject: Re: [alsa-devel] [PATCH v2 1/3] ASoC: fsl_audmix: remove "model" attribute
Date: Tue, 9 Apr 2019 23:37:14 -0700 [thread overview]
Message-ID: <20190410063714.GA4156@Asurada> (raw)
In-Reply-To: <CAEnQRZBDSrpje2-ML0zr+oJkwMbbkxV5hUNc_HzZtPZv-et8mA@mail.gmail.com>
On Wed, Apr 10, 2019 at 09:20:29AM +0300, Daniel Baluta wrote:
> Hi Nicolin,
>
> On Wed, Apr 10, 2019 at 7:30 AM Nicolin Chen <nicoleotsuka@gmail.com> wrote:
> >
> > On Tue, Apr 09, 2019 at 11:27:39AM +0000, Viorel Suman wrote:
> > > Use "of_device_id.data" to specify the machine driver
> > > instead of "model" DTS attribute.
> > >
> > > Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
> >
> > Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
> >
> > > ---
> > > sound/soc/fsl/fsl_audmix.c | 43 +++++++++++++++++++++++--------------------
> > > 1 file changed, 23 insertions(+), 20 deletions(-)
> >
> > > + priv->pdev = platform_device_register_data(&pdev->dev, mdrv, 0, NULL,
> > > + 0);
> >
> > Would you please send a separate patch to replace "pdev->dev"?
>
> I am not sure exactly how to explain this change in the commit message. It does
> make code easier to read and avoids dereferencing pdev pointer each time.
>
> Is it enough for commit description?
You mean this? https://lore.kernel.org/patchwork/patch/862610/
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Fabio Estevam <festevam@gmail.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Timur Tabi <timur@kernel.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Viorel Suman <viorel.suman@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
Viorel Suman <viorel.suman@nxp.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [alsa-devel] [PATCH v2 1/3] ASoC: fsl_audmix: remove "model" attribute
Date: Tue, 9 Apr 2019 23:37:14 -0700 [thread overview]
Message-ID: <20190410063714.GA4156@Asurada> (raw)
In-Reply-To: <CAEnQRZBDSrpje2-ML0zr+oJkwMbbkxV5hUNc_HzZtPZv-et8mA@mail.gmail.com>
On Wed, Apr 10, 2019 at 09:20:29AM +0300, Daniel Baluta wrote:
> Hi Nicolin,
>
> On Wed, Apr 10, 2019 at 7:30 AM Nicolin Chen <nicoleotsuka@gmail.com> wrote:
> >
> > On Tue, Apr 09, 2019 at 11:27:39AM +0000, Viorel Suman wrote:
> > > Use "of_device_id.data" to specify the machine driver
> > > instead of "model" DTS attribute.
> > >
> > > Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
> >
> > Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
> >
> > > ---
> > > sound/soc/fsl/fsl_audmix.c | 43 +++++++++++++++++++++++--------------------
> > > 1 file changed, 23 insertions(+), 20 deletions(-)
> >
> > > + priv->pdev = platform_device_register_data(&pdev->dev, mdrv, 0, NULL,
> > > + 0);
> >
> > Would you please send a separate patch to replace "pdev->dev"?
>
> I am not sure exactly how to explain this change in the commit message. It does
> make code easier to read and avoids dereferencing pdev pointer each time.
>
> Is it enough for commit description?
You mean this? https://lore.kernel.org/patchwork/patch/862610/
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Fabio Estevam <festevam@gmail.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Timur Tabi <timur@kernel.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Viorel Suman <viorel.suman@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
Viorel Suman <viorel.suman@nxp.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [alsa-devel] [PATCH v2 1/3] ASoC: fsl_audmix: remove "model" attribute
Date: Tue, 9 Apr 2019 23:37:14 -0700 [thread overview]
Message-ID: <20190410063714.GA4156@Asurada> (raw)
In-Reply-To: <CAEnQRZBDSrpje2-ML0zr+oJkwMbbkxV5hUNc_HzZtPZv-et8mA@mail.gmail.com>
On Wed, Apr 10, 2019 at 09:20:29AM +0300, Daniel Baluta wrote:
> Hi Nicolin,
>
> On Wed, Apr 10, 2019 at 7:30 AM Nicolin Chen <nicoleotsuka@gmail.com> wrote:
> >
> > On Tue, Apr 09, 2019 at 11:27:39AM +0000, Viorel Suman wrote:
> > > Use "of_device_id.data" to specify the machine driver
> > > instead of "model" DTS attribute.
> > >
> > > Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
> >
> > Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
> >
> > > ---
> > > sound/soc/fsl/fsl_audmix.c | 43 +++++++++++++++++++++++--------------------
> > > 1 file changed, 23 insertions(+), 20 deletions(-)
> >
> > > + priv->pdev = platform_device_register_data(&pdev->dev, mdrv, 0, NULL,
> > > + 0);
> >
> > Would you please send a separate patch to replace "pdev->dev"?
>
> I am not sure exactly how to explain this change in the commit message. It does
> make code easier to read and avoids dereferencing pdev pointer each time.
>
> Is it enough for commit description?
You mean this? https://lore.kernel.org/patchwork/patch/862610/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: Viorel Suman <viorel.suman@nxp.com>,
Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Timur Tabi <timur@kernel.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Viorel Suman <viorel.suman@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Mark Brown <broonie@kernel.org>, dl-linux-imx <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [alsa-devel] [PATCH v2 1/3] ASoC: fsl_audmix: remove "model" attribute
Date: Tue, 9 Apr 2019 23:37:14 -0700 [thread overview]
Message-ID: <20190410063714.GA4156@Asurada> (raw)
In-Reply-To: <CAEnQRZBDSrpje2-ML0zr+oJkwMbbkxV5hUNc_HzZtPZv-et8mA@mail.gmail.com>
On Wed, Apr 10, 2019 at 09:20:29AM +0300, Daniel Baluta wrote:
> Hi Nicolin,
>
> On Wed, Apr 10, 2019 at 7:30 AM Nicolin Chen <nicoleotsuka@gmail.com> wrote:
> >
> > On Tue, Apr 09, 2019 at 11:27:39AM +0000, Viorel Suman wrote:
> > > Use "of_device_id.data" to specify the machine driver
> > > instead of "model" DTS attribute.
> > >
> > > Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
> >
> > Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
> >
> > > ---
> > > sound/soc/fsl/fsl_audmix.c | 43 +++++++++++++++++++++++--------------------
> > > 1 file changed, 23 insertions(+), 20 deletions(-)
> >
> > > + priv->pdev = platform_device_register_data(&pdev->dev, mdrv, 0, NULL,
> > > + 0);
> >
> > Would you please send a separate patch to replace "pdev->dev"?
>
> I am not sure exactly how to explain this change in the commit message. It does
> make code easier to read and avoids dereferencing pdev pointer each time.
>
> Is it enough for commit description?
You mean this? https://lore.kernel.org/patchwork/patch/862610/
next prev parent reply other threads:[~2019-04-10 6:37 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 11:27 [PATCH v2 0/3] ASoC: fsl: audmix: remove "model" attribute and fix ref leaks Viorel Suman
2019-04-09 11:27 ` Viorel Suman
2019-04-09 11:27 ` Viorel Suman
2019-04-09 11:27 ` [PATCH v2 1/3] ASoC: fsl_audmix: remove "model" attribute Viorel Suman
2019-04-09 11:27 ` Viorel Suman
2019-04-09 11:27 ` Viorel Suman
2019-04-10 4:29 ` Nicolin Chen
2019-04-10 4:29 ` Nicolin Chen
2019-04-10 4:29 ` Nicolin Chen
2019-04-10 6:20 ` [alsa-devel] " Daniel Baluta
2019-04-10 6:20 ` Daniel Baluta
2019-04-10 6:20 ` Daniel Baluta
2019-04-10 6:20 ` Daniel Baluta
2019-04-10 6:37 ` Nicolin Chen [this message]
2019-04-10 6:37 ` Nicolin Chen
2019-04-10 6:37 ` Nicolin Chen
2019-04-10 6:37 ` Nicolin Chen
2019-04-10 6:48 ` Daniel Baluta
2019-04-10 6:48 ` Daniel Baluta
2019-04-10 6:48 ` Daniel Baluta
2019-04-10 6:48 ` Daniel Baluta
2019-04-10 10:34 ` [EXT] " Viorel Suman
2019-04-10 10:34 ` Viorel Suman
2019-04-10 10:34 ` Viorel Suman
2019-04-10 10:34 ` Viorel Suman
2019-04-10 17:51 ` Nicolin Chen
2019-04-10 17:51 ` Nicolin Chen
2019-04-10 17:51 ` Nicolin Chen
2019-04-10 17:51 ` Nicolin Chen
2019-04-09 11:27 ` [PATCH v2 2/3] dt-bindings: fsl,audmix: " Viorel Suman
2019-04-09 11:27 ` Viorel Suman
2019-04-09 11:27 ` Viorel Suman
2019-04-10 4:29 ` Nicolin Chen
2019-04-10 4:29 ` Nicolin Chen
2019-04-10 4:29 ` Nicolin Chen
2019-04-09 11:27 ` [PATCH v2 3/3] ASoC: imx-audmix: fix object reference leaks in probe Viorel Suman
2019-04-09 11:27 ` Viorel Suman
2019-04-09 11:27 ` Viorel Suman
2019-04-10 4:30 ` Nicolin Chen
2019-04-10 4:30 ` Nicolin Chen
2019-04-10 4:30 ` Nicolin Chen
2019-04-10 4:30 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410063714.GA4156@Asurada \
--to=nicoleotsuka@gmail.com \
--cc=Julia.Lawall@lip6.fr \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
--cc=viorel.suman@gmail.com \
--cc=viorel.suman@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.