All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 2/7] drm/i915/icl: Apply a recommended rc6 threshold
Date: Wed, 10 Apr 2019 13:59:18 +0300	[thread overview]
Message-ID: <20190410105923.18546-2-mika.kuoppala@linux.intel.com> (raw)
In-Reply-To: <20190410105923.18546-1-mika.kuoppala@linux.intel.com>

On gen11 the recommended rc6 threshold differs from previous
gens, apply it. Move the write to a correct spot in sequence.

v2: do write in 2b, fix bspec ref (Michal)

Bspec: 33149
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 43ec0fb4c197..3a157bdbee2a 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -7149,6 +7149,8 @@ static void gen11_enable_rc6(struct drm_i915_private *dev_priv)
 
 	I915_WRITE(GEN6_RC_SLEEP, 0);
 
+	I915_WRITE(GEN6_RC6_THRESHOLD, 50000); /* 50/125ms per EI */
+
 	/*
 	 * 2c: Program Coarse Power Gating Policies.
 	 *
@@ -7174,8 +7176,6 @@ static void gen11_enable_rc6(struct drm_i915_private *dev_priv)
 	I915_WRITE(GEN9_RENDER_PG_IDLE_HYSTERESIS, 250);
 
 	/* 3a: Enable RC6 */
-	I915_WRITE(GEN6_RC6_THRESHOLD, 37500); /* 37.5/125ms per EI */
-
 	I915_WRITE(GEN6_RC_CONTROL,
 		   GEN6_RC_CTL_HW_ENABLE |
 		   GEN6_RC_CTL_RC6_ENABLE |
-- 
2.17.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-04-10 10:59 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-10 10:59 [PATCH 1/7] drm/i915: Use dedicated rc6 enabling sequence for gen11 Mika Kuoppala
2019-04-10 10:59 ` Mika Kuoppala [this message]
2019-04-10 13:37   ` [PATCH 2/7] drm/i915/icl: Apply a recommended rc6 threshold Chris Wilson
2019-04-10 13:53   ` Michal Wajdeczko
2019-04-10 10:59 ` [PATCH 3/7] drm/i915/icl: Enable media sampler powergate Mika Kuoppala
2019-04-10 13:38   ` Chris Wilson
2019-04-10 10:59 ` [PATCH 4/7] drm/i915/icl: Disable video turbo mode for rp control Mika Kuoppala
2019-04-10 11:04   ` Chris Wilson
2019-04-10 13:24     ` Mika Kuoppala
2019-04-10 13:43       ` Chris Wilson
2019-04-10 10:59 ` [PATCH 5/7] drm/i915/icl: Handle rps interrupts without irq lock Mika Kuoppala
2019-04-10 10:59 ` [PATCH 6/7] drm/i915: Use Engine1 instance for gen11 pm interrupts Mika Kuoppala
2019-04-10 13:39   ` Chris Wilson
2019-04-10 10:59 ` [PATCH 7/7] drm/i915/icl: Don't warn on spurious interrupts Mika Kuoppala
2019-04-10 11:07   ` Chris Wilson
2019-04-10 11:10 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915: Use dedicated rc6 enabling sequence for gen11 Patchwork
2019-04-10 11:31 ` ✓ Fi.CI.BAT: success " Patchwork
2019-04-10 14:32 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915: Use dedicated rc6 enabling sequence for gen11 (rev2) Patchwork
2019-04-10 14:57 ` ✓ Fi.CI.IGT: success for series starting with [1/7] drm/i915: Use dedicated rc6 enabling sequence for gen11 Patchwork
2019-04-10 15:01 ` ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915: Use dedicated rc6 enabling sequence for gen11 (rev2) Patchwork
2019-04-10 22:24 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-04-11  7:45   ` Chris Wilson
  -- strict thread matches above, loose matches on Subject: below --
2019-04-09 16:13 [PATCH 1/7] drm/i915: Use dedicated rc6 enabling sequence for gen11 Mika Kuoppala
2019-04-09 16:13 ` [PATCH 2/7] drm/i915/icl: Apply a recommended rc6 threshold Mika Kuoppala
2019-04-09 16:51   ` Michal Wajdeczko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190410105923.18546-2-mika.kuoppala@linux.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.