* [PATCH] i3c: Fix the verification of random PID
@ 2019-04-09 16:59 ` Vitor Soares
0 siblings, 0 replies; 4+ messages in thread
From: Vitor Soares @ 2019-04-09 16:59 UTC (permalink / raw)
To: linux-i3c; +Cc: joao.pinto, Boris Brezillon, stable, Vitor Soares
The validation of random PID should be done by checking the
boardinfo->pid instead of info.pid which is empty.
Doing the change the info struture declaration is no longer necessary.
Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
Signed-off-by: Vitor Soares <vitor.soares@synopsys.com>
Cc: Boris Brezillon <bbrezillon@kernel.org>
Cc: <stable@vger.kernel.org>
---
drivers/i3c/master.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index 569ea68..d23a57e 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -2006,7 +2006,6 @@ of_i3c_master_add_i3c_boardinfo(struct i3c_master_controller *master,
{
struct i3c_dev_boardinfo *boardinfo;
struct device *dev = &master->dev;
- struct i3c_device_info info = { };
enum i3c_addr_slot_status addrstatus;
u32 init_dyn_addr = 0;
@@ -2038,8 +2037,8 @@ of_i3c_master_add_i3c_boardinfo(struct i3c_master_controller *master,
boardinfo->pid = ((u64)reg[1] << 32) | reg[2];
- if ((info.pid & GENMASK_ULL(63, 48)) ||
- I3C_PID_RND_LOWER_32BITS(info.pid))
+ if ((boardinfo->pid & GENMASK_ULL(63, 48)) ||
+ I3C_PID_RND_LOWER_32BITS(boardinfo->pid))
return -EINVAL;
boardinfo->init_dyn_addr = init_dyn_addr;
--
2.7.4
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] i3c: Fix the verification of random PID
@ 2019-04-09 16:59 ` Vitor Soares
0 siblings, 0 replies; 4+ messages in thread
From: Vitor Soares @ 2019-04-09 16:59 UTC (permalink / raw)
To: linux-i3c; +Cc: joao.pinto, Vitor Soares, Boris Brezillon, stable
The validation of random PID should be done by checking the
boardinfo->pid instead of info.pid which is empty.
Doing the change the info struture declaration is no longer necessary.
Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
Signed-off-by: Vitor Soares <vitor.soares@synopsys.com>
Cc: Boris Brezillon <bbrezillon@kernel.org>
Cc: <stable@vger.kernel.org>
---
drivers/i3c/master.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index 569ea68..d23a57e 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -2006,7 +2006,6 @@ of_i3c_master_add_i3c_boardinfo(struct i3c_master_controller *master,
{
struct i3c_dev_boardinfo *boardinfo;
struct device *dev = &master->dev;
- struct i3c_device_info info = { };
enum i3c_addr_slot_status addrstatus;
u32 init_dyn_addr = 0;
@@ -2038,8 +2037,8 @@ of_i3c_master_add_i3c_boardinfo(struct i3c_master_controller *master,
boardinfo->pid = ((u64)reg[1] << 32) | reg[2];
- if ((info.pid & GENMASK_ULL(63, 48)) ||
- I3C_PID_RND_LOWER_32BITS(info.pid))
+ if ((boardinfo->pid & GENMASK_ULL(63, 48)) ||
+ I3C_PID_RND_LOWER_32BITS(boardinfo->pid))
return -EINVAL;
boardinfo->init_dyn_addr = init_dyn_addr;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] i3c: Fix the verification of random PID
2019-04-09 16:59 ` Vitor Soares
@ 2019-04-10 10:37 ` Boris Brezillon
-1 siblings, 0 replies; 4+ messages in thread
From: Boris Brezillon @ 2019-04-10 10:37 UTC (permalink / raw)
To: Vitor Soares; +Cc: linux-i3c, joao.pinto, stable, Boris Brezillon
On Tue, 9 Apr 2019 18:59:59 +0200
Vitor Soares <vitor.soares@synopsys.com> wrote:
> The validation of random PID should be done by checking the
> boardinfo->pid instead of info.pid which is empty.
>
> Doing the change the info struture declaration is no longer necessary.
>
> Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
> Signed-off-by: Vitor Soares <vitor.soares@synopsys.com>
>
Note for you future contributions: please don't add a blank line
between Cc and SoB/Fixes lines.
> Cc: Boris Brezillon <bbrezillon@kernel.org>
> Cc: <stable@vger.kernel.org>
> ---
> drivers/i3c/master.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index 569ea68..d23a57e 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -2006,7 +2006,6 @@ of_i3c_master_add_i3c_boardinfo(struct i3c_master_controller *master,
> {
> struct i3c_dev_boardinfo *boardinfo;
> struct device *dev = &master->dev;
> - struct i3c_device_info info = { };
> enum i3c_addr_slot_status addrstatus;
> u32 init_dyn_addr = 0;
>
> @@ -2038,8 +2037,8 @@ of_i3c_master_add_i3c_boardinfo(struct i3c_master_controller *master,
>
> boardinfo->pid = ((u64)reg[1] << 32) | reg[2];
>
> - if ((info.pid & GENMASK_ULL(63, 48)) ||
> - I3C_PID_RND_LOWER_32BITS(info.pid))
> + if ((boardinfo->pid & GENMASK_ULL(63, 48)) ||
> + I3C_PID_RND_LOWER_32BITS(boardinfo->pid))
> return -EINVAL;
>
> boardinfo->init_dyn_addr = init_dyn_addr;
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] i3c: Fix the verification of random PID
@ 2019-04-10 10:37 ` Boris Brezillon
0 siblings, 0 replies; 4+ messages in thread
From: Boris Brezillon @ 2019-04-10 10:37 UTC (permalink / raw)
To: Vitor Soares; +Cc: linux-i3c, joao.pinto, Boris Brezillon, stable
On Tue, 9 Apr 2019 18:59:59 +0200
Vitor Soares <vitor.soares@synopsys.com> wrote:
> The validation of random PID should be done by checking the
> boardinfo->pid instead of info.pid which is empty.
>
> Doing the change the info struture declaration is no longer necessary.
>
> Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
> Signed-off-by: Vitor Soares <vitor.soares@synopsys.com>
>
Note for you future contributions: please don't add a blank line
between Cc and SoB/Fixes lines.
> Cc: Boris Brezillon <bbrezillon@kernel.org>
> Cc: <stable@vger.kernel.org>
> ---
> drivers/i3c/master.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index 569ea68..d23a57e 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -2006,7 +2006,6 @@ of_i3c_master_add_i3c_boardinfo(struct i3c_master_controller *master,
> {
> struct i3c_dev_boardinfo *boardinfo;
> struct device *dev = &master->dev;
> - struct i3c_device_info info = { };
> enum i3c_addr_slot_status addrstatus;
> u32 init_dyn_addr = 0;
>
> @@ -2038,8 +2037,8 @@ of_i3c_master_add_i3c_boardinfo(struct i3c_master_controller *master,
>
> boardinfo->pid = ((u64)reg[1] << 32) | reg[2];
>
> - if ((info.pid & GENMASK_ULL(63, 48)) ||
> - I3C_PID_RND_LOWER_32BITS(info.pid))
> + if ((boardinfo->pid & GENMASK_ULL(63, 48)) ||
> + I3C_PID_RND_LOWER_32BITS(boardinfo->pid))
> return -EINVAL;
>
> boardinfo->init_dyn_addr = init_dyn_addr;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-10 10:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-09 16:59 [PATCH] i3c: Fix the verification of random PID Vitor Soares
2019-04-09 16:59 ` Vitor Soares
2019-04-10 10:37 ` Boris Brezillon
2019-04-10 10:37 ` Boris Brezillon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.