All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony PERARD <anthony.perard@citrix.com>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	qemu-block@nongnu.org, qemu-devel@nongnu.org,
	Max Reitz <mreitz@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH 3/3] xen-bus / xen-block: add support for event channel polling
Date: Wed, 10 Apr 2019 16:09:18 +0100	[thread overview]
Message-ID: <20190410150918.GF1435@perard.uk.xensource.com> (raw)
In-Reply-To: <20190408151617.13025-4-paul.durrant@citrix.com>

On Mon, Apr 08, 2019 at 04:16:17PM +0100, Paul Durrant wrote:
> This patch introduces a poll callback for event channel fd-s and uses
> this to invoke the channel callback function.
> 
> To properly support polling, it is necessary for the event channel callback
> function to return a boolean saying whether it has done any useful work or
> not. Thus xen_block_dataplane_event() is modified to directly invoke
> xen_block_handle_requests() and the latter only returns true if it actually
> processes any requests. This also means that the call to qemu_bh_schedule()
> is moved into xen_block_complete_aio(), which is more intuitive since the
> only reason for doing a deferred poll of the shared ring should be because
> there were previously insufficient resources to fully complete a previous
> poll.
> 
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> ---

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: Anthony PERARD <anthony.perard@citrix.com>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	qemu-block@nongnu.org, qemu-devel@nongnu.org,
	Max Reitz <mreitz@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH 3/3] xen-bus / xen-block: add support for event channel polling
Date: Wed, 10 Apr 2019 16:09:18 +0100	[thread overview]
Message-ID: <20190410150918.GF1435@perard.uk.xensource.com> (raw)
Message-ID: <20190410150918.OWt_QaPIVoMvI7zbAE8bNs57JZ_Gt2TfY756HKcBgoA@z> (raw)
In-Reply-To: <20190408151617.13025-4-paul.durrant@citrix.com>

On Mon, Apr 08, 2019 at 04:16:17PM +0100, Paul Durrant wrote:
> This patch introduces a poll callback for event channel fd-s and uses
> this to invoke the channel callback function.
> 
> To properly support polling, it is necessary for the event channel callback
> function to return a boolean saying whether it has done any useful work or
> not. Thus xen_block_dataplane_event() is modified to directly invoke
> xen_block_handle_requests() and the latter only returns true if it actually
> processes any requests. This also means that the call to qemu_bh_schedule()
> is moved into xen_block_complete_aio(), which is more intuitive since the
> only reason for doing a deferred poll of the shared ring should be because
> there were previously insufficient resources to fully complete a previous
> poll.
> 
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> ---

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: Anthony PERARD <anthony.perard@citrix.com>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	xen-devel@lists.xenproject.org,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] xen-bus / xen-block: add support for event channel polling
Date: Wed, 10 Apr 2019 16:09:18 +0100	[thread overview]
Message-ID: <20190410150918.GF1435@perard.uk.xensource.com> (raw)
In-Reply-To: <20190408151617.13025-4-paul.durrant@citrix.com>

On Mon, Apr 08, 2019 at 04:16:17PM +0100, Paul Durrant wrote:
> This patch introduces a poll callback for event channel fd-s and uses
> this to invoke the channel callback function.
> 
> To properly support polling, it is necessary for the event channel callback
> function to return a boolean saying whether it has done any useful work or
> not. Thus xen_block_dataplane_event() is modified to directly invoke
> xen_block_handle_requests() and the latter only returns true if it actually
> processes any requests. This also means that the call to qemu_bh_schedule()
> is moved into xen_block_complete_aio(), which is more intuitive since the
> only reason for doing a deferred poll of the shared ring should be because
> there were previously insufficient resources to fully complete a previous
> poll.
> 
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> ---

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD

WARNING: multiple messages have this Message-ID (diff)
From: Anthony PERARD <anthony.perard@citrix.com>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	qemu-block@nongnu.org, qemu-devel@nongnu.org,
	Max Reitz <mreitz@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [Qemu-devel] [PATCH 3/3] xen-bus / xen-block: add support for event channel polling
Date: Wed, 10 Apr 2019 16:09:18 +0100	[thread overview]
Message-ID: <20190410150918.GF1435@perard.uk.xensource.com> (raw)
Message-ID: <20190410150918.kIOW9YyeHP4BrrJ0ah440bL4yZk1PH9Diz-9ATghjkk@z> (raw)
In-Reply-To: <20190408151617.13025-4-paul.durrant@citrix.com>

On Mon, Apr 08, 2019 at 04:16:17PM +0100, Paul Durrant wrote:
> This patch introduces a poll callback for event channel fd-s and uses
> this to invoke the channel callback function.
> 
> To properly support polling, it is necessary for the event channel callback
> function to return a boolean saying whether it has done any useful work or
> not. Thus xen_block_dataplane_event() is modified to directly invoke
> xen_block_handle_requests() and the latter only returns true if it actually
> processes any requests. This also means that the call to qemu_bh_schedule()
> is moved into xen_block_complete_aio(), which is more intuitive since the
> only reason for doing a deferred poll of the shared ring should be because
> there were previously insufficient resources to fully complete a previous
> poll.
> 
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> ---

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


  reply	other threads:[~2019-04-10 15:10 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-08 15:16 [Xen-devel] [PATCH 0/3] Support IOThread polling for PV shared rings Paul Durrant
2019-04-08 15:16 ` [Qemu-devel] " Paul Durrant
2019-04-08 15:16 ` Paul Durrant
2019-04-08 15:16 ` [PATCH 1/3] xen-bus: use a separate fd for each event channel Paul Durrant
2019-04-08 15:16   ` [Qemu-devel] " Paul Durrant
2019-04-08 15:16   ` Paul Durrant
2019-04-08 15:16   ` [Xen-devel] " Paul Durrant
2019-04-10 11:37   ` Anthony PERARD
2019-04-10 11:37     ` [Qemu-devel] " Anthony PERARD
2019-04-10 11:37     ` Anthony PERARD
2019-04-10 11:37   ` Anthony PERARD
2019-04-08 15:16 ` [PATCH 2/3] xen-bus: allow AioContext to be specified " Paul Durrant
2019-04-08 15:16 ` [Xen-devel] " Paul Durrant
2019-04-08 15:16   ` [Qemu-devel] " Paul Durrant
2019-04-08 15:16   ` Paul Durrant
2019-04-10 12:57   ` [Xen-devel] " Anthony PERARD
2019-04-10 12:57     ` [Qemu-devel] " Anthony PERARD
2019-04-10 12:57     ` Anthony PERARD
2019-04-10 15:20     ` Paul Durrant
2019-04-10 15:20     ` [Xen-devel] " Paul Durrant
2019-04-10 15:20       ` [Qemu-devel] " Paul Durrant
2019-04-10 15:20       ` Paul Durrant
2019-04-10 15:22       ` [Xen-devel] " Anthony PERARD
2019-04-10 15:22         ` [Qemu-devel] " Anthony PERARD
2019-04-10 15:22         ` Anthony PERARD
2019-04-10 15:56         ` Paul Durrant
2019-04-10 15:56           ` [Qemu-devel] " Paul Durrant
2019-04-10 15:56           ` Paul Durrant
2019-04-10 15:56           ` [Xen-devel] " Paul Durrant
2019-04-10 15:22       ` Anthony PERARD
2019-04-15  8:42       ` [Xen-devel] [Qemu-block] " Stefan Hajnoczi
2019-04-15  8:42         ` [Qemu-devel] " Stefan Hajnoczi
2019-04-15  8:42         ` Stefan Hajnoczi
2019-04-16  9:36         ` [Xen-devel] " Paul Durrant
2019-04-16  9:36           ` Paul Durrant
2019-04-16  9:36         ` Paul Durrant
2019-04-15  8:42       ` Stefan Hajnoczi
2019-04-10 12:57   ` Anthony PERARD
2019-04-08 15:16 ` [PATCH 3/3] xen-bus / xen-block: add support for event channel polling Paul Durrant
2019-04-08 15:16 ` [Xen-devel] " Paul Durrant
2019-04-08 15:16   ` [Qemu-devel] " Paul Durrant
2019-04-08 15:16   ` Paul Durrant
2019-04-10 15:09   ` Anthony PERARD [this message]
2019-04-10 15:09     ` Anthony PERARD
2019-04-10 15:09     ` Anthony PERARD
2019-04-10 15:09     ` [Xen-devel] " Anthony PERARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190410150918.GF1435@perard.uk.xensource.com \
    --to=anthony.perard@citrix.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=paul.durrant@citrix.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sstabellini@kernel.org \
    --cc=stefanha@redhat.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.