From: Keith Busch <kbusch@kernel.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Sagi Grimberg <sagi@grimberg.me>,
Bart Van Assche <bvanassche@acm.org>,
James Smart <james.smart@broadcom.com>,
Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH V4 0/2] blk-mq/nvme: cancel request synchronously
Date: Wed, 10 Apr 2019 09:30:06 -0600 [thread overview]
Message-ID: <20190410153004.GB3714@localhost.localdomain> (raw)
In-Reply-To: <20190410150436.GA23621@ming.t460p>
On Wed, Apr 10, 2019 at 11:04:38PM +0800, Ming Lei wrote:
> On Tue, Apr 09, 2019 at 06:31:20AM +0800, Ming Lei wrote:
> > Hi,
> >
> > This patchset introduces blk_mq_complete_request_sync() for canceling
> > request synchronously in error handler context, then one race between
> > completing request remotely and destroying contoller/queues can be fixed.
> >
> >
> > V4:
> > - drop return value
> > - don't handle fake timeout
> >
> > V3:
> > - avoid extra cost to blk_mq_complete_request
> >
> > V2:
> > - export via EXPORT_SYMBOL_GPL
> > - minor commit log change
> >
> > Ming Lei (2):
> > blk-mq: introduce blk_mq_complete_request_sync()
> > nvme: cancel request synchronously
> >
> > block/blk-mq.c | 7 +++++++
> > drivers/nvme/host/core.c | 2 +-
> > include/linux/blk-mq.h | 1 +
> > 3 files changed, 9 insertions(+), 1 deletion(-)
> >
> > Cc: Keith Busch <kbusch@kernel.org>
> > Cc: Sagi Grimberg <sagi@grimberg.me>
> > Cc: Bart Van Assche <bvanassche@acm.org>
> > Cc: James Smart <james.smart@broadcom.com>
> > Cc: Christoph Hellwig <hch@lst.de>
> > Cc: linux-nvme@lists.infradead.org
> >
>
> Hi Jens,
>
> These two patches have been posted for a while, any chance to make them
> in v5.1?
FWIW, series looks good to me too.
Reviewed-by: Keith Busch <keith.busch@intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: kbusch@kernel.org (Keith Busch)
Subject: [PATCH V4 0/2] blk-mq/nvme: cancel request synchronously
Date: Wed, 10 Apr 2019 09:30:06 -0600 [thread overview]
Message-ID: <20190410153004.GB3714@localhost.localdomain> (raw)
In-Reply-To: <20190410150436.GA23621@ming.t460p>
On Wed, Apr 10, 2019@11:04:38PM +0800, Ming Lei wrote:
> On Tue, Apr 09, 2019@06:31:20AM +0800, Ming Lei wrote:
> > Hi,
> >
> > This patchset introduces blk_mq_complete_request_sync() for canceling
> > request synchronously in error handler context, then one race between
> > completing request remotely and destroying contoller/queues can be fixed.
> >
> >
> > V4:
> > - drop return value
> > - don't handle fake timeout
> >
> > V3:
> > - avoid extra cost to blk_mq_complete_request
> >
> > V2:
> > - export via EXPORT_SYMBOL_GPL
> > - minor commit log change
> >
> > Ming Lei (2):
> > blk-mq: introduce blk_mq_complete_request_sync()
> > nvme: cancel request synchronously
> >
> > block/blk-mq.c | 7 +++++++
> > drivers/nvme/host/core.c | 2 +-
> > include/linux/blk-mq.h | 1 +
> > 3 files changed, 9 insertions(+), 1 deletion(-)
> >
> > Cc: Keith Busch <kbusch at kernel.org>
> > Cc: Sagi Grimberg <sagi at grimberg.me>
> > Cc: Bart Van Assche <bvanassche at acm.org>
> > Cc: James Smart <james.smart at broadcom.com>
> > Cc: Christoph Hellwig <hch at lst.de>
> > Cc: linux-nvme at lists.infradead.org
> >
>
> Hi Jens,
>
> These two patches have been posted for a while, any chance to make them
> in v5.1?
FWIW, series looks good to me too.
Reviewed-by: Keith Busch <keith.busch at intel.com>
next prev parent reply other threads:[~2019-04-10 15:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 22:31 [PATCH V4 0/2] blk-mq/nvme: cancel request synchronously Ming Lei
2019-04-08 22:31 ` Ming Lei
2019-04-08 22:31 ` [PATCH V4 1/2] blk-mq: introduce blk_mq_complete_request_sync() Ming Lei
2019-04-08 22:31 ` Ming Lei
2019-04-09 9:48 ` Christoph Hellwig
2019-04-09 9:48 ` Christoph Hellwig
2019-04-08 22:31 ` [PATCH V4 2/2] nvme: cancel request synchronously Ming Lei
2019-04-08 22:31 ` Ming Lei
2019-04-10 15:04 ` [PATCH V4 0/2] blk-mq/nvme: " Ming Lei
2019-04-10 15:04 ` Ming Lei
2019-04-10 15:30 ` Keith Busch [this message]
2019-04-10 15:30 ` Keith Busch
2019-04-10 15:57 ` Jens Axboe
2019-04-10 15:57 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410153004.GB3714@localhost.localdomain \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.