[PATCH 1/4] ARM: dts: imx6: RDU2: Use new CODEC reset pin name

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH 1/4] ARM: dts: imx6: RDU2: Use new CODEC reset pin name
@ 2019-03-29 18:13 ` Andrew F. Davis
  0 siblings, 0 replies; 10+ messages in thread
From: Andrew F. Davis @ 2019-03-29 18:13 UTC (permalink / raw)
  To: Shawn Guo, Sascha Hauer, Benoît Cousson, Tony Lindgren
  Cc: devicetree, linux-omap, linux-kernel, Andrew F . Davis

The correct DT property for specifying a GPIO used for reset
is "reset-gpios", the driver now accepts this name, use it here.

Note the GPIO polarity in the driver was ignored before and always
assumed to be active low, when all the DTs are fixed we will start
respecting the specified polarity. Switch polarity in DT to the
currently assumed one, this way when the driver changes the
behavior will not change.

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
index 69942c7ff89d..cbf7c9cae565 100644
--- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
@@ -384,7 +384,7 @@
 		AVDD-supply = <&reg_3p3v>;
 		IOVDD-supply = <&reg_3p3v>;
 		DVDD-supply = <&vgen4_reg>;
-		gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>;
 	};

 	accel@1c {
@@ -572,7 +572,7 @@
 		AVDD-supply = <&reg_3p3v>;
 		IOVDD-supply = <&reg_3p3v>;
 		DVDD-supply = <&vgen4_reg>;
-		gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
 	};

 	touchscreen@20 {
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 1/4] ARM: dts: imx6: RDU2: Use new CODEC reset pin name
@ 2019-03-29 18:13 ` Andrew F. Davis
  0 siblings, 0 replies; 10+ messages in thread
From: Andrew F. Davis @ 2019-03-29 18:13 UTC (permalink / raw)
  To: Shawn Guo, Sascha Hauer, Benoît Cousson, Tony Lindgren
  Cc: devicetree, linux-omap, linux-kernel, Andrew F . Davis

The correct DT property for specifying a GPIO used for reset
is "reset-gpios", the driver now accepts this name, use it here.

Note the GPIO polarity in the driver was ignored before and always
assumed to be active low, when all the DTs are fixed we will start
respecting the specified polarity. Switch polarity in DT to the
currently assumed one, this way when the driver changes the
behavior will not change.

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
index 69942c7ff89d..cbf7c9cae565 100644
--- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
@@ -384,7 +384,7 @@
 		AVDD-supply = <&reg_3p3v>;
 		IOVDD-supply = <&reg_3p3v>;
 		DVDD-supply = <&vgen4_reg>;
-		gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>;
 	};

 	accel@1c {
@@ -572,7 +572,7 @@
 		AVDD-supply = <&reg_3p3v>;
 		IOVDD-supply = <&reg_3p3v>;
 		DVDD-supply = <&vgen4_reg>;
-		gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
 	};

 	touchscreen@20 {
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/4] ARM: dts: imx: Use new CODEC reset pin name
  2019-03-29 18:13 ` Andrew F. Davis
@ 2019-03-29 18:13   ` Andrew F. Davis
  -1 siblings, 0 replies; 10+ messages in thread
From: Andrew F. Davis @ 2019-03-29 18:13 UTC (permalink / raw)
  To: Shawn Guo, Sascha Hauer, Benoît Cousson, Tony Lindgren
  Cc: devicetree, linux-omap, linux-kernel, Andrew F . Davis

The correct DT property for specifying a GPIO used for reset
is "reset-gpios", the driver now accepts this name, use it here.

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 arch/arm/boot/dts/imx6qdl-gw5903.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-gw5903.dtsi b/arch/arm/boot/dts/imx6qdl-gw5903.dtsi
index 9cb9a7439121..aee9221f0f29 100644
--- a/arch/arm/boot/dts/imx6qdl-gw5903.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw5903.dtsi
@@ -311,7 +311,7 @@
 	tlv320aic3105: codec@18 {
 		compatible = "ti,tlv320aic3x";
 		reg = <0x18>;
-		gpio-reset = <&gpio5 17 GPIO_ACTIVE_LOW>;
+		reset-gpios = <&gpio5 17 GPIO_ACTIVE_LOW>;
 		clocks = <&clks IMX6QDL_CLK_CKO>;
 		ai3x-micbias-vg = <2>; /* MICBIAS_2_5V */
 		/* Regulators */
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/4] ARM: dts: imx: Use new CODEC reset pin name
@ 2019-03-29 18:13   ` Andrew F. Davis
  0 siblings, 0 replies; 10+ messages in thread
From: Andrew F. Davis @ 2019-03-29 18:13 UTC (permalink / raw)
  To: Shawn Guo, Sascha Hauer, Benoît Cousson, Tony Lindgren
  Cc: devicetree, linux-omap, linux-kernel, Andrew F . Davis

The correct DT property for specifying a GPIO used for reset
is "reset-gpios", the driver now accepts this name, use it here.

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 arch/arm/boot/dts/imx6qdl-gw5903.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-gw5903.dtsi b/arch/arm/boot/dts/imx6qdl-gw5903.dtsi
index 9cb9a7439121..aee9221f0f29 100644
--- a/arch/arm/boot/dts/imx6qdl-gw5903.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw5903.dtsi
@@ -311,7 +311,7 @@
 	tlv320aic3105: codec@18 {
 		compatible = "ti,tlv320aic3x";
 		reg = <0x18>;
-		gpio-reset = <&gpio5 17 GPIO_ACTIVE_LOW>;
+		reset-gpios = <&gpio5 17 GPIO_ACTIVE_LOW>;
 		clocks = <&clks IMX6QDL_CLK_CKO>;
 		ai3x-micbias-vg = <2>; /* MICBIAS_2_5V */
 		/* Regulators */
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 3/4] ARM: dts: imx6qdl: Use new CODEC reset pin name
  2019-03-29 18:13 ` Andrew F. Davis
@ 2019-03-29 18:13   ` Andrew F. Davis
  -1 siblings, 0 replies; 10+ messages in thread
From: Andrew F. Davis @ 2019-03-29 18:13 UTC (permalink / raw)
  To: Shawn Guo, Sascha Hauer, Benoît Cousson, Tony Lindgren
  Cc: devicetree, linux-omap, linux-kernel, Andrew F . Davis

The correct DT property for specifying a GPIO used for reset
is "reset-gpios", the driver now accepts this name, use it here.

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 arch/arm/boot/dts/imx6qdl-var-dart.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-var-dart.dtsi b/arch/arm/boot/dts/imx6qdl-var-dart.dtsi
index 8752a4961c47..c41cac502bac 100644
--- a/arch/arm/boot/dts/imx6qdl-var-dart.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-var-dart.dtsi
@@ -183,7 +183,7 @@
 		IOVDD-supply = <&reg_3p3v>;
 		DVDD-supply = <&reg_3p3v>;
 		ai3x-ocmv = <0>;
-		gpio-reset = <&gpio5 5 GPIO_ACTIVE_LOW>;
+		reset-gpios = <&gpio5 5 GPIO_ACTIVE_LOW>;
 	};
 };
 
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 3/4] ARM: dts: imx6qdl: Use new CODEC reset pin name
@ 2019-03-29 18:13   ` Andrew F. Davis
  0 siblings, 0 replies; 10+ messages in thread
From: Andrew F. Davis @ 2019-03-29 18:13 UTC (permalink / raw)
  To: Shawn Guo, Sascha Hauer, Benoît Cousson, Tony Lindgren
  Cc: devicetree, linux-omap, linux-kernel, Andrew F . Davis

The correct DT property for specifying a GPIO used for reset
is "reset-gpios", the driver now accepts this name, use it here.

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 arch/arm/boot/dts/imx6qdl-var-dart.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-var-dart.dtsi b/arch/arm/boot/dts/imx6qdl-var-dart.dtsi
index 8752a4961c47..c41cac502bac 100644
--- a/arch/arm/boot/dts/imx6qdl-var-dart.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-var-dart.dtsi
@@ -183,7 +183,7 @@
 		IOVDD-supply = <&reg_3p3v>;
 		DVDD-supply = <&reg_3p3v>;
 		ai3x-ocmv = <0>;
-		gpio-reset = <&gpio5 5 GPIO_ACTIVE_LOW>;
+		reset-gpios = <&gpio5 5 GPIO_ACTIVE_LOW>;
 	};
 };

-- 
2.21.0

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 4/4] ARM: dts: omap2420-n810: Use new CODEC reset pin name
  2019-03-29 18:13 ` Andrew F. Davis
@ 2019-03-29 18:13   ` Andrew F. Davis
  -1 siblings, 0 replies; 10+ messages in thread
From: Andrew F. Davis @ 2019-03-29 18:13 UTC (permalink / raw)
  To: Shawn Guo, Sascha Hauer, Benoît Cousson, Tony Lindgren
  Cc: devicetree, linux-omap, linux-kernel, Andrew F . Davis

The correct DT property for specifying a GPIO used for reset
is "reset-gpios", the driver now accepts this name, use it here.

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 arch/arm/boot/dts/omap2420-n810.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/omap2420-n810.dts b/arch/arm/boot/dts/omap2420-n810.dts
index 96b9913ecc1f..09c1dbc0bb69 100644
--- a/arch/arm/boot/dts/omap2420-n810.dts
+++ b/arch/arm/boot/dts/omap2420-n810.dts
@@ -48,7 +48,7 @@
 		pinctrl-names = "default";
 		pinctrl-0 = <&aic33_pins>;
 
-		gpio-reset = <&gpio4 22 GPIO_ACTIVE_LOW>; /* gpio118 */
+		reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>; /* gpio118 */
 
 		ai3x-gpio-func = <
 			10 /* AIC3X_GPIO1_FUNC_DIGITAL_MIC_MODCLK */
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 4/4] ARM: dts: omap2420-n810: Use new CODEC reset pin name
@ 2019-03-29 18:13   ` Andrew F. Davis
  0 siblings, 0 replies; 10+ messages in thread
From: Andrew F. Davis @ 2019-03-29 18:13 UTC (permalink / raw)
  To: Shawn Guo, Sascha Hauer, Benoît Cousson, Tony Lindgren
  Cc: devicetree, linux-omap, linux-kernel, Andrew F . Davis

The correct DT property for specifying a GPIO used for reset
is "reset-gpios", the driver now accepts this name, use it here.

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 arch/arm/boot/dts/omap2420-n810.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/omap2420-n810.dts b/arch/arm/boot/dts/omap2420-n810.dts
index 96b9913ecc1f..09c1dbc0bb69 100644
--- a/arch/arm/boot/dts/omap2420-n810.dts
+++ b/arch/arm/boot/dts/omap2420-n810.dts
@@ -48,7 +48,7 @@
 		pinctrl-names = "default";
 		pinctrl-0 = <&aic33_pins>;
 
-		gpio-reset = <&gpio4 22 GPIO_ACTIVE_LOW>; /* gpio118 */
+		reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>; /* gpio118 */
 
 		ai3x-gpio-func = <
 			10 /* AIC3X_GPIO1_FUNC_DIGITAL_MIC_MODCLK */
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 4/4] ARM: dts: omap2420-n810: Use new CODEC reset pin name
  2019-03-29 18:13   ` Andrew F. Davis
  (?)
@ 2019-04-09 15:10   ` Tony Lindgren
  -1 siblings, 0 replies; 10+ messages in thread
From: Tony Lindgren @ 2019-04-09 15:10 UTC (permalink / raw)
  To: Andrew F. Davis
  Cc: Shawn Guo, Sascha Hauer, Benoît Cousson, devicetree,
	linux-omap, linux-kernel

* Andrew F. Davis <afd@ti.com> [190329 11:13]:
> The correct DT property for specifying a GPIO used for reset
> is "reset-gpios", the driver now accepts this name, use it here.

I'll apply this patch into omap-for-v5.2/dt thanks.

Tony

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/4] ARM: dts: imx6: RDU2: Use new CODEC reset pin name
  2019-03-29 18:13 ` Andrew F. Davis
                   ` (3 preceding siblings ...)
  (?)
@ 2019-04-11  2:42 ` Shawn Guo
  -1 siblings, 0 replies; 10+ messages in thread
From: Shawn Guo @ 2019-04-11  2:42 UTC (permalink / raw)
  To: Andrew F. Davis
  Cc: Sascha Hauer, Benoît Cousson, Tony Lindgren, devicetree,
	linux-omap, linux-kernel

On Fri, Mar 29, 2019 at 01:13:10PM -0500, Andrew F. Davis wrote:
> The correct DT property for specifying a GPIO used for reset
> is "reset-gpios", the driver now accepts this name, use it here.
> 
> Note the GPIO polarity in the driver was ignored before and always
> assumed to be active low, when all the DTs are fixed we will start
> respecting the specified polarity. Switch polarity in DT to the
> currently assumed one, this way when the driver changes the
> behavior will not change.
> 
> Signed-off-by: Andrew F. Davis <afd@ti.com>

I fixed up the prefix to use board name, and applied patch #1 ~ #3.

Shawn

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-04-11  2:42 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-29 18:13 [PATCH 1/4] ARM: dts: imx6: RDU2: Use new CODEC reset pin name Andrew F. Davis
2019-03-29 18:13 ` Andrew F. Davis
2019-03-29 18:13 ` [PATCH 2/4] ARM: dts: imx: " Andrew F. Davis
2019-03-29 18:13   ` Andrew F. Davis
2019-03-29 18:13 ` [PATCH 3/4] ARM: dts: imx6qdl: " Andrew F. Davis
2019-03-29 18:13   ` Andrew F. Davis
2019-03-29 18:13 ` [PATCH 4/4] ARM: dts: omap2420-n810: " Andrew F. Davis
2019-03-29 18:13   ` Andrew F. Davis
2019-04-09 15:10   ` Tony Lindgren
2019-04-11  2:42 ` [PATCH 1/4] ARM: dts: imx6: RDU2: " Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.