From: Jean Delvare <jdelvare@suse.de>
To: Eddie James <eajames@linux.ibm.com>
Cc: linux-hwmon@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v2 1/2] hwmon: (occ) Move common code to a separate module
Date: Thu, 11 Apr 2019 13:03:38 +0200 [thread overview]
Message-ID: <20190411130338.4eabeaf8@endymion> (raw)
In-Reply-To: <cc624b5c-f6c5-adb2-7709-f2fc5d851562@linux.ibm.com>
On Wed, 10 Apr 2019 13:02:32 -0500, Eddie James wrote:
> On 4/10/19 5:47 AM, Jean Delvare wrote:
> > Instead of duplicating the common code into the 2 (binary) drivers,
> > move the common code to a separate module. This is cleaner.
> >
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Cc: Eddie James <eajames@linux.ibm.com>
> > Cc: Guenter Roeck <linux@roeck-us.net>
> > ---
> > Eddie, can you please give it a try and confirm it works?
>
>
> Yes, this works well.
>
> Reviewed-by: Eddie James <eajames@linux.ibm.com>
>
> Tested-by: Eddie James <eajames@linux.ibm.com>
Thanks. Can you please send a patch on top of that updating the help
texts in Kconfig to explain that the drivers are for the BMC and not
for the PowerPC host OS, as discussed before?
Thanks,
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2019-04-11 11:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 10:47 [PATCH v2 1/2] hwmon: (occ) Move common code to a separate module Jean Delvare
2019-04-10 10:56 ` [PATCH v2 2/2] hwmon: OCC drivers are ARM-only Jean Delvare
2019-04-10 18:03 ` Eddie James
2019-04-10 18:02 ` [PATCH v2 1/2] hwmon: (occ) Move common code to a separate module Eddie James
2019-04-11 11:03 ` Jean Delvare [this message]
2019-04-10 18:21 ` Guenter Roeck
2019-04-10 18:25 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411130338.4eabeaf8@endymion \
--to=jdelvare@suse.de \
--cc=eajames@linux.ibm.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.