From: Tony Lindgren <tony@atomide.com>
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: Nishanth Menon <nm@ti.com>,
Device Tree Mailing List <devicetree@vger.kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
jason@lakedaemon.net, Peter Ujfalusi <peter.ujfalusi@ti.com>,
Marc Zyngier <marc.zyngier@arm.com>, Sekhar Nori <nsekhar@ti.com>,
linux-kernel@vger.kernel.org, Tero Kristo <t-kristo@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 06/12] dt-bindings: irqchip: Introduce TISCI Interrupt router bindings
Date: Thu, 11 Apr 2019 08:00:23 -0700 [thread overview]
Message-ID: <20190411150023.GQ2839@atomide.com> (raw)
In-Reply-To: <20190410041358.16809-7-lokeshvutla@ti.com>
Hi,
* Lokesh Vutla <lokeshvutla@ti.com> [190410 04:15]:
> +Example:
> +--------
> +The following example demonstrates both interrupt router node and the consumer
> +node(main gpio) on the AM654 SoC:
> +
> +main_intr: interrupt-controller0 {
> + compatible = "ti,sci-intr";
> + ti,intr-trigger-type = <1>;
> + interrupt-controller;
> + interrupt-parent = <&gic500>;
> + #interrupt-cells = <3>;
> + ti,sci = <&dmsc>;
> + ti,sci-dst-id = <56>;
> + ti,sci-rm-range-girq = <0x1>;
> +};
To me it seems there should not be too many of these interrupt
controller nodes for each SoC. Maybe you're already planning on
doing it, but I suggest that you just add more specific compatibles
and then look up the dst-id from a mapping table in the driver
similar to what patch 04/12 in this series is already doing.
That way you don't need to add custom TI specific (firmware
defined) device tree properties listed above ;)
Regards,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>, Nishanth Menon <nm@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
jason@lakedaemon.net,
Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
linux-kernel@vger.kernel.org,
Device Tree Mailing List <devicetree@vger.kernel.org>,
Sekhar Nori <nsekhar@ti.com>, Tero Kristo <t-kristo@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [PATCH v6 06/12] dt-bindings: irqchip: Introduce TISCI Interrupt router bindings
Date: Thu, 11 Apr 2019 08:00:23 -0700 [thread overview]
Message-ID: <20190411150023.GQ2839@atomide.com> (raw)
In-Reply-To: <20190410041358.16809-7-lokeshvutla@ti.com>
Hi,
* Lokesh Vutla <lokeshvutla@ti.com> [190410 04:15]:
> +Example:
> +--------
> +The following example demonstrates both interrupt router node and the consumer
> +node(main gpio) on the AM654 SoC:
> +
> +main_intr: interrupt-controller0 {
> + compatible = "ti,sci-intr";
> + ti,intr-trigger-type = <1>;
> + interrupt-controller;
> + interrupt-parent = <&gic500>;
> + #interrupt-cells = <3>;
> + ti,sci = <&dmsc>;
> + ti,sci-dst-id = <56>;
> + ti,sci-rm-range-girq = <0x1>;
> +};
To me it seems there should not be too many of these interrupt
controller nodes for each SoC. Maybe you're already planning on
doing it, but I suggest that you just add more specific compatibles
and then look up the dst-id from a mapping table in the driver
similar to what patch 04/12 in this series is already doing.
That way you don't need to add custom TI specific (firmware
defined) device tree properties listed above ;)
Regards,
Tony
next prev parent reply other threads:[~2019-04-11 15:00 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 4:13 [PATCH v6 00/12] Add support for TISCI Interrupt controller drivers Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-10 4:13 ` [PATCH v6 01/12] firmware: ti_sci: Add support to get TISCI handle using of_phandle Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-10 4:13 ` [PATCH v6 02/12] firmware: ti_sci: Add support for RM core ops Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-10 4:13 ` [PATCH v6 03/12] firmware: ti_sci: Add support for IRQ management Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-10 4:13 ` [PATCH v6 04/12] firmware: ti_sci: Add RM mapping table for am654 Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-11 14:54 ` Tony Lindgren
2019-04-11 14:54 ` Tony Lindgren
2019-04-12 4:08 ` Lokesh Vutla
2019-04-12 4:08 ` Lokesh Vutla
2019-04-12 4:08 ` Lokesh Vutla
2019-04-12 15:20 ` Tony Lindgren
2019-04-12 15:20 ` Tony Lindgren
2019-04-10 4:13 ` [PATCH v6 05/12] firmware: ti_sci: Add helper apis to manage resources Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-10 4:13 ` [PATCH v6 06/12] dt-bindings: irqchip: Introduce TISCI Interrupt router bindings Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-11 15:00 ` Tony Lindgren [this message]
2019-04-11 15:00 ` Tony Lindgren
2019-04-12 4:24 ` Lokesh Vutla
2019-04-12 4:24 ` Lokesh Vutla
2019-04-12 4:24 ` Lokesh Vutla
2019-04-12 8:42 ` Tero Kristo
2019-04-12 8:42 ` Tero Kristo
2019-04-12 8:42 ` Tero Kristo
2019-04-12 15:33 ` Tony Lindgren
2019-04-12 15:33 ` Tony Lindgren
2019-04-10 4:13 ` [PATCH v6 07/12] irqchip: ti-sci-intr: Add support for Interrupt Router driver Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-10 4:13 ` [PATCH v6 08/12] dt-bindings: irqchip: Introduce TISCI Interrupt Aggregator bindings Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-10 4:13 ` [PATCH v6 09/12] irqchip: ti-sci-inta: Add support for Interrupt Aggregator driver Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-17 11:16 ` Lokesh Vutla
2019-04-17 11:16 ` Lokesh Vutla
2019-04-17 11:16 ` Lokesh Vutla
2019-04-17 14:14 ` Marc Zyngier
2019-04-17 14:14 ` Marc Zyngier
2019-04-17 16:42 ` Lokesh Vutla
2019-04-17 16:42 ` Lokesh Vutla
2019-04-17 16:42 ` Lokesh Vutla
2019-04-10 4:13 ` [PATCH v6 10/12] soc: ti: Add MSI domain bus support for Interrupt Aggregator Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-17 16:34 ` Marc Zyngier
2019-04-17 16:34 ` Marc Zyngier
2019-04-17 16:59 ` Lokesh Vutla
2019-04-17 16:59 ` Lokesh Vutla
2019-04-17 16:59 ` Lokesh Vutla
2019-04-17 17:06 ` Marc Zyngier
2019-04-17 17:06 ` Marc Zyngier
2019-04-17 17:08 ` Lokesh Vutla
2019-04-17 17:08 ` Lokesh Vutla
2019-04-17 17:08 ` Lokesh Vutla
2019-04-10 4:13 ` [PATCH v6 11/12] irqchip: ti-sci-inta: Add msi domain support Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-10 4:13 ` [PATCH v6 12/12] soc: ti: am6: Enable interrupt controller driver Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
2019-04-10 4:13 ` Lokesh Vutla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411150023.GQ2839@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=marc.zyngier@arm.com \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.