From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Matteo Croce <mcroce@redhat.com>
Cc: Robert Richter <rric@kernel.org>,
netdev@vger.kernel.org,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
brouer@redhat.com, Sunil Goutham <sgoutham@cavium.com>,
David Miller <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/2] net: thunderx: raise XDP MTU to 1508
Date: Thu, 11 Apr 2019 15:04:32 +0200 [thread overview]
Message-ID: <20190411150432.72882c56@carbon> (raw)
In-Reply-To: <20190411102633.3685-2-mcroce@redhat.com>
On Thu, 11 Apr 2019 12:26:32 +0200
Matteo Croce <mcroce@redhat.com> wrote:
> The thunderx driver splits frames bigger than 1530 bytes to multiple
> pages, making impossible to run an eBPF program on it.
> This leads to a maximum MTU of 1508 if QinQ is in use.
>
> The thunderx driver forbids to load an eBPF program if the MTU is higher
> than 1500 bytes. Raise the limit to 1508 so it is possible to use L2
> protocols which need some more headroom.
>
> Fixes: 05c773f52b96e ("net: thunderx: Add basic XDP support")
> Signed-off-by: Matteo Croce <mcroce@redhat.com>
> ---
> drivers/net/ethernet/cavium/thunder/nicvf_main.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
LGTM
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Matteo Croce <mcroce@redhat.com>
Cc: netdev@vger.kernel.org, Sunil Goutham <sgoutham@cavium.com>,
Robert Richter <rric@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
David Miller <davem@davemloft.net>,
brouer@redhat.com
Subject: Re: [PATCH v3 1/2] net: thunderx: raise XDP MTU to 1508
Date: Thu, 11 Apr 2019 15:04:32 +0200 [thread overview]
Message-ID: <20190411150432.72882c56@carbon> (raw)
In-Reply-To: <20190411102633.3685-2-mcroce@redhat.com>
On Thu, 11 Apr 2019 12:26:32 +0200
Matteo Croce <mcroce@redhat.com> wrote:
> The thunderx driver splits frames bigger than 1530 bytes to multiple
> pages, making impossible to run an eBPF program on it.
> This leads to a maximum MTU of 1508 if QinQ is in use.
>
> The thunderx driver forbids to load an eBPF program if the MTU is higher
> than 1500 bytes. Raise the limit to 1508 so it is possible to use L2
> protocols which need some more headroom.
>
> Fixes: 05c773f52b96e ("net: thunderx: Add basic XDP support")
> Signed-off-by: Matteo Croce <mcroce@redhat.com>
> ---
> drivers/net/ethernet/cavium/thunder/nicvf_main.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
LGTM
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-04-11 13:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 10:26 [PATCH v3 0/2] Fix thunderx MTU with XDP Matteo Croce
2019-04-11 10:26 ` Matteo Croce
2019-04-11 10:26 ` [PATCH v3 1/2] net: thunderx: raise XDP MTU to 1508 Matteo Croce
2019-04-11 10:26 ` Matteo Croce
2019-04-11 13:04 ` Jesper Dangaard Brouer [this message]
2019-04-11 13:04 ` Jesper Dangaard Brouer
2019-04-11 10:26 ` [PATCH v3 2/2] net: thunderx: don't allow jumbo frames with XDP Matteo Croce
2019-04-11 10:26 ` Matteo Croce
2019-04-11 13:05 ` Jesper Dangaard Brouer
2019-04-11 13:05 ` Jesper Dangaard Brouer
2019-04-11 18:11 ` [PATCH v3 0/2] Fix thunderx MTU " David Miller
2019-04-11 18:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411150432.72882c56@carbon \
--to=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=ilias.apalodimas@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rric@kernel.org \
--cc=sgoutham@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.