From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Song Liu <liu.song.a23@gmail.com>
Cc: Networking <netdev@vger.kernel.org>,
"Daniel Borkmann" <borkmann@iogearbox.net>,
"Alexei Starovoitov" <alexei.starovoitov@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
bpf <bpf@vger.kernel.org>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
brouer@redhat.com, "Edward Cree" <ecree@solarflare.com>
Subject: Re: [PATCH bpf-next 0/5] Bulk optimization for XDP cpumap redirect
Date: Thu, 11 Apr 2019 15:18:43 +0200 [thread overview]
Message-ID: <20190411151843.197dfd41@carbon> (raw)
In-Reply-To: <CAPhsuW7yYqJwsrk2s5EaZOjhhxa5B0374vJGR4+BBKmh8UCQWg@mail.gmail.com>
On Wed, 10 Apr 2019 16:36:40 -0700
Song Liu <liu.song.a23@gmail.com> wrote:
> On Wed, Apr 10, 2019 at 6:00 AM Jesper Dangaard Brouer
> <brouer@redhat.com> wrote:
> >
> > This patchset utilize a number of different kernel bulk APIs for optimizing
> > the performance for the XDP cpumap redirect feature.
>
> Could you please share some numbers about the optimization?
I've documented ALL the details here:
https://github.com/xdp-project/xdp-project/blob/master/areas/cpumap/cpumap02-optimizations.org
I seem to have found that the SKB-list approach is not a performance
advantage, which is very surprising. BUT it might still be due to
invalid benchmarking, as I found that F27 behind my back is auto-loading
iptables-filter modules, which change performance. Thus, I have to
redo a lot of the tests...
I'm considering removing the SKB-list patch from the patchset, as all
other patches show a performance increase/improvement. Then we can
merge that, and then I can focus on SKB-list approach in another
patchset. BUT as I said above, I might have wrong/invalid
measurements... I have to retest before I concluded anything...
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-04-11 13:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 11:43 [PATCH bpf-next 0/5] Bulk optimization for XDP cpumap redirect Jesper Dangaard Brouer
2019-04-10 11:43 ` [PATCH bpf-next 1/5] bpf: cpumap use ptr_ring_consume_batched Jesper Dangaard Brouer
2019-04-10 23:24 ` Song Liu
2019-04-11 11:23 ` Jesper Dangaard Brouer
2019-04-11 17:38 ` Song Liu
2019-04-10 11:43 ` [PATCH bpf-next 2/5] bpf: cpumap use netif_receive_skb_list Jesper Dangaard Brouer
2019-04-10 18:56 ` Edward Cree
2019-04-10 11:43 ` [PATCH bpf-next 3/5] net: core: introduce build_skb_around Jesper Dangaard Brouer
2019-04-10 23:34 ` Song Liu
2019-04-11 15:39 ` Jesper Dangaard Brouer
2019-04-11 17:43 ` Song Liu
2019-04-11 5:33 ` Ilias Apalodimas
2019-04-11 11:17 ` Jesper Dangaard Brouer
2019-04-10 11:43 ` [PATCH bpf-next 4/5] bpf: cpumap do bulk allocation of SKBs Jesper Dangaard Brouer
2019-04-10 23:30 ` Song Liu
2019-04-10 11:43 ` [PATCH bpf-next 5/5] bpf: cpumap memory prefetchw optimizations for struct page Jesper Dangaard Brouer
2019-04-10 23:35 ` Song Liu
2019-04-11 5:47 ` Ilias Apalodimas
2019-04-10 23:36 ` [PATCH bpf-next 0/5] Bulk optimization for XDP cpumap redirect Song Liu
2019-04-11 13:18 ` Jesper Dangaard Brouer [this message]
2019-04-11 17:45 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411151843.197dfd41@carbon \
--to=brouer@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=borkmann@iogearbox.net \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=ilias.apalodimas@linaro.org \
--cc=liu.song.a23@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.