From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Song Liu <liu.song.a23@gmail.com>
Cc: Networking <netdev@vger.kernel.org>,
"Daniel Borkmann" <borkmann@iogearbox.net>,
"Alexei Starovoitov" <alexei.starovoitov@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
bpf <bpf@vger.kernel.org>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
brouer@redhat.com
Subject: Re: [PATCH bpf-next 3/5] net: core: introduce build_skb_around
Date: Thu, 11 Apr 2019 17:39:30 +0200 [thread overview]
Message-ID: <20190411173930.51fec773@carbon> (raw)
In-Reply-To: <CAPhsuW6K+TVaAuD3e6g7oE9zhpBAVx5u3V4NZJgH9E0qM2_ZDg@mail.gmail.com>
On Wed, 10 Apr 2019 16:34:29 -0700
Song Liu <liu.song.a23@gmail.com> wrote:
> > +struct sk_buff *build_skb_around(struct sk_buff *skb,
> > + void *data, unsigned int frag_size)
> > +{
> > + if (unlikely(!skb))
> > + return NULL;
> > +
> > + skb = __build_skb_around(skb, data, frag_size);
>
>
> > +
> > + if (skb && frag_size) {
> > + skb->head_frag = 1;
> > + if (page_is_pfmemalloc(virt_to_head_page(data)))
> > + skb->pfmemalloc = 1;
> > + }
>
> I didn't find any explanation of this part (head_frag, pfmemalloc).
> Shall we split it out to a separate patch?
No, it belongs here. This is like/based on the __build_skb() and
build_skb() split, and needed such that __build_skb() can reuse the
code in __build_skb_around().
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-04-11 15:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 11:43 [PATCH bpf-next 0/5] Bulk optimization for XDP cpumap redirect Jesper Dangaard Brouer
2019-04-10 11:43 ` [PATCH bpf-next 1/5] bpf: cpumap use ptr_ring_consume_batched Jesper Dangaard Brouer
2019-04-10 23:24 ` Song Liu
2019-04-11 11:23 ` Jesper Dangaard Brouer
2019-04-11 17:38 ` Song Liu
2019-04-10 11:43 ` [PATCH bpf-next 2/5] bpf: cpumap use netif_receive_skb_list Jesper Dangaard Brouer
2019-04-10 18:56 ` Edward Cree
2019-04-10 11:43 ` [PATCH bpf-next 3/5] net: core: introduce build_skb_around Jesper Dangaard Brouer
2019-04-10 23:34 ` Song Liu
2019-04-11 15:39 ` Jesper Dangaard Brouer [this message]
2019-04-11 17:43 ` Song Liu
2019-04-11 5:33 ` Ilias Apalodimas
2019-04-11 11:17 ` Jesper Dangaard Brouer
2019-04-10 11:43 ` [PATCH bpf-next 4/5] bpf: cpumap do bulk allocation of SKBs Jesper Dangaard Brouer
2019-04-10 23:30 ` Song Liu
2019-04-10 11:43 ` [PATCH bpf-next 5/5] bpf: cpumap memory prefetchw optimizations for struct page Jesper Dangaard Brouer
2019-04-10 23:35 ` Song Liu
2019-04-11 5:47 ` Ilias Apalodimas
2019-04-10 23:36 ` [PATCH bpf-next 0/5] Bulk optimization for XDP cpumap redirect Song Liu
2019-04-11 13:18 ` Jesper Dangaard Brouer
2019-04-11 17:45 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411173930.51fec773@carbon \
--to=brouer@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=borkmann@iogearbox.net \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=ilias.apalodimas@linaro.org \
--cc=liu.song.a23@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.