All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] nvme: pci: Fix queue_count parameter
@ 2019-04-11 15:51 Minwoo Im
  2019-04-11 15:54 ` Minwoo Im
  0 siblings, 1 reply; 4+ messages in thread
From: Minwoo Im @ 2019-04-11 15:51 UTC (permalink / raw)


The first patch will make it return an error if given value is larger
than number of possible cpus.  It has not been doing anything about it.

The second patch is just a nit for clean-up of local variable.  It does
not need to be initialized in this scope because kstrtoint() will return
an error if it fails without referring local variable after it.

Minwoo Im (2):
  nvme: pci: Return -EINVAL if given nr_queue larger than nr_cpu
  nvme: pci: Do not initialize local_var

 drivers/nvme/host/pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.17.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 0/2] nvme: pci: Fix queue_count parameter
@ 2019-04-11 15:52 ` Minwoo Im
  2019-04-15 22:30   ` Minwoo Im
  0 siblings, 1 reply; 4+ messages in thread
From: Minwoo Im @ 2019-04-11 15:52 UTC (permalink / raw)


The first patch will make it return an error if given value is larger
than number of possible cpus.  It has not been doing anything about it.

The second patch is just a nit for clean-up of local variable.  It does
not need to be initialized in this scope because kstrtoint() will return
an error if it fails without referring local variable after it.

It has been reported:
	http://lists.infradead.org/pipermail/linux-nvme/2019-April/023333.html

Minwoo Im (2):
  nvme: pci: Return -EINVAL if given nr_queue larger than nr_cpu
  nvme: pci: Do not initialize local_var

 drivers/nvme/host/pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.17.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 0/2] nvme: pci: Fix queue_count parameter
  2019-04-11 15:51 [PATCH 0/2] nvme: pci: Fix queue_count parameter Minwoo Im
@ 2019-04-11 15:54 ` Minwoo Im
  0 siblings, 0 replies; 4+ messages in thread
From: Minwoo Im @ 2019-04-11 15:54 UTC (permalink / raw)


On 4/12/19 12:51 AM, Minwoo Im wrote:
> The first patch will make it return an error if given value is larger
> than number of possible cpus.  It has not been doing anything about it.
> 
> The second patch is just a nit for clean-up of local variable.  It does
> not need to be initialized in this scope because kstrtoint() will return
> an error if it fails without referring local variable after it.
> 
> Minwoo Im (2):
>    nvme: pci: Return -EINVAL if given nr_queue larger than nr_cpu
>    nvme: pci: Do not initialize local_var
> 
>   drivers/nvme/host/pci.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 

Please ignore this cover letter because it does not have any URL from
where it has been reported.

Thanks,

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 0/2] nvme: pci: Fix queue_count parameter
  2019-04-11 15:52 ` Minwoo Im
@ 2019-04-15 22:30   ` Minwoo Im
  0 siblings, 0 replies; 4+ messages in thread
From: Minwoo Im @ 2019-04-15 22:30 UTC (permalink / raw)




> -----Original Message-----
> From: Linux-nvme [mailto:linux-nvme-bounces at lists.infradead.org] On Behalf
> Of Minwoo Im
> Sent: Friday, April 12, 2019 12:53 AM
> To: linux-nvme at lists.infradead.org
> Cc: Keith Busch; Jens Axboe; Minwoo Im; Christoph Hellwig; Sagi Grimberg
> Subject: [PATCH 0/2] nvme: pci: Fix queue_count parameter
> 
> The first patch will make it return an error if given value is larger
> than number of possible cpus.  It has not been doing anything about it.
> 
> The second patch is just a nit for clean-up of local variable.  It does
> not need to be initialized in this scope because kstrtoint() will return
> an error if it fails without referring local variable after it.
> 
> It has been reported:
> 	http://lists.infradead.org/pipermail/linux-nvme/2019-April/023333.html
> 

Jens, 

Could you please have a look at this? I think it might fix
commit 3b6592f70("nvme: utilize two queue maps, one for reads and one for writes").

Thanks,

> Minwoo Im (2):
>   nvme: pci: Return -EINVAL if given nr_queue larger than nr_cpu
>   nvme: pci: Do not initialize local_var
> 
>  drivers/nvme/host/pci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --
> 2.17.1
> 
> 
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-04-15 22:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-11 15:51 [PATCH 0/2] nvme: pci: Fix queue_count parameter Minwoo Im
2019-04-11 15:54 ` Minwoo Im
     [not found] <CGME20190411155300epcas5p49adfec0820281f7c3fd918ba59d9cf7d@epcms2p1>
2019-04-11 15:52 ` Minwoo Im
2019-04-15 22:30   ` Minwoo Im

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.