* [Qemu-devel] [PATCH for-QEMU-4.1] Declare -realtime as deprecated
@ 2019-04-11 17:53 ` Thomas Huth
0 siblings, 0 replies; 10+ messages in thread
From: Thomas Huth @ 2019-04-11 17:53 UTC (permalink / raw)
To: qemu-devel, Michael S . Tsirkin
Cc: Paolo Bonzini, libvir-list, Eduardo Habkost
The old -realtime mlock=on|off parameter does exactly the same as the
new -overcommit mem-lock=on|off parameter. Additionally, "-realtime"
does not activate any additional "realtime" capabilities as the name
might indicate. We should avoid to confuse the users this way, so
let's deprecate the old -realtime option.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
Deprecation has already been suggested last year:
https://patchwork.kernel.org/patch/10480963/#22026215
... but apparently we forgot to really do it.
qemu-deprecated.texi | 5 +++++
vl.c | 2 ++
2 files changed, 7 insertions(+)
diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
index 2219386769..2c45204f3f 100644
--- a/qemu-deprecated.texi
+++ b/qemu-deprecated.texi
@@ -72,6 +72,11 @@ backend settings instead of environment variables. To ease migration to
the new format, the ``-audiodev-help'' option can be used to convert
the current values of the environment variables to ``-audiodev'' options.
+@subsection -realtime (since 4.1)
+
+The @code{-realtime mlock=on|off} argument has been replaced by the
+@code{-overcommit mem-lock=on|off} argument.
+
@section QEMU Machine Protocol (QMP) commands
@subsection block-dirty-bitmap-add "autoload" parameter (since 2.12.0)
diff --git a/vl.c b/vl.c
index c696ad2a13..d6a2779b70 100644
--- a/vl.c
+++ b/vl.c
@@ -3912,6 +3912,8 @@ int main(int argc, char **argv, char **envp)
}
break;
case QEMU_OPTION_realtime:
+ warn_report("'-realtime mlock=...' is deprecated, please use "
+ "'-overcommit mem-lock=...' instead");
opts = qemu_opts_parse_noisily(qemu_find_opts("realtime"),
optarg, false);
if (!opts) {
--
2.21.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Qemu-devel] [PATCH for-QEMU-4.1] Declare -realtime as deprecated
@ 2019-04-11 17:53 ` Thomas Huth
0 siblings, 0 replies; 10+ messages in thread
From: Thomas Huth @ 2019-04-11 17:53 UTC (permalink / raw)
To: qemu-devel, Michael S . Tsirkin
Cc: libvir-list, Paolo Bonzini, Eduardo Habkost
The old -realtime mlock=on|off parameter does exactly the same as the
new -overcommit mem-lock=on|off parameter. Additionally, "-realtime"
does not activate any additional "realtime" capabilities as the name
might indicate. We should avoid to confuse the users this way, so
let's deprecate the old -realtime option.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
Deprecation has already been suggested last year:
https://patchwork.kernel.org/patch/10480963/#22026215
... but apparently we forgot to really do it.
qemu-deprecated.texi | 5 +++++
vl.c | 2 ++
2 files changed, 7 insertions(+)
diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
index 2219386769..2c45204f3f 100644
--- a/qemu-deprecated.texi
+++ b/qemu-deprecated.texi
@@ -72,6 +72,11 @@ backend settings instead of environment variables. To ease migration to
the new format, the ``-audiodev-help'' option can be used to convert
the current values of the environment variables to ``-audiodev'' options.
+@subsection -realtime (since 4.1)
+
+The @code{-realtime mlock=on|off} argument has been replaced by the
+@code{-overcommit mem-lock=on|off} argument.
+
@section QEMU Machine Protocol (QMP) commands
@subsection block-dirty-bitmap-add "autoload" parameter (since 2.12.0)
diff --git a/vl.c b/vl.c
index c696ad2a13..d6a2779b70 100644
--- a/vl.c
+++ b/vl.c
@@ -3912,6 +3912,8 @@ int main(int argc, char **argv, char **envp)
}
break;
case QEMU_OPTION_realtime:
+ warn_report("'-realtime mlock=...' is deprecated, please use "
+ "'-overcommit mem-lock=...' instead");
opts = qemu_opts_parse_noisily(qemu_find_opts("realtime"),
optarg, false);
if (!opts) {
--
2.21.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [libvirt] [PATCH for-QEMU-4.1] Declare -realtime as deprecated
@ 2019-04-11 18:03 ` Daniel P. Berrangé
0 siblings, 0 replies; 10+ messages in thread
From: Daniel P. Berrangé @ 2019-04-11 18:03 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, Michael S . Tsirkin, libvir-list, Paolo Bonzini,
Eduardo Habkost
On Thu, Apr 11, 2019 at 07:53:45PM +0200, Thomas Huth wrote:
> The old -realtime mlock=on|off parameter does exactly the same as the
> new -overcommit mem-lock=on|off parameter. Additionally, "-realtime"
> does not activate any additional "realtime" capabilities as the name
> might indicate. We should avoid to confuse the users this way, so
> let's deprecate the old -realtime option.
FYI libvirt currently uses -realtime mlock=on so will need adapting
to cope with this change.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> Deprecation has already been suggested last year:
> https://patchwork.kernel.org/patch/10480963/#22026215
> ... but apparently we forgot to really do it.
>
> qemu-deprecated.texi | 5 +++++
> vl.c | 2 ++
> 2 files changed, 7 insertions(+)
>
> diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
> index 2219386769..2c45204f3f 100644
> --- a/qemu-deprecated.texi
> +++ b/qemu-deprecated.texi
> @@ -72,6 +72,11 @@ backend settings instead of environment variables. To ease migration to
> the new format, the ``-audiodev-help'' option can be used to convert
> the current values of the environment variables to ``-audiodev'' options.
>
> +@subsection -realtime (since 4.1)
> +
> +The @code{-realtime mlock=on|off} argument has been replaced by the
> +@code{-overcommit mem-lock=on|off} argument.
> +
> @section QEMU Machine Protocol (QMP) commands
>
> @subsection block-dirty-bitmap-add "autoload" parameter (since 2.12.0)
> diff --git a/vl.c b/vl.c
> index c696ad2a13..d6a2779b70 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3912,6 +3912,8 @@ int main(int argc, char **argv, char **envp)
> }
> break;
> case QEMU_OPTION_realtime:
> + warn_report("'-realtime mlock=...' is deprecated, please use "
> + "'-overcommit mem-lock=...' instead");
> opts = qemu_opts_parse_noisily(qemu_find_opts("realtime"),
> optarg, false);
> if (!opts) {
> --
> 2.21.0
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [libvirt] [PATCH for-QEMU-4.1] Declare -realtime as deprecated
@ 2019-04-11 18:03 ` Daniel P. Berrangé
0 siblings, 0 replies; 10+ messages in thread
From: Daniel P. Berrangé @ 2019-04-11 18:03 UTC (permalink / raw)
To: Thomas Huth
Cc: libvir-list, Paolo Bonzini, qemu-devel, Eduardo Habkost,
Michael S . Tsirkin
On Thu, Apr 11, 2019 at 07:53:45PM +0200, Thomas Huth wrote:
> The old -realtime mlock=on|off parameter does exactly the same as the
> new -overcommit mem-lock=on|off parameter. Additionally, "-realtime"
> does not activate any additional "realtime" capabilities as the name
> might indicate. We should avoid to confuse the users this way, so
> let's deprecate the old -realtime option.
FYI libvirt currently uses -realtime mlock=on so will need adapting
to cope with this change.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> Deprecation has already been suggested last year:
> https://patchwork.kernel.org/patch/10480963/#22026215
> ... but apparently we forgot to really do it.
>
> qemu-deprecated.texi | 5 +++++
> vl.c | 2 ++
> 2 files changed, 7 insertions(+)
>
> diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
> index 2219386769..2c45204f3f 100644
> --- a/qemu-deprecated.texi
> +++ b/qemu-deprecated.texi
> @@ -72,6 +72,11 @@ backend settings instead of environment variables. To ease migration to
> the new format, the ``-audiodev-help'' option can be used to convert
> the current values of the environment variables to ``-audiodev'' options.
>
> +@subsection -realtime (since 4.1)
> +
> +The @code{-realtime mlock=on|off} argument has been replaced by the
> +@code{-overcommit mem-lock=on|off} argument.
> +
> @section QEMU Machine Protocol (QMP) commands
>
> @subsection block-dirty-bitmap-add "autoload" parameter (since 2.12.0)
> diff --git a/vl.c b/vl.c
> index c696ad2a13..d6a2779b70 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3912,6 +3912,8 @@ int main(int argc, char **argv, char **envp)
> }
> break;
> case QEMU_OPTION_realtime:
> + warn_report("'-realtime mlock=...' is deprecated, please use "
> + "'-overcommit mem-lock=...' instead");
> opts = qemu_opts_parse_noisily(qemu_find_opts("realtime"),
> optarg, false);
> if (!opts) {
> --
> 2.21.0
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [libvirt] [PATCH for-QEMU-4.1] Declare -realtime as deprecated
@ 2019-04-12 12:29 ` Michal Privoznik
0 siblings, 0 replies; 10+ messages in thread
From: Michal Privoznik @ 2019-04-12 12:29 UTC (permalink / raw)
To: Daniel P. Berrangé, Thomas Huth
Cc: libvir-list, Paolo Bonzini, qemu-devel, Eduardo Habkost,
Michael S . Tsirkin
On 4/11/19 8:03 PM, Daniel P. Berrangé wrote:
> On Thu, Apr 11, 2019 at 07:53:45PM +0200, Thomas Huth wrote:
>> The old -realtime mlock=on|off parameter does exactly the same as the
>> new -overcommit mem-lock=on|off parameter. Additionally, "-realtime"
>> does not activate any additional "realtime" capabilities as the name
>> might indicate. We should avoid to confuse the users this way, so
>> let's deprecate the old -realtime option.
>
> FYI libvirt currently uses -realtime mlock=on so will need adapting
> to cope with this change.
Done:
e8c2c8bd07 qemu_command: Prefer '-overcommit mem-lock' over -realtime mlock'
be51feff69 qemu_capabilities: Introduce QEMU_CAPS_OVERCOMMIT
a08c4b3741 qemu: Always assume QEMU_CAPS_REALTIME_MLOCK
Therefore, from libvirt's POV this patch is okay to go in.
Michal
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [libvirt] [PATCH for-QEMU-4.1] Declare -realtime as deprecated
@ 2019-04-12 12:29 ` Michal Privoznik
0 siblings, 0 replies; 10+ messages in thread
From: Michal Privoznik @ 2019-04-12 12:29 UTC (permalink / raw)
To: Daniel P. Berrangé, Thomas Huth
Cc: libvir-list, Paolo Bonzini, Michael S . Tsirkin, qemu-devel,
Eduardo Habkost
On 4/11/19 8:03 PM, Daniel P. Berrangé wrote:
> On Thu, Apr 11, 2019 at 07:53:45PM +0200, Thomas Huth wrote:
>> The old -realtime mlock=on|off parameter does exactly the same as the
>> new -overcommit mem-lock=on|off parameter. Additionally, "-realtime"
>> does not activate any additional "realtime" capabilities as the name
>> might indicate. We should avoid to confuse the users this way, so
>> let's deprecate the old -realtime option.
>
> FYI libvirt currently uses -realtime mlock=on so will need adapting
> to cope with this change.
Done:
e8c2c8bd07 qemu_command: Prefer '-overcommit mem-lock' over -realtime mlock'
be51feff69 qemu_capabilities: Introduce QEMU_CAPS_OVERCOMMIT
a08c4b3741 qemu: Always assume QEMU_CAPS_REALTIME_MLOCK
Therefore, from libvirt's POV this patch is okay to go in.
Michal
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH for-QEMU-4.1] Declare -realtime as deprecated
@ 2019-04-12 18:36 ` Eduardo Habkost
0 siblings, 0 replies; 10+ messages in thread
From: Eduardo Habkost @ 2019-04-12 18:36 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-devel, Michael S . Tsirkin, libvir-list, Paolo Bonzini
On Thu, Apr 11, 2019 at 07:53:45PM +0200, Thomas Huth wrote:
> The old -realtime mlock=on|off parameter does exactly the same as the
> new -overcommit mem-lock=on|off parameter. Additionally, "-realtime"
> does not activate any additional "realtime" capabilities as the name
> might indicate. We should avoid to confuse the users this way, so
> let's deprecate the old -realtime option.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Paolo, do you want to queue this, or should I do it through the
machine queue?
--
Eduardo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH for-QEMU-4.1] Declare -realtime as deprecated
@ 2019-04-12 18:36 ` Eduardo Habkost
0 siblings, 0 replies; 10+ messages in thread
From: Eduardo Habkost @ 2019-04-12 18:36 UTC (permalink / raw)
To: Thomas Huth; +Cc: libvir-list, Paolo Bonzini, qemu-devel, Michael S . Tsirkin
On Thu, Apr 11, 2019 at 07:53:45PM +0200, Thomas Huth wrote:
> The old -realtime mlock=on|off parameter does exactly the same as the
> new -overcommit mem-lock=on|off parameter. Additionally, "-realtime"
> does not activate any additional "realtime" capabilities as the name
> might indicate. We should avoid to confuse the users this way, so
> let's deprecate the old -realtime option.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Paolo, do you want to queue this, or should I do it through the
machine queue?
--
Eduardo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH for-QEMU-4.1] Declare -realtime as deprecated
@ 2019-04-15 10:56 ` Paolo Bonzini
0 siblings, 0 replies; 10+ messages in thread
From: Paolo Bonzini @ 2019-04-15 10:56 UTC (permalink / raw)
To: Eduardo Habkost, Thomas Huth; +Cc: qemu-devel, Michael S . Tsirkin, libvir-list
On 12/04/19 20:36, Eduardo Habkost wrote:
>> let's deprecate the old -realtime option.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
>
> Paolo, do you want to queue this, or should I do it through the
> machine queue?
>
> -- Eduardo
I have just queued it.
Paolo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH for-QEMU-4.1] Declare -realtime as deprecated
@ 2019-04-15 10:56 ` Paolo Bonzini
0 siblings, 0 replies; 10+ messages in thread
From: Paolo Bonzini @ 2019-04-15 10:56 UTC (permalink / raw)
To: Eduardo Habkost, Thomas Huth; +Cc: libvir-list, qemu-devel, Michael S . Tsirkin
On 12/04/19 20:36, Eduardo Habkost wrote:
>> let's deprecate the old -realtime option.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
>
> Paolo, do you want to queue this, or should I do it through the
> machine queue?
>
> -- Eduardo
I have just queued it.
Paolo
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-04-15 10:57 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-11 17:53 [Qemu-devel] [PATCH for-QEMU-4.1] Declare -realtime as deprecated Thomas Huth
2019-04-11 17:53 ` Thomas Huth
2019-04-11 18:03 ` [Qemu-devel] [libvirt] " Daniel P. Berrangé
2019-04-11 18:03 ` Daniel P. Berrangé
2019-04-12 12:29 ` Michal Privoznik
2019-04-12 12:29 ` Michal Privoznik
2019-04-12 18:36 ` [Qemu-devel] " Eduardo Habkost
2019-04-12 18:36 ` Eduardo Habkost
2019-04-15 10:56 ` Paolo Bonzini
2019-04-15 10:56 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.