* [PATCH v1] rtc: rx8025: Fix a parameter to %ptR in rx8025_read_alarm()
@ 2019-04-10 14:05 Andy Shevchenko
2019-04-12 8:33 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2019-04-10 14:05 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, linux-rtc, Dan Carpenter
Cc: Andy Shevchenko
The commit 1921cab11723 ("rtc: rx8025: Switch to use %ptR") converted
the driver to use new %p extension, but actually used wrong type of
the parameter in one case.
Fix a parameter to %ptR in rx8025_read_alarm().
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/rtc/rtc-rx8025.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-rx8025.c b/drivers/rtc/rtc-rx8025.c
index 41de38acc570..fddc996cb38d 100644
--- a/drivers/rtc/rtc-rx8025.c
+++ b/drivers/rtc/rtc-rx8025.c
@@ -311,7 +311,7 @@ static int rx8025_read_alarm(struct device *dev, struct rtc_wkalrm *t)
t->time.tm_hour = bcd2bin(ald[1] & 0x1f) % 12
+ (ald[1] & 0x20 ? 12 : 0);
- dev_dbg(dev, "%s: date: %ptRr\n", __func__, t);
+ dev_dbg(dev, "%s: date: %ptRr\n", __func__, &t->time);
t->enabled = !!(rx8025->ctrl1 & RX8025_BIT_CTRL1_DALE);
t->pending = (ctrl2 & RX8025_BIT_CTRL2_DAFG) && t->enabled;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1] rtc: rx8025: Fix a parameter to %ptR in rx8025_read_alarm()
2019-04-10 14:05 [PATCH v1] rtc: rx8025: Fix a parameter to %ptR in rx8025_read_alarm() Andy Shevchenko
@ 2019-04-12 8:33 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2019-04-12 8:33 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Alessandro Zummo, linux-rtc, Dan Carpenter
On 10/04/2019 17:05:59+0300, Andy Shevchenko wrote:
> The commit 1921cab11723 ("rtc: rx8025: Switch to use %ptR") converted
> the driver to use new %p extension, but actually used wrong type of
> the parameter in one case.
>
> Fix a parameter to %ptR in rx8025_read_alarm().
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/rtc/rtc-rx8025.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-12 8:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-10 14:05 [PATCH v1] rtc: rx8025: Fix a parameter to %ptR in rx8025_read_alarm() Andy Shevchenko
2019-04-12 8:33 ` Alexandre Belloni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.