From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Richard Cochran <richardcochran@gmail.com>,
linux-rockchip@lists.infradead.org, netdev@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org,
David Miller <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 net-next] net: phy: switch drivers to use dynamic feature detection
Date: Sat, 13 Apr 2019 00:47:37 +0200 [thread overview]
Message-ID: <20190412224737.GA1004@lunn.ch> (raw)
In-Reply-To: <3179601a-c58d-4df3-5d90-eb3598d2827b@gmail.com>
On Fri, Apr 12, 2019 at 08:47:03PM +0200, Heiner Kallweit wrote:
> Recently genphy_read_abilities() has been added that dynamically detects
> clause 22 PHY abilities. I *think* this detection should work with all
> supported PHY's, at least for the ones with basic features sets, i.e.
> PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these
> features explicitly and rely on phylib feature detection.
>
> I don't have access to most of these PHY's, therefore I'd appreciate
> regression testing.
Hi Heiner
I tested v1 on the following PHYs:
88E1510, 88E1540, 88E6390, KSZ8041, 88E1545
No obvious regressions.
Tested-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Richard Cochran <richardcochran@gmail.com>,
Kevin Hilman <khilman@baylibre.com>,
Heiko Stuebner <heiko@sntech.de>,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 net-next] net: phy: switch drivers to use dynamic feature detection
Date: Sat, 13 Apr 2019 00:47:37 +0200 [thread overview]
Message-ID: <20190412224737.GA1004@lunn.ch> (raw)
In-Reply-To: <3179601a-c58d-4df3-5d90-eb3598d2827b@gmail.com>
On Fri, Apr 12, 2019 at 08:47:03PM +0200, Heiner Kallweit wrote:
> Recently genphy_read_abilities() has been added that dynamically detects
> clause 22 PHY abilities. I *think* this detection should work with all
> supported PHY's, at least for the ones with basic features sets, i.e.
> PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these
> features explicitly and rely on phylib feature detection.
>
> I don't have access to most of these PHY's, therefore I'd appreciate
> regression testing.
Hi Heiner
I tested v1 on the following PHYs:
88E1510, 88E1540, 88E6390, KSZ8041, 88E1545
No obvious regressions.
Tested-by: Andrew Lunn <andrew@lunn.ch>
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Richard Cochran <richardcochran@gmail.com>,
linux-rockchip@lists.infradead.org, netdev@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org,
David Miller <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 net-next] net: phy: switch drivers to use dynamic feature detection
Date: Sat, 13 Apr 2019 00:47:37 +0200 [thread overview]
Message-ID: <20190412224737.GA1004@lunn.ch> (raw)
In-Reply-To: <3179601a-c58d-4df3-5d90-eb3598d2827b@gmail.com>
On Fri, Apr 12, 2019 at 08:47:03PM +0200, Heiner Kallweit wrote:
> Recently genphy_read_abilities() has been added that dynamically detects
> clause 22 PHY abilities. I *think* this detection should work with all
> supported PHY's, at least for the ones with basic features sets, i.e.
> PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these
> features explicitly and rely on phylib feature detection.
>
> I don't have access to most of these PHY's, therefore I'd appreciate
> regression testing.
Hi Heiner
I tested v1 on the following PHYs:
88E1510, 88E1540, 88E6390, KSZ8041, 88E1545
No obvious regressions.
Tested-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-12 22:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 18:47 [PATCH v2 net-next] net: phy: switch drivers to use dynamic feature detection Heiner Kallweit
2019-04-12 18:47 ` Heiner Kallweit
2019-04-12 18:47 ` Heiner Kallweit
2019-04-12 22:47 ` Andrew Lunn [this message]
2019-04-12 22:47 ` Andrew Lunn
2019-04-12 22:47 ` Andrew Lunn
2019-04-16 0:20 ` David Miller
2019-04-16 0:20 ` David Miller
2019-04-16 0:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412224737.GA1004@lunn.ch \
--to=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=heiko@sntech.de \
--cc=hkallweit1@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.