From: Christoph Hellwig <hch@infradead.org>
To: Anup Patel <Anup.Patel@wdc.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>,
Palmer Dabbelt <palmer@sifive.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Atish Patra <Atish.Patra@wdc.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH 1/3] RISC-V: Add separate asm/encoding.h for spec related defines
Date: Sat, 13 Apr 2019 00:53:55 -0700 [thread overview]
Message-ID: <20190413075355.GA30428@infradead.org> (raw)
In-Reply-To: <20190413073906.53676-2-anup.patel@wdc.com>
On Sat, Apr 13, 2019 at 07:39:35AM +0000, Anup Patel wrote:
> It's better to have all RISC-V spec related defines in one place
> so this patch adds separate asm/encoding.h for such defines which
> can be included in assembly as well as C code.
<asm/csr.h> can be included from assembly just fine already.
and we already do that. So I don't really see much of a point
in splitting it.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Anup Patel <Anup.Patel@wdc.com>
Cc: Palmer Dabbelt <palmer@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Atish Patra <Atish.Patra@wdc.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH 1/3] RISC-V: Add separate asm/encoding.h for spec related defines
Date: Sat, 13 Apr 2019 00:53:55 -0700 [thread overview]
Message-ID: <20190413075355.GA30428@infradead.org> (raw)
In-Reply-To: <20190413073906.53676-2-anup.patel@wdc.com>
On Sat, Apr 13, 2019 at 07:39:35AM +0000, Anup Patel wrote:
> It's better to have all RISC-V spec related defines in one place
> so this patch adds separate asm/encoding.h for such defines which
> can be included in assembly as well as C code.
<asm/csr.h> can be included from assembly just fine already.
and we already do that. So I don't really see much of a point
in splitting it.
next prev parent reply other threads:[~2019-04-13 7:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-13 7:39 [PATCH 0/3] Allow accessing CSR using CSR number Anup Patel
2019-04-13 7:39 ` Anup Patel
2019-04-13 7:39 ` [PATCH 1/3] RISC-V: Add separate asm/encoding.h for spec related defines Anup Patel
2019-04-13 7:39 ` Anup Patel
2019-04-13 7:53 ` Christoph Hellwig [this message]
2019-04-13 7:53 ` Christoph Hellwig
2019-04-13 8:14 ` Anup Patel
2019-04-13 8:14 ` Anup Patel
2019-04-13 7:39 ` [PATCH 2/3] RISC-V: Add defines for CSR numbers Anup Patel
2019-04-13 7:39 ` Anup Patel
2019-04-13 7:54 ` Christoph Hellwig
2019-04-13 7:54 ` Christoph Hellwig
2019-04-13 8:14 ` Anup Patel
2019-04-13 8:14 ` Anup Patel
2019-04-13 7:39 ` [PATCH 3/3] RISC-V: Access CSRs using " Anup Patel
2019-04-13 7:39 ` Anup Patel
2019-04-13 7:55 ` Christoph Hellwig
2019-04-13 7:55 ` Christoph Hellwig
2019-04-13 8:15 ` Anup Patel
2019-04-13 8:15 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190413075355.GA30428@infradead.org \
--to=hch@infradead.org \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.