From: Samuel Thibault <samuel.thibault@gnu.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Bandan Das <bsd@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] vl: set LC_MESSAGES and LC_CTYPE in main for all code
Date: Mon, 15 Apr 2019 13:38:43 +0200 [thread overview]
Message-ID: <20190415113843.pcagpvrsankd2avw@function> (raw)
In-Reply-To: <20190415113431.12060-1-berrange@redhat.com>
Daniel P. Berrangé, le lun. 15 avril 2019 12:34:31 +0100, a ecrit:
> Hardcoding LC_CTYPE to C.UTF-8 is a partial regression vs the above
> curses commit, since it will break the curses wide character handling
> for non-UTF-8 locales but this is unavoidable until QEMU is cleaned up
> to cope with non-UTF-8 locales fully.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Non-utf-8 environments should be rare enough that it will not be a real
concern.
Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
WARNING: multiple messages have this Message-ID (diff)
From: Samuel Thibault <samuel.thibault@gnu.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Bandan Das <bsd@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] vl: set LC_MESSAGES and LC_CTYPE in main for all code
Date: Mon, 15 Apr 2019 13:38:43 +0200 [thread overview]
Message-ID: <20190415113843.pcagpvrsankd2avw@function> (raw)
Message-ID: <20190415113843.xjAe_E-S0NKWb4Fn7oy_jWMHUS0Igiz8CMd4b6EEHWw@z> (raw)
In-Reply-To: <20190415113431.12060-1-berrange@redhat.com>
Daniel P. Berrangé, le lun. 15 avril 2019 12:34:31 +0100, a ecrit:
> Hardcoding LC_CTYPE to C.UTF-8 is a partial regression vs the above
> curses commit, since it will break the curses wide character handling
> for non-UTF-8 locales but this is unavoidable until QEMU is cleaned up
> to cope with non-UTF-8 locales fully.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Non-utf-8 environments should be rare enough that it will not be a real
concern.
Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
next prev parent reply other threads:[~2019-04-15 11:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 11:34 [Qemu-devel] [PATCH] vl: set LC_MESSAGES and LC_CTYPE in main for all code Daniel P. Berrangé
2019-04-15 11:34 ` Daniel P. Berrangé
2019-04-15 11:38 ` Samuel Thibault [this message]
2019-04-15 11:38 ` Samuel Thibault
2019-04-15 11:45 ` Philippe Mathieu-Daudé
2019-04-15 11:45 ` Philippe Mathieu-Daudé
2019-04-15 12:11 ` no-reply
2019-04-15 12:11 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415113843.pcagpvrsankd2avw@function \
--to=samuel.thibault@gnu.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=bsd@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.