All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: thomas.petazzoni@bootlin.com, jason@lakedaemon.net,
	bhelgaas@google.com, gustavo.pimentel@synopsys.com,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH -next] PCI: mvebu: Make mvebu_pci_bridge_emul_ops static
Date: Tue, 16 Apr 2019 11:08:41 +0100	[thread overview]
Message-ID: <20190416100841.GB14503@red-moon> (raw)
In-Reply-To: <20190410140949.26716-1-yuehaibing@huawei.com>

On Wed, Apr 10, 2019 at 10:09:49PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> 
> Fix sparse warning:
> 
> drivers/pci/controller/pci-mvebu.c:557:28: warning:
>  symbol 'mvebu_pci_bridge_emul_ops' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/pci/controller/pci-mvebu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to pci/misc, thanks.

Lorenzo

> diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c
> index d3a0419..ed032e9 100644
> --- a/drivers/pci/controller/pci-mvebu.c
> +++ b/drivers/pci/controller/pci-mvebu.c
> @@ -554,7 +554,7 @@ mvebu_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge,
>  	}
>  }
>  
> -struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
> +static struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
>  	.write_base = mvebu_pci_bridge_emul_base_conf_write,
>  	.read_pcie = mvebu_pci_bridge_emul_pcie_conf_read,
>  	.write_pcie = mvebu_pci_bridge_emul_pcie_conf_write,
> -- 
> 2.7.4
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: jason@lakedaemon.net, gustavo.pimentel@synopsys.com,
	linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
	linux-pci@vger.kernel.org, bhelgaas@google.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] PCI: mvebu: Make mvebu_pci_bridge_emul_ops static
Date: Tue, 16 Apr 2019 11:08:41 +0100	[thread overview]
Message-ID: <20190416100841.GB14503@red-moon> (raw)
In-Reply-To: <20190410140949.26716-1-yuehaibing@huawei.com>

On Wed, Apr 10, 2019 at 10:09:49PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> 
> Fix sparse warning:
> 
> drivers/pci/controller/pci-mvebu.c:557:28: warning:
>  symbol 'mvebu_pci_bridge_emul_ops' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/pci/controller/pci-mvebu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to pci/misc, thanks.

Lorenzo

> diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c
> index d3a0419..ed032e9 100644
> --- a/drivers/pci/controller/pci-mvebu.c
> +++ b/drivers/pci/controller/pci-mvebu.c
> @@ -554,7 +554,7 @@ mvebu_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge,
>  	}
>  }
>  
> -struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
> +static struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
>  	.write_base = mvebu_pci_bridge_emul_base_conf_write,
>  	.read_pcie = mvebu_pci_bridge_emul_pcie_conf_read,
>  	.write_pcie = mvebu_pci_bridge_emul_pcie_conf_write,
> -- 
> 2.7.4
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-04-16 10:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-10 14:09 [PATCH -next] PCI: mvebu: Make mvebu_pci_bridge_emul_ops static Yue Haibing
2019-04-10 14:09 ` Yue Haibing
2019-04-10 16:36 ` Thomas Petazzoni
2019-04-10 16:36   ` Thomas Petazzoni
2019-04-15 13:00 ` Lorenzo Pieralisi
2019-04-15 13:00   ` Lorenzo Pieralisi
2019-04-15 14:06   ` YueHaibing
2019-04-15 14:06     ` YueHaibing
2019-04-16 10:08 ` Lorenzo Pieralisi [this message]
2019-04-16 10:08   ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190416100841.GB14503@red-moon \
    --to=lorenzo.pieralisi@arm.com \
    --cc=bhelgaas@google.com \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.