From: Jonathan Corbet <corbet@lwn.net>
To: shuah <shuah@kernel.org>
Cc: linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] doc: kselftest: Fix KBUILD_OUTPUT usage instructions
Date: Tue, 16 Apr 2019 13:59:23 -0600 [thread overview]
Message-ID: <20190416135923.4e9d32e4@lwn.net> (raw)
In-Reply-To: <90615fb4-ff56-af72-f4ea-f3dbc3db26df@kernel.org>
On Tue, 16 Apr 2019 09:50:16 -0600
shuah <shuah@kernel.org> wrote:
> >> +Build and run from KBUILD_OUTPUT directory (make KBUILD_OUTPUT=)::
> >>
> >> - $ make KBUILD_OUTPUT=/tmp/kselftest kselftest
> >> + $ export KBUILD_OUTPUT=/tmp/kselftest; make kselftest
> >
> > Is there a particular reason why this variable needs to be set in the
> > environment rather than just in make? More importantly, though, I don't
> > think this would work if you run it from the KBUILD_OUTPUT directory. What
> > you're really doing is running with a separate output directory, right?
> >
>
> That is correct. I am matching the instructions in the main Makefile:
>
> # kbuild supports saving output files in a separate directory.
So my concern was right, then: this is not a way to "run from the
KBUILD_OUTPUT" directory; that seems certain to confuse people. I'll
apply the patch so that the commands are right, but that could maybe use
some tweaking.
Thanks,
jon
WARNING: multiple messages have this Message-ID (diff)
From: corbet at lwn.net (Jonathan Corbet)
Subject: [PATCH] doc: kselftest: Fix KBUILD_OUTPUT usage instructions
Date: Tue, 16 Apr 2019 13:59:23 -0600 [thread overview]
Message-ID: <20190416135923.4e9d32e4@lwn.net> (raw)
In-Reply-To: <90615fb4-ff56-af72-f4ea-f3dbc3db26df@kernel.org>
On Tue, 16 Apr 2019 09:50:16 -0600
shuah <shuah at kernel.org> wrote:
> >> +Build and run from KBUILD_OUTPUT directory (make KBUILD_OUTPUT=)::
> >>
> >> - $ make KBUILD_OUTPUT=/tmp/kselftest kselftest
> >> + $ export KBUILD_OUTPUT=/tmp/kselftest; make kselftest
> >
> > Is there a particular reason why this variable needs to be set in the
> > environment rather than just in make? More importantly, though, I don't
> > think this would work if you run it from the KBUILD_OUTPUT directory. What
> > you're really doing is running with a separate output directory, right?
> >
>
> That is correct. I am matching the instructions in the main Makefile:
>
> # kbuild supports saving output files in a separate directory.
So my concern was right, then: this is not a way to "run from the
KBUILD_OUTPUT" directory; that seems certain to confuse people. I'll
apply the patch so that the commands are right, but that could maybe use
some tweaking.
Thanks,
jon
WARNING: multiple messages have this Message-ID (diff)
From: corbet@lwn.net (Jonathan Corbet)
Subject: [PATCH] doc: kselftest: Fix KBUILD_OUTPUT usage instructions
Date: Tue, 16 Apr 2019 13:59:23 -0600 [thread overview]
Message-ID: <20190416135923.4e9d32e4@lwn.net> (raw)
Message-ID: <20190416195923.NflMs5FYp296VHz1ruuBva5Quo9dxRemUbr9GlfND5Q@z> (raw)
In-Reply-To: <90615fb4-ff56-af72-f4ea-f3dbc3db26df@kernel.org>
On Tue, 16 Apr 2019 09:50:16 -0600
shuah <shuah@kernel.org> wrote:
> >> +Build and run from KBUILD_OUTPUT directory (make KBUILD_OUTPUT=)::
> >>
> >> - $ make KBUILD_OUTPUT=/tmp/kselftest kselftest
> >> + $ export KBUILD_OUTPUT=/tmp/kselftest; make kselftest
> >
> > Is there a particular reason why this variable needs to be set in the
> > environment rather than just in make? More importantly, though, I don't
> > think this would work if you run it from the KBUILD_OUTPUT directory. What
> > you're really doing is running with a separate output directory, right?
> >
>
> That is correct. I am matching the instructions in the main Makefile:
>
> # kbuild supports saving output files in a separate directory.
So my concern was right, then: this is not a way to "run from the
KBUILD_OUTPUT" directory; that seems certain to confuse people. I'll
apply the patch so that the commands are right, but that could maybe use
some tweaking.
Thanks,
jon
next prev parent reply other threads:[~2019-04-16 19:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 14:26 [PATCH] doc: kselftest: Fix KBUILD_OUTPUT usage instructions Shuah Khan
2019-04-16 14:26 ` Shuah Khan
2019-04-16 14:26 ` shuah
2019-04-16 15:26 ` Jonathan Corbet
2019-04-16 15:26 ` Jonathan Corbet
2019-04-16 15:26 ` corbet
2019-04-16 15:50 ` shuah
2019-04-16 15:50 ` shuah
2019-04-16 15:50 ` shuah
2019-04-16 19:59 ` Jonathan Corbet [this message]
2019-04-16 19:59 ` Jonathan Corbet
2019-04-16 19:59 ` corbet
2019-04-16 20:05 ` shuah
2019-04-16 20:05 ` shuah
2019-04-16 20:05 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416135923.4e9d32e4@lwn.net \
--to=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.