From: Greg KH <greg@kroah.com>
To: Lars Persson <lars.persson@axis.com>
Cc: stable@vger.kernel.org, peppe.cavallaro@st.com,
alexandre.torgue@st.com, joabreu@synopsys.com,
Lars Persson <larper@axis.com>
Subject: Re: [PATCH stable 4.14] net: stmmac: Set dma ring length before enabling the DMA
Date: Wed, 17 Apr 2019 22:14:38 +0200 [thread overview]
Message-ID: <20190417201438.GA13639@kroah.com> (raw)
In-Reply-To: <20190415074947.6144-1-larper@axis.com>
On Mon, Apr 15, 2019 at 09:49:47AM +0200, Lars Persson wrote:
> This was fixed in upstream by commit 7d9e6c5afab6 ("net: stmmac: Integrate
> XGMAC into main driver flow") that is a new feature commit.
>
> We found a race condition in the DMA init sequence that hits if the
> PHY already has link up during stmmac_hw_setup. Since the ring length
> was programmed after enabling the RX path, we might receive a packet
> before the correct ring length is programmed. When that happened we
> could not get reliable interrupts for DMA RX and the MTL complained
> about RX FIFO overrun.
>
> Signed-off-by: Lars Persson <larper@axis.com>
> Cc: stable@vger.kernel.org # 4.14.x
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Jose Abreu <joabreu@synopsys.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
This, and the 4.9 patch now queued up, thanks.
greg k-h
prev parent reply other threads:[~2019-04-17 20:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 7:49 [PATCH stable 4.14] net: stmmac: Set dma ring length before enabling the DMA Lars Persson
2019-04-17 20:14 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190417201438.GA13639@kroah.com \
--to=greg@kroah.com \
--cc=alexandre.torgue@st.com \
--cc=joabreu@synopsys.com \
--cc=larper@axis.com \
--cc=lars.persson@axis.com \
--cc=peppe.cavallaro@st.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.