* [Qemu-devel] [PATCH] hppa: Delete unused hppa_cpu_list() function
@ 2019-04-18 4:01 ` Eduardo Habkost
0 siblings, 0 replies; 4+ messages in thread
From: Eduardo Habkost @ 2019-04-18 4:01 UTC (permalink / raw)
To: qemu-devel; +Cc: Richard Henderson, Igor Mammedov
hppa_cpu_list() is dead code and is never called. Delete it.
Cc: Richard Henderson <rth@twiddle.net>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
target/hppa/cpu.c | 22 ----------------------
1 file changed, 22 deletions(-)
diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c
index 00bf444620..b3b1826209 100644
--- a/target/hppa/cpu.c
+++ b/target/hppa/cpu.c
@@ -110,28 +110,6 @@ static void hppa_cpu_realizefn(DeviceState *dev, Error **errp)
#endif
}
-static void hppa_cpu_list_entry(gpointer data, gpointer user_data)
-{
- ObjectClass *oc = data;
- CPUListState *s = user_data;
-
- (*s->cpu_fprintf)(s->file, " %s\n", object_class_get_name(oc));
-}
-
-void hppa_cpu_list(FILE *f, fprintf_function cpu_fprintf)
-{
- CPUListState s = {
- .file = f,
- .cpu_fprintf = cpu_fprintf,
- };
- GSList *list;
-
- list = object_class_get_list_sorted(TYPE_HPPA_CPU, false);
- (*cpu_fprintf)(f, "Available CPUs:\n");
- g_slist_foreach(list, hppa_cpu_list_entry, &s);
- g_slist_free(list);
-}
-
static void hppa_cpu_initfn(Object *obj)
{
CPUState *cs = CPU(obj);
--
2.18.0.rc1.1.g3f1ff2140
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Qemu-devel] [PATCH] hppa: Delete unused hppa_cpu_list() function
@ 2019-04-18 4:01 ` Eduardo Habkost
0 siblings, 0 replies; 4+ messages in thread
From: Eduardo Habkost @ 2019-04-18 4:01 UTC (permalink / raw)
To: qemu-devel; +Cc: Igor Mammedov, Richard Henderson
hppa_cpu_list() is dead code and is never called. Delete it.
Cc: Richard Henderson <rth@twiddle.net>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
target/hppa/cpu.c | 22 ----------------------
1 file changed, 22 deletions(-)
diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c
index 00bf444620..b3b1826209 100644
--- a/target/hppa/cpu.c
+++ b/target/hppa/cpu.c
@@ -110,28 +110,6 @@ static void hppa_cpu_realizefn(DeviceState *dev, Error **errp)
#endif
}
-static void hppa_cpu_list_entry(gpointer data, gpointer user_data)
-{
- ObjectClass *oc = data;
- CPUListState *s = user_data;
-
- (*s->cpu_fprintf)(s->file, " %s\n", object_class_get_name(oc));
-}
-
-void hppa_cpu_list(FILE *f, fprintf_function cpu_fprintf)
-{
- CPUListState s = {
- .file = f,
- .cpu_fprintf = cpu_fprintf,
- };
- GSList *list;
-
- list = object_class_get_list_sorted(TYPE_HPPA_CPU, false);
- (*cpu_fprintf)(f, "Available CPUs:\n");
- g_slist_foreach(list, hppa_cpu_list_entry, &s);
- g_slist_free(list);
-}
-
static void hppa_cpu_initfn(Object *obj)
{
CPUState *cs = CPU(obj);
--
2.18.0.rc1.1.g3f1ff2140
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] hppa: Delete unused hppa_cpu_list() function
2019-04-18 4:01 ` Eduardo Habkost
(?)
@ 2019-04-18 11:23 ` Igor Mammedov
-1 siblings, 0 replies; 4+ messages in thread
From: Igor Mammedov @ 2019-04-18 11:23 UTC (permalink / raw)
To: Eduardo Habkost; +Cc: qemu-devel, Richard Henderson
On Thu, 18 Apr 2019 01:01:03 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:
> hppa_cpu_list() is dead code and is never called. Delete it.
>
> Cc: Richard Henderson <rth@twiddle.net>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> target/hppa/cpu.c | 22 ----------------------
> 1 file changed, 22 deletions(-)
>
> diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c
> index 00bf444620..b3b1826209 100644
> --- a/target/hppa/cpu.c
> +++ b/target/hppa/cpu.c
> @@ -110,28 +110,6 @@ static void hppa_cpu_realizefn(DeviceState *dev, Error **errp)
> #endif
> }
>
> -static void hppa_cpu_list_entry(gpointer data, gpointer user_data)
> -{
> - ObjectClass *oc = data;
> - CPUListState *s = user_data;
> -
> - (*s->cpu_fprintf)(s->file, " %s\n", object_class_get_name(oc));
> -}
> -
> -void hppa_cpu_list(FILE *f, fprintf_function cpu_fprintf)
> -{
> - CPUListState s = {
> - .file = f,
> - .cpu_fprintf = cpu_fprintf,
> - };
> - GSList *list;
> -
> - list = object_class_get_list_sorted(TYPE_HPPA_CPU, false);
> - (*cpu_fprintf)(f, "Available CPUs:\n");
> - g_slist_foreach(list, hppa_cpu_list_entry, &s);
> - g_slist_free(list);
> -}
> -
> static void hppa_cpu_initfn(Object *obj)
> {
> CPUState *cs = CPU(obj);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] hppa: Delete unused hppa_cpu_list() function
2019-04-18 4:01 ` Eduardo Habkost
(?)
(?)
@ 2019-04-18 12:44 ` Philippe Mathieu-Daudé
-1 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-04-18 12:44 UTC (permalink / raw)
To: Eduardo Habkost, qemu-devel; +Cc: Igor Mammedov, Richard Henderson
Hi Eduardo,
On 4/18/19 6:01 AM, Eduardo Habkost wrote:
> hppa_cpu_list() is dead code and is never called. Delete it.
>
> Cc: Richard Henderson <rth@twiddle.net>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> target/hppa/cpu.c | 22 ----------------------
> 1 file changed, 22 deletions(-)
>
> diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c
> index 00bf444620..b3b1826209 100644
> --- a/target/hppa/cpu.c
> +++ b/target/hppa/cpu.c
> @@ -110,28 +110,6 @@ static void hppa_cpu_realizefn(DeviceState *dev, Error **errp)
> #endif
> }
>
> -static void hppa_cpu_list_entry(gpointer data, gpointer user_data)
> -{
> - ObjectClass *oc = data;
> - CPUListState *s = user_data;
> -
> - (*s->cpu_fprintf)(s->file, " %s\n", object_class_get_name(oc));
> -}
> -
> -void hppa_cpu_list(FILE *f, fprintf_function cpu_fprintf)
You forgot to remove the declaration in "target/hppa/cpu.h".
With this header updated:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> -{
> - CPUListState s = {
> - .file = f,
> - .cpu_fprintf = cpu_fprintf,
> - };
> - GSList *list;
> -
> - list = object_class_get_list_sorted(TYPE_HPPA_CPU, false);
> - (*cpu_fprintf)(f, "Available CPUs:\n");
> - g_slist_foreach(list, hppa_cpu_list_entry, &s);
> - g_slist_free(list);
> -}
> -
> static void hppa_cpu_initfn(Object *obj)
> {
> CPUState *cs = CPU(obj);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-18 12:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-18 4:01 [Qemu-devel] [PATCH] hppa: Delete unused hppa_cpu_list() function Eduardo Habkost
2019-04-18 4:01 ` Eduardo Habkost
2019-04-18 11:23 ` Igor Mammedov
2019-04-18 12:44 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.