From: Borislav Petkov <bp@alien8.de>
To: Pan Bian <bianpan2016@163.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
James Morse <james.morse@arm.com>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: EDAC: Fix memory leak in creating CSROW object
Date: Thu, 18 Apr 2019 19:25:48 +0200 [thread overview]
Message-ID: <20190418172548.GL27160@zn.tnic> (raw)
On Thu, Apr 18, 2019 at 10:27:18AM +0800, Pan Bian wrote:
> In the function that creates a CSROW object, the object is not released
> when failing to add the device to device hierarchy.
Are you sure about this?
> This may result in a memory leak bug.
"May"?
I see a loop which unwinds by putting the already created devices. Do
you?
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Pan Bian <bianpan2016@163.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
James Morse <james.morse@arm.com>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: EDAC: Fix memory leak in creating CSROW object
Date: Thu, 18 Apr 2019 19:25:48 +0200 [thread overview]
Message-ID: <20190418172548.GL27160@zn.tnic> (raw)
Message-ID: <20190418172548.lLZDUmJ3nAx6gmc0NW4AfYna2Ib7qKO6KSkFrlHi6C4@z> (raw)
In-Reply-To: <1555554438-103953-1-git-send-email-bianpan2016@163.com>
On Thu, Apr 18, 2019 at 10:27:18AM +0800, Pan Bian wrote:
> In the function that creates a CSROW object, the object is not released
> when failing to add the device to device hierarchy.
Are you sure about this?
> This may result in a memory leak bug.
"May"?
I see a loop which unwinds by putting the already created devices. Do
you?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev reply other threads:[~2019-04-18 17:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 2:27 EDAC: Fix memory leak in creating CSROW object Pan Bian
2019-04-18 2:27 ` Pan Bian
2019-04-18 17:25 ` Borislav Petkov [this message]
2019-04-18 17:25 ` Borislav Petkov
[not found] ` <20190419003536.GA57795@bianpan2016@163.com>
2019-04-19 0:45 ` Borislav Petkov
2019-04-19 0:45 ` Borislav Petkov
2019-04-27 21:49 ` Greg Kroah-Hartman
2019-04-27 21:49 ` Greg KH
2019-05-08 10:57 ` Borislav Petkov
2019-05-08 12:47 ` Greg KH
2019-05-08 18:50 ` Borislav Petkov
2019-05-08 11:02 ` [PATCH 1/2] EDAC/sysfs: Fix memory leak when creating a csrow object Borislav Petkov
2019-05-08 12:45 ` Greg KH
2019-05-08 11:06 ` [PATCH 2/2] EDAC/sysfs: Drop device references properly Borislav Petkov
2019-05-08 12:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418172548.GL27160@zn.tnic \
--to=bp@alien8.de \
--cc=bianpan2016@163.com \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.