From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: Felipe Balbi <balbi@kernel.org>,
linux-usb <linux-usb@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Manu Gautam <mgautam@codeaurora.org>,
Jeffrey Hugo <jhugo@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH] usb: dwc3: Allow building USB_DWC3_QCOM without EXTCON
Date: Fri, 19 Apr 2019 13:35:29 +0200 [thread overview]
Message-ID: <20190419113529.GA16007@kroah.com> (raw)
In-Reply-To: <20190419112423.GC14886@kroah.com>
On Fri, Apr 19, 2019 at 01:24:23PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Apr 19, 2019 at 11:59:08AM +0200, Marc Gonzalez wrote:
> > Keep EXTCON support optional, since some platforms do not need it.
> >
> > Fixes: 3def4031b3e3 ("usb: dwc3: add EXTCON dependency for qcom")
> > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> > ---
> > drivers/usb/dwc3/Kconfig | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> > index 2b1494460d0c..6bd1a28c535f 100644
> > --- a/drivers/usb/dwc3/Kconfig
> > +++ b/drivers/usb/dwc3/Kconfig
> > @@ -115,7 +115,8 @@ config USB_DWC3_ST
> >
> > config USB_DWC3_QCOM
> > tristate "Qualcomm Platform"
> > - depends on EXTCON && (ARCH_QCOM || COMPILE_TEST)
> > + depends on ARCH_QCOM || COMPILE_TEST
> > + depends on EXTCON || !EXTCON
>
> Why is this last line needed? Does it really do anything?
As explained to me on irc, this line is fine.
Learn something new every day :)
greg k-h
next prev parent reply other threads:[~2019-04-19 18:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 9:59 usb: dwc3: Allow building USB_DWC3_QCOM without EXTCON Marc Gonzalez
2019-04-19 9:59 ` [PATCH] " Marc Gonzalez
2019-04-19 11:24 ` Greg Kroah-Hartman
2019-04-19 11:35 ` Greg Kroah-Hartman [this message]
2019-04-19 12:12 ` Marc Gonzalez
2019-04-24 9:58 ` Marc Gonzalez
2019-04-24 9:58 ` Marc Gonzalez
2019-04-24 12:30 ` Arnd Bergmann
2019-04-24 12:30 ` [PATCH] " Arnd Bergmann
2019-04-24 15:00 ` [PATCH v2] " Marc Gonzalez
2019-04-24 15:00 ` [v2] " Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190419113529.GA16007@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=jhugo@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-usb@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mgautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.