* [PATCH] usb: dwc3: Allow building USB_DWC3_QCOM without EXTCON
@ 2019-04-19 9:59 ` Marc Gonzalez
0 siblings, 0 replies; 11+ messages in thread
From: Marc Gonzalez @ 2019-04-19 9:59 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman
Cc: linux-usb, Arnd Bergmann, Manu Gautam, Jeffrey Hugo,
Bjorn Andersson, Lee Jones
Keep EXTCON support optional, since some platforms do not need it.
Fixes: 3def4031b3e3 ("usb: dwc3: add EXTCON dependency for qcom")
Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
---
drivers/usb/dwc3/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
index 2b1494460d0c..6bd1a28c535f 100644
--- a/drivers/usb/dwc3/Kconfig
+++ b/drivers/usb/dwc3/Kconfig
@@ -115,7 +115,8 @@ config USB_DWC3_ST
config USB_DWC3_QCOM
tristate "Qualcomm Platform"
- depends on EXTCON && (ARCH_QCOM || COMPILE_TEST)
+ depends on ARCH_QCOM || COMPILE_TEST
+ depends on EXTCON || !EXTCON
depends on OF
default USB_DWC3
help
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH] usb: dwc3: Allow building USB_DWC3_QCOM without EXTCON
2019-04-19 9:59 ` [PATCH] " Marc Gonzalez
(?)
@ 2019-04-19 11:24 ` Greg Kroah-Hartman
2019-04-19 11:35 ` Greg Kroah-Hartman
2019-04-19 12:12 ` Marc Gonzalez
-1 siblings, 2 replies; 11+ messages in thread
From: Greg Kroah-Hartman @ 2019-04-19 11:24 UTC (permalink / raw)
To: Marc Gonzalez
Cc: Felipe Balbi, linux-usb, Arnd Bergmann, Manu Gautam, Jeffrey Hugo,
Bjorn Andersson, Lee Jones
On Fri, Apr 19, 2019 at 11:59:08AM +0200, Marc Gonzalez wrote:
> Keep EXTCON support optional, since some platforms do not need it.
>
> Fixes: 3def4031b3e3 ("usb: dwc3: add EXTCON dependency for qcom")
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> ---
> drivers/usb/dwc3/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index 2b1494460d0c..6bd1a28c535f 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -115,7 +115,8 @@ config USB_DWC3_ST
>
> config USB_DWC3_QCOM
> tristate "Qualcomm Platform"
> - depends on EXTCON && (ARCH_QCOM || COMPILE_TEST)
> + depends on ARCH_QCOM || COMPILE_TEST
> + depends on EXTCON || !EXTCON
Why is this last line needed? Does it really do anything?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] usb: dwc3: Allow building USB_DWC3_QCOM without EXTCON
2019-04-19 11:24 ` Greg Kroah-Hartman
@ 2019-04-19 11:35 ` Greg Kroah-Hartman
2019-04-19 12:12 ` Marc Gonzalez
1 sibling, 0 replies; 11+ messages in thread
From: Greg Kroah-Hartman @ 2019-04-19 11:35 UTC (permalink / raw)
To: Marc Gonzalez
Cc: Felipe Balbi, linux-usb, Arnd Bergmann, Manu Gautam, Jeffrey Hugo,
Bjorn Andersson, Lee Jones
On Fri, Apr 19, 2019 at 01:24:23PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Apr 19, 2019 at 11:59:08AM +0200, Marc Gonzalez wrote:
> > Keep EXTCON support optional, since some platforms do not need it.
> >
> > Fixes: 3def4031b3e3 ("usb: dwc3: add EXTCON dependency for qcom")
> > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> > ---
> > drivers/usb/dwc3/Kconfig | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> > index 2b1494460d0c..6bd1a28c535f 100644
> > --- a/drivers/usb/dwc3/Kconfig
> > +++ b/drivers/usb/dwc3/Kconfig
> > @@ -115,7 +115,8 @@ config USB_DWC3_ST
> >
> > config USB_DWC3_QCOM
> > tristate "Qualcomm Platform"
> > - depends on EXTCON && (ARCH_QCOM || COMPILE_TEST)
> > + depends on ARCH_QCOM || COMPILE_TEST
> > + depends on EXTCON || !EXTCON
>
> Why is this last line needed? Does it really do anything?
As explained to me on irc, this line is fine.
Learn something new every day :)
greg k-h
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] usb: dwc3: Allow building USB_DWC3_QCOM without EXTCON
2019-04-19 11:24 ` Greg Kroah-Hartman
2019-04-19 11:35 ` Greg Kroah-Hartman
@ 2019-04-19 12:12 ` Marc Gonzalez
1 sibling, 0 replies; 11+ messages in thread
From: Marc Gonzalez @ 2019-04-19 12:12 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Felipe Balbi, linux-usb, Arnd Bergmann, Manu Gautam, Jeffrey Hugo,
Bjorn Andersson, Lee Jones
On 19/04/2019 13:24, Greg Kroah-Hartman wrote:
> On Fri, Apr 19, 2019 at 11:59:08AM +0200, Marc Gonzalez wrote:
>
>> Keep EXTCON support optional, since some platforms do not need it.
>>
>> Fixes: 3def4031b3e3 ("usb: dwc3: add EXTCON dependency for qcom")
>> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
>> ---
>> drivers/usb/dwc3/Kconfig | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
>> index 2b1494460d0c..6bd1a28c535f 100644
>> --- a/drivers/usb/dwc3/Kconfig
>> +++ b/drivers/usb/dwc3/Kconfig
>> @@ -115,7 +115,8 @@ config USB_DWC3_ST
>>
>> config USB_DWC3_QCOM
>> tristate "Qualcomm Platform"
>> - depends on EXTCON && (ARCH_QCOM || COMPILE_TEST)
>> + depends on ARCH_QCOM || COMPILE_TEST
>> + depends on EXTCON || !EXTCON
>
> Why is this last line needed? Does it really do anything?
For the record, there are 42 instances of this unintuitive kconfig syntax:
$ git grep 'depends on [A-Z_]* || !' | wc
42 342 2965
https://www.kernel.org/doc/Documentation/kbuild/kconfig-language.txt
An expression can have a value of 'n', 'm' or 'y' (0, 1, 2 respectively for calculations).
"BAR depends on FOO" means (FOO=m && BAR=m) || (FOO=y && BAR=m) || (FOO=y && BAR=y) || BAR=n
NB: (FOO=m && BAR=y) is explicitly forbidden by kconfig (special-cased?)
("This feature depends on another which has been configured as a module.
As a result, this feature will be built as a module.")
"BAR depends on !FOO" means (FOO=n && BAR=m) || (FOO=n && BAR=y)
Thus "BAR depends on FOO || !FOO" means ALL 9 combinations EXCEPT (FOO=m && BAR=y)
Regards.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: dwc3: Allow building USB_DWC3_QCOM without EXTCON
@ 2019-04-24 9:58 ` Marc Gonzalez
0 siblings, 0 replies; 11+ messages in thread
From: Marc Gonzalez @ 2019-04-24 9:58 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman
Cc: linux-usb, Arnd Bergmann, Manu Gautam, Jeffrey Hugo,
Bjorn Andersson, Lee Jones, MSM
On 19/04/2019 11:59, Marc Gonzalez wrote:
> Keep EXTCON support optional, since some platforms do not need it.
>
> Fixes: 3def4031b3e3 ("usb: dwc3: add EXTCON dependency for qcom")
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> ---
> drivers/usb/dwc3/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index 2b1494460d0c..6bd1a28c535f 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -115,7 +115,8 @@ config USB_DWC3_ST
>
> config USB_DWC3_QCOM
> tristate "Qualcomm Platform"
> - depends on EXTCON && (ARCH_QCOM || COMPILE_TEST)
> + depends on ARCH_QCOM || COMPILE_TEST
> + depends on EXTCON || !EXTCON
> depends on OF
> default USB_DWC3
> help
Can I get an amen? :-)
Arnd? Greg? Mom?
^ permalink raw reply [flat|nested] 11+ messages in thread* usb: dwc3: Allow building USB_DWC3_QCOM without EXTCON
@ 2019-04-24 9:58 ` Marc Gonzalez
0 siblings, 0 replies; 11+ messages in thread
From: Marc Gonzalez @ 2019-04-24 9:58 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman
Cc: linux-usb, Arnd Bergmann, Manu Gautam, Jeffrey Hugo,
Bjorn Andersson, Lee Jones, MSM
On 19/04/2019 11:59, Marc Gonzalez wrote:
> Keep EXTCON support optional, since some platforms do not need it.
>
> Fixes: 3def4031b3e3 ("usb: dwc3: add EXTCON dependency for qcom")
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> ---
> drivers/usb/dwc3/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index 2b1494460d0c..6bd1a28c535f 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -115,7 +115,8 @@ config USB_DWC3_ST
>
> config USB_DWC3_QCOM
> tristate "Qualcomm Platform"
> - depends on EXTCON && (ARCH_QCOM || COMPILE_TEST)
> + depends on ARCH_QCOM || COMPILE_TEST
> + depends on EXTCON || !EXTCON
> depends on OF
> default USB_DWC3
> help
Can I get an amen? :-)
Arnd? Greg? Mom?
^ permalink raw reply [flat|nested] 11+ messages in thread
* usb: dwc3: Allow building USB_DWC3_QCOM without EXTCON
@ 2019-04-24 12:30 ` Arnd Bergmann
0 siblings, 0 replies; 11+ messages in thread
From: Arnd Bergmann @ 2019-04-24 12:30 UTC (permalink / raw)
To: Marc Gonzalez
Cc: Felipe Balbi, Greg Kroah-Hartman, linux-usb, Manu Gautam,
Jeffrey Hugo, Bjorn Andersson, Lee Jones
On Fri, Apr 19, 2019 at 11:59 AM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote:
>
> Keep EXTCON support optional, since some platforms do not need it.
>
> Fixes: 3def4031b3e3 ("usb: dwc3: add EXTCON dependency for qcom")
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
The patch looks good, but please keep this in sync with the TI driver
that does the same thing, so better convert them both in one patch.
> ---
> drivers/usb/dwc3/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index 2b1494460d0c..6bd1a28c535f 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -115,7 +115,8 @@ config USB_DWC3_ST
>
> config USB_DWC3_QCOM
> tristate "Qualcomm Platform"
> - depends on EXTCON && (ARCH_QCOM || COMPILE_TEST)
> + depends on ARCH_QCOM || COMPILE_TEST
> + depends on EXTCON || !EXTCON
> depends on OF
> default USB_DWC3
> help
> --
> 2.17.1
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] usb: dwc3: Allow building USB_DWC3_QCOM without EXTCON
@ 2019-04-24 12:30 ` Arnd Bergmann
0 siblings, 0 replies; 11+ messages in thread
From: Arnd Bergmann @ 2019-04-24 12:30 UTC (permalink / raw)
To: Marc Gonzalez
Cc: Felipe Balbi, Greg Kroah-Hartman, linux-usb, Manu Gautam,
Jeffrey Hugo, Bjorn Andersson, Lee Jones
On Fri, Apr 19, 2019 at 11:59 AM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote:
>
> Keep EXTCON support optional, since some platforms do not need it.
>
> Fixes: 3def4031b3e3 ("usb: dwc3: add EXTCON dependency for qcom")
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
The patch looks good, but please keep this in sync with the TI driver
that does the same thing, so better convert them both in one patch.
> ---
> drivers/usb/dwc3/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index 2b1494460d0c..6bd1a28c535f 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -115,7 +115,8 @@ config USB_DWC3_ST
>
> config USB_DWC3_QCOM
> tristate "Qualcomm Platform"
> - depends on EXTCON && (ARCH_QCOM || COMPILE_TEST)
> + depends on ARCH_QCOM || COMPILE_TEST
> + depends on EXTCON || !EXTCON
> depends on OF
> default USB_DWC3
> help
> --
> 2.17.1
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v2] usb: dwc3: Allow building USB_DWC3_QCOM without EXTCON
@ 2019-04-24 15:00 ` Marc Gonzalez
0 siblings, 0 replies; 11+ messages in thread
From: Marc Gonzalez @ 2019-04-24 15:00 UTC (permalink / raw)
To: Arnd Bergmann, Felipe Balbi, Greg Kroah-Hartman
Cc: linux-usb, Manu Gautam, Jeffrey Hugo, Bjorn Andersson, Lee Jones,
MSM
Keep EXTCON support optional, as some platforms do not need it.
Do the same for USB_DWC3_OMAP while we're at it.
Fixes: 3def4031b3e3f ("usb: dwc3: add EXTCON dependency for qcom")
Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
---
Changes from v1: Do the same change for USB_DWC3_OMAP, as suggested by Arnd
---
drivers/usb/dwc3/Kconfig | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
index 2b1494460d0c..784309435916 100644
--- a/drivers/usb/dwc3/Kconfig
+++ b/drivers/usb/dwc3/Kconfig
@@ -54,7 +54,8 @@ comment "Platform Glue Driver Support"
config USB_DWC3_OMAP
tristate "Texas Instruments OMAP5 and similar Platforms"
- depends on EXTCON && (ARCH_OMAP2PLUS || COMPILE_TEST)
+ depends on ARCH_OMAP2PLUS || COMPILE_TEST
+ depends on EXTCON || !EXTCON
depends on OF
default USB_DWC3
help
@@ -115,7 +116,8 @@ config USB_DWC3_ST
config USB_DWC3_QCOM
tristate "Qualcomm Platform"
- depends on EXTCON && (ARCH_QCOM || COMPILE_TEST)
+ depends on ARCH_QCOM || COMPILE_TEST
+ depends on EXTCON || !EXTCON
depends on OF
default USB_DWC3
help
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [v2] usb: dwc3: Allow building USB_DWC3_QCOM without EXTCON
@ 2019-04-24 15:00 ` Marc Gonzalez
0 siblings, 0 replies; 11+ messages in thread
From: Marc Gonzalez @ 2019-04-24 15:00 UTC (permalink / raw)
To: Arnd Bergmann, Felipe Balbi, Greg Kroah-Hartman
Cc: linux-usb, Manu Gautam, Jeffrey Hugo, Bjorn Andersson, Lee Jones,
MSM
Keep EXTCON support optional, as some platforms do not need it.
Do the same for USB_DWC3_OMAP while we're at it.
Fixes: 3def4031b3e3f ("usb: dwc3: add EXTCON dependency for qcom")
Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
---
Changes from v1: Do the same change for USB_DWC3_OMAP, as suggested by Arnd
---
drivers/usb/dwc3/Kconfig | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
index 2b1494460d0c..784309435916 100644
--- a/drivers/usb/dwc3/Kconfig
+++ b/drivers/usb/dwc3/Kconfig
@@ -54,7 +54,8 @@ comment "Platform Glue Driver Support"
config USB_DWC3_OMAP
tristate "Texas Instruments OMAP5 and similar Platforms"
- depends on EXTCON && (ARCH_OMAP2PLUS || COMPILE_TEST)
+ depends on ARCH_OMAP2PLUS || COMPILE_TEST
+ depends on EXTCON || !EXTCON
depends on OF
default USB_DWC3
help
@@ -115,7 +116,8 @@ config USB_DWC3_ST
config USB_DWC3_QCOM
tristate "Qualcomm Platform"
- depends on EXTCON && (ARCH_QCOM || COMPILE_TEST)
+ depends on ARCH_QCOM || COMPILE_TEST
+ depends on EXTCON || !EXTCON
depends on OF
default USB_DWC3
help
^ permalink raw reply related [flat|nested] 11+ messages in thread