[mmotm:master 200/348] mm/z3fold.c:1288:6: sparse: symbol 'z3fold_page_isolate' was not declared. Should it be static?

[mmotm:master 200/348] mm/z3fold.c:1288:6: sparse: symbol 'z3fold_page_isolate' was not declared. Should it be static?

[kbuild test robot]

tree:   git://git.cmpxchg.org/linux-mmotm.git master
head:   0a5fb91e6404ba48c11565cc856f597311b21344
commit: eaa5a15c91fe04a61b97e14e5a2f229d0907678b [200/348] mm/z3fold.c: support page migration
reproduce:
        # apt-get install sparse
        git checkout eaa5a15c91fe04a61b97e14e5a2f229d0907678b
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>



sparse warnings: (new ones prefixed by >>)

   mm/z3fold.c:519:25: sparse: expression using sizeof(void)
   mm/z3fold.c:519:25: sparse: expression using sizeof(void)
   mm/z3fold.c:531:47: sparse: incorrect type in initializer (different address spaces) @@    expected void const [noderef] <asn:3>*__vpp_verify @@    got [noderef] <asn:3>*__vpp_verify @@
   mm/z3fold.c:531:47:    expected void const [noderef] <asn:3>*__vpp_verify
   mm/z3fold.c:531:47:    got struct list_head *<noident>
   mm/z3fold.c:769:25: sparse: incorrect type in assignment (different address spaces) @@    expected struct list_head *unbuddied @@    got void struct list_head *unbuddied @@
   mm/z3fold.c:769:25:    expected struct list_head *unbuddied
   mm/z3fold.c:769:25:    got void [noderef] <asn:3>*
   mm/z3fold.c:774:33: sparse: incorrect type in initializer (different address spaces) @@    expected void const [noderef] <asn:3>*__vpp_verify @@    got [noderef] <asn:3>*__vpp_verify @@
   mm/z3fold.c:774:33:    expected void const [noderef] <asn:3>*__vpp_verify
   mm/z3fold.c:774:33:    got struct list_head *<noident>
   mm/z3fold.c:799:25: sparse: incorrect type in argument 1 (different address spaces) @@    expected void [noderef] <asn:3>*__pdata @@    got [noderef] <asn:3>*__pdata @@
   mm/z3fold.c:799:25:    expected void [noderef] <asn:3>*__pdata
   mm/z3fold.c:799:25:    got struct list_head *unbuddied
   mm/z3fold.c:653:21: sparse: incorrect type in initializer (different address spaces) @@    expected void const [noderef] <asn:3>*__vpp_verify @@    got [noderef] <asn:3>*__vpp_verify @@
   mm/z3fold.c:653:21:    expected void const [noderef] <asn:3>*__vpp_verify
   mm/z3fold.c:653:21:    got struct list_head *<noident>
   mm/z3fold.c:708:37: sparse: incorrect type in initializer (different address spaces) @@    expected void const [noderef] <asn:3>*__vpp_verify @@    got [noderef] <asn:3>*__vpp_verify @@
   mm/z3fold.c:708:37:    expected void const [noderef] <asn:3>*__vpp_verify
   mm/z3fold.c:708:37:    got struct list_head *<noident>
   mm/z3fold.c:531:47: sparse: incorrect type in initializer (different address spaces) @@    expected void const [noderef] <asn:3>*__vpp_verify @@    got [noderef] <asn:3>*__vpp_verify @@
   mm/z3fold.c:531:47:    expected void const [noderef] <asn:3>*__vpp_verify
   mm/z3fold.c:531:47:    got struct list_head *<noident>
>> mm/z3fold.c:1288:6: sparse: symbol 'z3fold_page_isolate' was not declared. Should it be static?
>> mm/z3fold.c:1323:5: sparse: symbol 'z3fold_page_migrate' was not declared. Should it be static?
>> mm/z3fold.c:1382:6: sparse: symbol 'z3fold_page_putback' was not declared. Should it be static?
   mm/z3fold.c:443:35: sparse: context imbalance in '__release_z3fold_page' - unexpected unlock
   mm/z3fold.c:462:9: sparse: context imbalance in 'release_z3fold_page_locked' - wrong count at exit
   mm/z3fold.c:475:9: sparse: context imbalance in 'release_z3fold_page_locked_list' - wrong count at exit
   mm/z3fold.c:610:13: sparse: context imbalance in 'do_compact_page' - different lock contexts for basic block
   mm/z3fold.c:950:35: sparse: context imbalance in 'z3fold_alloc' - unexpected unlock
   mm/z3fold.c:965:13: sparse: context imbalance in 'z3fold_free' - different lock contexts for basic block
   mm/z3fold.c:1075:12: sparse: context imbalance in 'z3fold_reclaim_page' - different lock contexts for basic block
>> mm/z3fold.c:1382:6: sparse: context imbalance in 'z3fold_page_putback' - wrong count at exit

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[RFC PATCH mmotm] mm/z3fold.c: z3fold_page_isolate() can be static

[kbuild test robot]

Fixes: eaa5a15c91fe ("mm/z3fold.c: support page migration")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 z3fold.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/mm/z3fold.c b/mm/z3fold.c
index d9eabfda..1ffecd6 100644
--- a/mm/z3fold.c
+++ b/mm/z3fold.c
@@ -1285,7 +1285,7 @@ static u64 z3fold_get_pool_size(struct z3fold_pool *pool)
 	return atomic64_read(&pool->pages_nr);
 }
 
-bool z3fold_page_isolate(struct page *page, isolate_mode_t mode)
+static bool z3fold_page_isolate(struct page *page, isolate_mode_t mode)
 {
 	struct z3fold_header *zhdr;
 	struct z3fold_pool *pool;
@@ -1320,8 +1320,8 @@ bool z3fold_page_isolate(struct page *page, isolate_mode_t mode)
 	return false;
 }
 
-int z3fold_page_migrate(struct address_space *mapping, struct page *newpage,
-			struct page *page, enum migrate_mode mode)
+static int z3fold_page_migrate(struct address_space *mapping, struct page *newpage,
+			       struct page *page, enum migrate_mode mode)
 {
 	struct z3fold_header *zhdr, *new_zhdr;
 	struct z3fold_pool *pool;
@@ -1379,7 +1379,7 @@ int z3fold_page_migrate(struct address_space *mapping, struct page *newpage,
 	return 0;
 }
 
-void z3fold_page_putback(struct page *page)
+static void z3fold_page_putback(struct page *page)
 {
 	struct z3fold_header *zhdr;
 	struct z3fold_pool *pool;