All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: David Miller <davem@davemloft.net>
Cc: antoine.tenart@bootlin.com, netdev@vger.kernel.org,
	gregory.clement@bootlin.com, linux-kernel@vger.kernel.org,
	linux@armlinux.org.uk, nadavh@marvell.com,
	thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com,
	stefanc@marvell.com, mw@semihalf.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next] net: mvpp2: cls: Add Classification offload support
Date: Sat, 20 Apr 2019 12:17:14 +0200	[thread overview]
Message-ID: <20190420121714.387f160b@bootlin.com> (raw)
In-Reply-To: <20190419.150950.1875022930637674395.davem@davemloft.net>

Hi David,

On Fri, 19 Apr 2019 15:09:50 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:

>From: Maxime Chevallier <maxime.chevallier@bootlin.com>
>Date: Fri, 19 Apr 2019 15:30:27 +0200
>
>> +/* Internal represention of a Flow Steering rule */
>> +struct mvpp2_rfs_rule {
>> +	/* Rule location inside the flow*/
>> +	int loc;
>> +
>> +	/* Flow type, such as TCP_V4_FLOW, IP6_FLOW, etc. */
>> +	int flow_type;
>> +
>> +	/* The lookup type used by this flow. This allows the classification
>> +	 * engines to differentiate between entries that match the same
>> +	 * parameters
>> +	 */
>> +	int lu_type;
>> +
>> +	/* Index of the entry handling this rule in the flow table */
>> +	int flt_index;
>> +
>> +	/* Index of the C2 TCAM entry handling this rule */
>> +	int c2_index;  
>
>On 64-bit there will be a 32-bit hole here.  Why not put hek_fields
>and engine here?

You're right, I'll re-arrange that.

Thanks,

Maxime


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	antoine.tenart@bootlin.com, thomas.petazzoni@bootlin.com,
	gregory.clement@bootlin.com, miquel.raynal@bootlin.com,
	nadavh@marvell.com, stefanc@marvell.com, mw@semihalf.com,
	linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next] net: mvpp2: cls: Add Classification offload support
Date: Sat, 20 Apr 2019 12:17:14 +0200	[thread overview]
Message-ID: <20190420121714.387f160b@bootlin.com> (raw)
In-Reply-To: <20190419.150950.1875022930637674395.davem@davemloft.net>

Hi David,

On Fri, 19 Apr 2019 15:09:50 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:

>From: Maxime Chevallier <maxime.chevallier@bootlin.com>
>Date: Fri, 19 Apr 2019 15:30:27 +0200
>
>> +/* Internal represention of a Flow Steering rule */
>> +struct mvpp2_rfs_rule {
>> +	/* Rule location inside the flow*/
>> +	int loc;
>> +
>> +	/* Flow type, such as TCP_V4_FLOW, IP6_FLOW, etc. */
>> +	int flow_type;
>> +
>> +	/* The lookup type used by this flow. This allows the classification
>> +	 * engines to differentiate between entries that match the same
>> +	 * parameters
>> +	 */
>> +	int lu_type;
>> +
>> +	/* Index of the entry handling this rule in the flow table */
>> +	int flt_index;
>> +
>> +	/* Index of the C2 TCAM entry handling this rule */
>> +	int c2_index;  
>
>On 64-bit there will be a 32-bit hole here.  Why not put hek_fields
>and engine here?

You're right, I'll re-arrange that.

Thanks,

Maxime


  reply	other threads:[~2019-04-20 10:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-19 13:30 [PATCH net-next] net: mvpp2: cls: Add Classification offload support Maxime Chevallier
2019-04-19 13:30 ` Maxime Chevallier
2019-04-19 22:09 ` David Miller
2019-04-19 22:09   ` David Miller
2019-04-20 10:17   ` Maxime Chevallier [this message]
2019-04-20 10:17     ` Maxime Chevallier
2019-04-21  1:51 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190420121714.387f160b@bootlin.com \
    --to=maxime.chevallier@bootlin.com \
    --cc=antoine.tenart@bootlin.com \
    --cc=davem@davemloft.net \
    --cc=gregory.clement@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=miquel.raynal@bootlin.com \
    --cc=mw@semihalf.com \
    --cc=nadavh@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=stefanc@marvell.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.