All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Adam Ford <aford173@gmail.com>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
	Angus Ainslie <angus@akkea.ca>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	arm-soc <linux-arm-kernel@lists.infradead.org>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Chris Healy <cphealy@gmail.com>,
	Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [PATCH v3 1/9] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" clock to SDMA
Date: Sat, 20 Apr 2019 21:33:43 +0800	[thread overview]
Message-ID: <20190420133342.GB14187@dragon> (raw)
In-Reply-To: <CAHCN7xLczbdXx+TEQhsY1L3z09wPubvxX5SDO3Z1OzavPie0=Q@mail.gmail.com>

On Sat, Apr 20, 2019 at 07:14:26AM -0500, Adam Ford wrote:
> On Wed, Apr 10, 2019 at 9:30 PM Shawn Guo <shawnguo@kernel.org> wrote:
> >
> > On Thu, Mar 28, 2019 at 11:49:16PM -0700, Andrey Smirnov wrote:
> > > Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb"
> > > clock to determine if it needs to configure the IP block as operating
> > > at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both
> > > clocks as IMX6QDL_CLK_SDMA results in driver incorrectly thinking that
> > > ratio is 1:1 which results in broken SDMA funtionality(this at least
> > > breaks RAVE SP serdev driver on RDU2). Fix the code to specify
> > > IMX6QDL_CLK_IPG as "ipg" clock for SDMA, to avoid detecting incorrect
> > > clock ratio.
> > >
> > > Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check")
> >
> > Since we have a fix in the dma driver, I dropped the Fixes tag here.
> >
> > Applied all, thanks.
> 
> Do you know if the SDMA fixes will be back-ported to 5.0.y branch?  To
> get 5.0 working, I need to manually apply the patches.

I'm confused here.  The regression was caused by 25aaa75df1e6
("dmaengine: imx-sdma: add clock ratio 1:1 check"), which only lands on
mainline with v5.1-rc1.  How would 5.0.y branch need fixing?

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Adam Ford <aford173@gmail.com>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
	Angus Ainslie <angus@akkea.ca>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Chris Healy <cphealy@gmail.com>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	arm-soc <linux-arm-kernel@lists.infradead.org>,
	Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [PATCH v3 1/9] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" clock to SDMA
Date: Sat, 20 Apr 2019 21:33:43 +0800	[thread overview]
Message-ID: <20190420133342.GB14187@dragon> (raw)
In-Reply-To: <CAHCN7xLczbdXx+TEQhsY1L3z09wPubvxX5SDO3Z1OzavPie0=Q@mail.gmail.com>

On Sat, Apr 20, 2019 at 07:14:26AM -0500, Adam Ford wrote:
> On Wed, Apr 10, 2019 at 9:30 PM Shawn Guo <shawnguo@kernel.org> wrote:
> >
> > On Thu, Mar 28, 2019 at 11:49:16PM -0700, Andrey Smirnov wrote:
> > > Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb"
> > > clock to determine if it needs to configure the IP block as operating
> > > at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both
> > > clocks as IMX6QDL_CLK_SDMA results in driver incorrectly thinking that
> > > ratio is 1:1 which results in broken SDMA funtionality(this at least
> > > breaks RAVE SP serdev driver on RDU2). Fix the code to specify
> > > IMX6QDL_CLK_IPG as "ipg" clock for SDMA, to avoid detecting incorrect
> > > clock ratio.
> > >
> > > Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check")
> >
> > Since we have a fix in the dma driver, I dropped the Fixes tag here.
> >
> > Applied all, thanks.
> 
> Do you know if the SDMA fixes will be back-ported to 5.0.y branch?  To
> get 5.0 working, I need to manually apply the patches.

I'm confused here.  The regression was caused by 25aaa75df1e6
("dmaengine: imx-sdma: add clock ratio 1:1 check"), which only lands on
mainline with v5.1-rc1.  How would 5.0.y branch need fixing?

Shawn

  reply	other threads:[~2019-04-20 13:33 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-29  6:49 [PATCH v3 1/9] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" clock to SDMA Andrey Smirnov
2019-03-29  6:49 ` Andrey Smirnov
2019-03-29  6:49 ` [PATCH v3 2/9] ARM: dts: imx6sx: Specify IMX6SX_CLK_IPG " Andrey Smirnov
2019-03-29  6:49   ` Andrey Smirnov
2019-03-29  6:49 ` [PATCH v3 3/9] ARM: dts: imx7d: Specify IMX7D_CLK_IPG " Andrey Smirnov
2019-03-29  6:49   ` Andrey Smirnov
2019-03-29  6:49 ` [PATCH v3 4/9] ARM: dts: imx6ul: Specify IMX6UL_CLK_IPG " Andrey Smirnov
2019-03-29  6:49   ` Andrey Smirnov
2019-03-29  6:49 ` [PATCH v3 5/9] ARM: dts: imx6sll: Specify IMX6SLL_CLK_IPG " Andrey Smirnov
2019-03-29  6:49   ` Andrey Smirnov
2019-03-29  6:49 ` [PATCH v3 6/9] ARM: dts: imx6sx: Specify IMX6SX_CLK_IPG as "ahb" " Andrey Smirnov
2019-03-29  6:49   ` Andrey Smirnov
2019-03-29  6:49 ` [PATCH v3 7/9] ARM: dts: imx53: Specify IMX5_CLK_IPG " Andrey Smirnov
2019-03-29  6:49   ` Andrey Smirnov
2019-03-29  6:49 ` [PATCH v3 8/9] ARM: dts: imx51: " Andrey Smirnov
2019-03-29  6:49   ` Andrey Smirnov
2019-03-29  6:49 ` [PATCH v3 9/9] ARM: dts: imx50: " Andrey Smirnov
2019-03-29  6:49   ` Andrey Smirnov
2019-04-10 18:47 ` [PATCH v3 1/9] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" " Adam Ford
2019-04-10 18:47   ` Adam Ford
2019-04-11  2:30 ` Shawn Guo
2019-04-11  2:30   ` Shawn Guo
2019-04-20 12:14   ` Adam Ford
2019-04-20 12:14     ` Adam Ford
2019-04-20 13:33     ` Shawn Guo [this message]
2019-04-20 13:33       ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190420133342.GB14187@dragon \
    --to=shawnguo@kernel.org \
    --cc=aford173@gmail.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=angus@akkea.ca \
    --cc=cphealy@gmail.com \
    --cc=fabio.estevam@nxp.com \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.