From: Kevin Wolf <kwolf@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com,
fam@euphon.net, stefanha@redhat.com, den@virtuozzo.com,
eblake@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 3/3] iotests: test big qcow2 shrink
Date: Tue, 23 Apr 2019 11:15:05 +0200 [thread overview]
Message-ID: <20190423091505.GE9041@localhost.localdomain> (raw)
In-Reply-To: <20190422152315.74361-4-vsementsov@virtuozzo.com>
Am 22.04.2019 um 17:23 hat Vladimir Sementsov-Ogievskiy geschrieben:
> This test checks bug in qcow2_process_discards, fixed by previous
> commit.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Tested-by: Eric Blake <eblake@redhat.com>
Doesn't work for me (the exact value probably depends on the file
system, I'm testing on XFS):
--- /home/kwolf/source/qemu/tests/qemu-iotests/250.out 2019-04-23 10:41:27.972959135 +0200
+++ /home/kwolf/source/qemu/tests/qemu-iotests/250.out.bad 2019-04-23 11:09:48.035092870 +0200
@@ -12,10 +12,10 @@
0 0xa00000 0x82f00000 TEST_DIR/t.qcow2
0x82a00000 0xa00000 0x500000 TEST_DIR/t.qcow2
virtual size: 2.05 GiB (2202009600 bytes)
-disk size: 24 MiB
+disk size: 25 MiB
cluster_size: 1048576
Image resized.
virtual size: 5 MiB (5242880 bytes)
-disk size: 9 MiB
+disk size: 10 MiB
cluster_size: 1048576
*** done
Maybe the output of 'qemu-img map -f raw' would be more reliable?
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Wolf <kwolf@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: fam@euphon.net, den@virtuozzo.com, qemu-block@nongnu.org,
qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 3/3] iotests: test big qcow2 shrink
Date: Tue, 23 Apr 2019 11:15:05 +0200 [thread overview]
Message-ID: <20190423091505.GE9041@localhost.localdomain> (raw)
Message-ID: <20190423091505.3ITuJqM-e3gFR7jVujEVln1HvZx0_2so8Wk7DgIfmSk@z> (raw)
In-Reply-To: <20190422152315.74361-4-vsementsov@virtuozzo.com>
Am 22.04.2019 um 17:23 hat Vladimir Sementsov-Ogievskiy geschrieben:
> This test checks bug in qcow2_process_discards, fixed by previous
> commit.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Tested-by: Eric Blake <eblake@redhat.com>
Doesn't work for me (the exact value probably depends on the file
system, I'm testing on XFS):
--- /home/kwolf/source/qemu/tests/qemu-iotests/250.out 2019-04-23 10:41:27.972959135 +0200
+++ /home/kwolf/source/qemu/tests/qemu-iotests/250.out.bad 2019-04-23 11:09:48.035092870 +0200
@@ -12,10 +12,10 @@
0 0xa00000 0x82f00000 TEST_DIR/t.qcow2
0x82a00000 0xa00000 0x500000 TEST_DIR/t.qcow2
virtual size: 2.05 GiB (2202009600 bytes)
-disk size: 24 MiB
+disk size: 25 MiB
cluster_size: 1048576
Image resized.
virtual size: 5 MiB (5242880 bytes)
-disk size: 9 MiB
+disk size: 10 MiB
cluster_size: 1048576
*** done
Maybe the output of 'qemu-img map -f raw' would be more reliable?
Kevin
next prev parent reply other threads:[~2019-04-23 9:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 15:23 [Qemu-devel] [PATCH v4 0/3] Fix overflow bug in qcow2 discard Vladimir Sementsov-Ogievskiy
2019-04-22 15:23 ` Vladimir Sementsov-Ogievskiy
2019-04-22 15:23 ` [Qemu-devel] [PATCH v4 1/3] block/qcow2-refcount: add trace-point to qcow2_process_discards Vladimir Sementsov-Ogievskiy
2019-04-22 15:23 ` Vladimir Sementsov-Ogievskiy
2019-04-22 15:23 ` [Qemu-devel] [PATCH v4 2/3] block/io: bdrv_pdiscard: support int64_t bytes parameter Vladimir Sementsov-Ogievskiy
2019-04-22 15:23 ` Vladimir Sementsov-Ogievskiy
2019-04-23 8:54 ` Kevin Wolf
2019-04-23 8:54 ` Kevin Wolf
2019-04-22 15:23 ` [Qemu-devel] [PATCH v4 3/3] iotests: test big qcow2 shrink Vladimir Sementsov-Ogievskiy
2019-04-22 15:23 ` Vladimir Sementsov-Ogievskiy
2019-04-23 9:15 ` Kevin Wolf [this message]
2019-04-23 9:15 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423091505.GE9041@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=den@virtuozzo.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.