Re: [PATCH] [v7, 1/2] dt-bindings: panel: Add Boe Himax8279d is 1200x1920, 4-lane MIPI-DSI LCD panel

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2554 bytes --]

On Tue, Mar 26, 2019 at 03:02:08PM +0800, Jerry Han wrote:
> The Boe Himax8279d is a 8.0" panel with a 1200x1920 resolution and
> connected to DSI using four lanes.
> 
> V7:
> - Add the information of the reviewer
> 
> V6:
> - Add the information of the reviewer
> 
> V5:
> - Added changelog
> 
> V4:
> - None
> 
> V3:
> - None
> 
> V2:
> - Add compatible device "boe,himax8279d10p" (Sam)
> - Add the necessary property descriptions (Sam)
> 
> Signed-off-by: Jerry Han <hanxu5@huaqin.corp-partner.google.com>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> Reviewed-by: Derek Basehore <dbasehore@chromium.org>
> Cc: Jitao Shi <jitao.shi@mediatek.com>
> Cc: Rock wang <rock_wang@himax.com.cn>
> ---
>  .../bindings/display/panel/boe,himax8279d.txt | 24 +++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt

This is a device tree bindings patch, so it needs to be Cc'ed to the
device tree maintainers for review. devicetree@vger.kernel.org should be
in the Cc list, as should be Rob Herring, who does an excellent job at
reviewing device tree bindings.

Thierry

> 
> diff --git a/Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt b/Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt
> new file mode 100644
> index 000000000000..3caea2172b1b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt
> @@ -0,0 +1,24 @@
> +Boe Himax8279d 1200x1920 TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "boe,himax8279d8p" and one of: "boe,himax8279d10p"
> +- reg: DSI virtual channel of the peripheral
> +- enable-gpios: panel enable gpio
> +- pp33-gpios: a GPIO phandle for the 3.3v pin that provides the supply voltage
> +- pp18-gpios: a GPIO phandle for the 1.8v pin that provides the supply voltage
> +
> +Optional properties:
> +- backlight: phandle of the backlight device attached to the panel
> +
> +Example:
> +
> +	&mipi_dsi {
> +		panel {
> +			compatible = "boe,himax8279d8p", "boe,himax8279d10p";
> +			reg = <0>;
> +			backlight = <&backlight>;
> +			enable-gpios = <&gpio 45 GPIO_ACTIVE_HIGH>;
> +			pp33-gpios = <&gpio 35 GPIO_ACTIVE_HIGH>;
> +			pp18-gpios = <&gpio 36 GPIO_ACTIVE_HIGH>;
> +		};
> +	};
> -- 
> 2.17.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel