From: Boris Brezillon <boris.brezillon@collabora.com>
To: Vitor Soares <Vitor.Soares@synopsys.com>
Cc: "lars@metafoo.de" <lars@metafoo.de>,
"bbrezillon@kernel.org" <bbrezillon@kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"joao.pinto@synopsys.com" <Joao.Pinto@synopsys.com>,
"rafael@kernel.org" <rafael@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"lorenzo.bianconi83@gmail.com" <lorenzo.bianconi83@gmail.com>,
"linux-i3c@lists.infradead.org" <linux-i3c@lists.infradead.org>,
"jic23@kernel.org" <jic23@kernel.org>
Subject: Re: [PATCH 1/3] remap: Add I3C bus support
Date: Tue, 23 Apr 2019 17:14:16 +0200 [thread overview]
Message-ID: <20190423171416.47b2c9c4@collabora.com> (raw)
In-Reply-To: <13D59CF9CEBAF94592A12E8AE55501350A61C9A2@DE02WEMBXB.internal.synopsys.com>
On Tue, 23 Apr 2019 14:58:06 +0000
Vitor Soares <Vitor.Soares@synopsys.com> wrote:
> Hi Mark,
>
> From: Mark Brown <broonie@kernel.org>
> Date: Tue, Apr 16, 2019 at 16:39:48
>
> > On Mon, Apr 15, 2019 at 09:19:39PM +0200, Vitor Soares wrote:
> >
> > > +++ b/drivers/base/regmap/regmap-i3c.c
> > > @@ -0,0 +1,62 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * Copyright (c) 2018 Synopsys, Inc. and/or its affiliates.
> >
> > Please make the entire header C++ style so it looks more consistent.
> > Otherwise this looks good modulo
>
> I will change it next drop.
>
> > Boris' comment; I'm fine with leaving
> > extra modes for later so long as they can be introduced without
> > disrupting existing users so the only question there would be if we
> > should name the init function in some way that's specific to the I/O
> > mode being used here.
>
> My concern is that booth modes (SDR/HDR) might be needed on the device.
> e.g. use SDR to configure the device and use HDR to send/receive large
> data.
I'd say that we shouldn't use the regmap abstraction in this case or
have a driver-specific backend implementation for it. I guess the
common case is "regs are accessed in SDR mode", so let's keep the name
as it is now and we'll define devm_regmap_init_i3c_hdr() if we ever
need it. Please make it explicit in the kernel-doc that we're using SDR
transfers here.
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Vitor Soares <Vitor.Soares@synopsys.com>
Cc: Mark Brown <broonie@kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-i3c@lists.infradead.org" <linux-i3c@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"lars@metafoo.de" <lars@metafoo.de>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"jic23@kernel.org" <jic23@kernel.org>,
"lorenzo.bianconi83@gmail.com" <lorenzo.bianconi83@gmail.com>,
"bbrezillon@kernel.org" <bbrezillon@kernel.org>,
"rafael@kernel.org" <rafael@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"joao.pinto@synopsys.com" <Joao.Pinto@synopsys.com>
Subject: Re: [PATCH 1/3] remap: Add I3C bus support
Date: Tue, 23 Apr 2019 17:14:16 +0200 [thread overview]
Message-ID: <20190423171416.47b2c9c4@collabora.com> (raw)
In-Reply-To: <13D59CF9CEBAF94592A12E8AE55501350A61C9A2@DE02WEMBXB.internal.synopsys.com>
On Tue, 23 Apr 2019 14:58:06 +0000
Vitor Soares <Vitor.Soares@synopsys.com> wrote:
> Hi Mark,
>
> From: Mark Brown <broonie@kernel.org>
> Date: Tue, Apr 16, 2019 at 16:39:48
>
> > On Mon, Apr 15, 2019 at 09:19:39PM +0200, Vitor Soares wrote:
> >
> > > +++ b/drivers/base/regmap/regmap-i3c.c
> > > @@ -0,0 +1,62 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * Copyright (c) 2018 Synopsys, Inc. and/or its affiliates.
> >
> > Please make the entire header C++ style so it looks more consistent.
> > Otherwise this looks good modulo
>
> I will change it next drop.
>
> > Boris' comment; I'm fine with leaving
> > extra modes for later so long as they can be introduced without
> > disrupting existing users so the only question there would be if we
> > should name the init function in some way that's specific to the I/O
> > mode being used here.
>
> My concern is that booth modes (SDR/HDR) might be needed on the device.
> e.g. use SDR to configure the device and use HDR to send/receive large
> data.
I'd say that we shouldn't use the regmap abstraction in this case or
have a driver-specific backend implementation for it. I guess the
common case is "regs are accessed in SDR mode", so let's keep the name
as it is now and we'll define devm_regmap_init_i3c_hdr() if we ever
need it. Please make it explicit in the kernel-doc that we're using SDR
transfers here.
next prev parent reply other threads:[~2019-05-06 6:13 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 19:19 [PATCH 0/3] Add ST lsm6dso i3c suppport Vitor Soares
2019-04-15 19:19 ` Vitor Soares
2019-04-15 19:19 ` [PATCH 1/3] remap: Add I3C bus support Vitor Soares
2019-04-15 19:19 ` Vitor Soares
2019-04-16 6:15 ` Boris Brezillon
2019-04-16 6:15 ` Boris Brezillon
2019-04-16 14:41 ` Vitor Soares
2019-04-16 14:41 ` Vitor Soares
2019-04-16 15:39 ` Mark Brown
2019-04-23 14:58 ` Vitor Soares
2019-04-23 14:58 ` Vitor Soares
2019-04-23 15:14 ` Boris Brezillon [this message]
2019-04-23 15:14 ` Boris Brezillon
2019-04-23 15:55 ` Vitor Soares
2019-04-23 15:55 ` Vitor Soares
2019-04-15 19:19 ` [PATCH 2/3] i3c: Add i3c_get_device_id helper Vitor Soares
2019-04-15 19:19 ` Vitor Soares
2019-04-16 6:18 ` Boris Brezillon
2019-04-16 6:18 ` Boris Brezillon
2019-04-16 14:48 ` Vitor Soares
2019-04-16 14:48 ` Vitor Soares
2019-04-15 19:19 ` [PATCH 3/3] iio: imu: st_lsm6dsx: Add i3c basic support Vitor Soares
2019-04-15 19:19 ` Vitor Soares
2019-04-15 22:17 ` Lorenzo Bianconi
2019-04-15 22:17 ` Lorenzo Bianconi
2019-04-16 13:53 ` Vitor Soares
2019-04-16 13:53 ` Vitor Soares
2019-04-16 6:25 ` Boris Brezillon
2019-04-16 6:25 ` Boris Brezillon
2019-04-16 7:58 ` Lorenzo Bianconi
2019-04-16 7:58 ` Lorenzo Bianconi
2019-04-16 8:05 ` Boris Brezillon
2019-04-16 8:05 ` Boris Brezillon
2019-04-16 15:00 ` Vitor Soares
2019-04-16 15:00 ` Vitor Soares
2019-04-16 15:02 ` Vitor Soares
2019-04-16 15:02 ` Vitor Soares
2019-04-16 6:32 ` [PATCH 0/3] Add ST lsm6dso i3c suppport Boris Brezillon
2019-04-16 6:32 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423171416.47b2c9c4@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Vitor.Soares@synopsys.com \
--cc=bbrezillon@kernel.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.